* [PATCH] remove unbalanced kunmap
@ 2015-06-24 21:18 Benoît Canet
2015-06-24 21:18 ` [PATCH] libceph: Remove spurious kunmap() of the zero page Benoît Canet
2015-06-25 0:35 ` [PATCH] remove unbalanced kunmap Alex Elder
0 siblings, 2 replies; 6+ messages in thread
From: Benoît Canet @ 2015-06-24 21:18 UTC (permalink / raw)
To: ceph-devel; +Cc: idryomov, Benoît Canet
Spotted via visual inspection of the code.
Benoît Canet (1):
libceph: Remove spurious kunmap() of the zero page
net/ceph/messenger.c | 1 -
1 file changed, 1 deletion(-)
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] libceph: Remove spurious kunmap() of the zero page
2015-06-24 21:18 [PATCH] remove unbalanced kunmap Benoît Canet
@ 2015-06-24 21:18 ` Benoît Canet
2015-06-25 0:35 ` Alex Elder
2015-06-25 0:35 ` [PATCH] remove unbalanced kunmap Alex Elder
1 sibling, 1 reply; 6+ messages in thread
From: Benoît Canet @ 2015-06-24 21:18 UTC (permalink / raw)
To: ceph-devel; +Cc: idryomov, Benoît Canet
ceph_tcp_sendpage already does the work of mapping/unmapping
the zero page if needed.
Signed-off-by: Benoît Canet <benoit.canet@nodalink.com>
---
net/ceph/messenger.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/ceph/messenger.c b/net/ceph/messenger.c
index 967080a..38f06a4 100644
--- a/net/ceph/messenger.c
+++ b/net/ceph/messenger.c
@@ -278,7 +278,6 @@ static void _ceph_msgr_exit(void)
ceph_msgr_slab_exit();
BUG_ON(zero_page == NULL);
- kunmap(zero_page);
page_cache_release(zero_page);
zero_page = NULL;
}
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] libceph: Remove spurious kunmap() of the zero page
2015-06-24 21:18 ` [PATCH] libceph: Remove spurious kunmap() of the zero page Benoît Canet
@ 2015-06-25 0:35 ` Alex Elder
2015-06-25 9:12 ` Ilya Dryomov
0 siblings, 1 reply; 6+ messages in thread
From: Alex Elder @ 2015-06-25 0:35 UTC (permalink / raw)
To: Benoît Canet, ceph-devel; +Cc: idryomov
On 06/24/2015 04:18 PM, Benoît Canet wrote:
> ceph_tcp_sendpage already does the work of mapping/unmapping
> the zero page if needed.
>
> Signed-off-by: Benoît Canet <benoit.canet@nodalink.com>
This looks good.
Reviewed-by: Alex Elder <elder@linaro.org>
> ---
> net/ceph/messenger.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/net/ceph/messenger.c b/net/ceph/messenger.c
> index 967080a..38f06a4 100644
> --- a/net/ceph/messenger.c
> +++ b/net/ceph/messenger.c
> @@ -278,7 +278,6 @@ static void _ceph_msgr_exit(void)
> ceph_msgr_slab_exit();
>
> BUG_ON(zero_page == NULL);
> - kunmap(zero_page);
> page_cache_release(zero_page);
> zero_page = NULL;
> }
>
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] libceph: Remove spurious kunmap() of the zero page
2015-06-25 0:35 ` Alex Elder
@ 2015-06-25 9:12 ` Ilya Dryomov
0 siblings, 0 replies; 6+ messages in thread
From: Ilya Dryomov @ 2015-06-25 9:12 UTC (permalink / raw)
To: Alex Elder; +Cc: Benoît Canet, Ceph Development
On Thu, Jun 25, 2015 at 3:35 AM, Alex Elder <elder@ieee.org> wrote:
> On 06/24/2015 04:18 PM, Benoît Canet wrote:
>>
>> ceph_tcp_sendpage already does the work of mapping/unmapping
>> the zero page if needed.
>>
>> Signed-off-by: Benoît Canet <benoit.canet@nodalink.com>
>
>
> This looks good.
>
> Reviewed-by: Alex Elder <elder@linaro.org>
Applied.
Thanks,
Ilya
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] remove unbalanced kunmap
2015-06-24 21:18 [PATCH] remove unbalanced kunmap Benoît Canet
2015-06-24 21:18 ` [PATCH] libceph: Remove spurious kunmap() of the zero page Benoît Canet
@ 2015-06-25 0:35 ` Alex Elder
2015-06-25 0:38 ` Alex Elder
1 sibling, 1 reply; 6+ messages in thread
From: Alex Elder @ 2015-06-25 0:35 UTC (permalink / raw)
To: Benoît Canet, ceph-devel; +Cc: idryomov
On 06/24/2015 04:18 PM, Benoît Canet wrote:
> Spotted via visual inspection of the code.
>
> Benoît Canet (1):
> libceph: Remove spurious kunmap() of the zero page
>
> net/ceph/messenger.c | 1 -
> 1 file changed, 1 deletion(-)
>
I got no patch with this. Is it just me? -Alex
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-06-25 9:12 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-24 21:18 [PATCH] remove unbalanced kunmap Benoît Canet
2015-06-24 21:18 ` [PATCH] libceph: Remove spurious kunmap() of the zero page Benoît Canet
2015-06-25 0:35 ` Alex Elder
2015-06-25 9:12 ` Ilya Dryomov
2015-06-25 0:35 ` [PATCH] remove unbalanced kunmap Alex Elder
2015-06-25 0:38 ` Alex Elder
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.