All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Simek <michal.simek@xilinx.com>
To: Dan Carpenter
	<dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
	Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Ranjit Waghmode
	<ranjit.waghmode-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
Cc: "Michal Simek"
	<michal.simek-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>,
	"Sören Brinkmann"
	<soren.brinkmann-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>,
	linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [patch] spi: zynq: missing break statement
Date: Thu, 25 Jun 2015 08:32:27 +0000	[thread overview]
Message-ID: <558BBC9B.8030004@xilinx.com> (raw)
In-Reply-To: <20150624143133.GE1702@mwanda>

On 06/24/2015 04:31 PM, Dan Carpenter wrote:
> There is a missing break statement here so selecting both only selects
> upper.
> 
> Fixes: dfe11a11d523 ('spi: Add support for Zynq Ultrascale+ MPSoC GQSPI controller')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/drivers/spi/spi-zynqmp-gqspi.c b/drivers/spi/spi-zynqmp-gqspi.c
> index 87b20a5..f23f36e 100644
> --- a/drivers/spi/spi-zynqmp-gqspi.c
> +++ b/drivers/spi/spi-zynqmp-gqspi.c
> @@ -214,6 +214,7 @@ static void zynqmp_gqspi_selectslave(struct zynqmp_qspi *instanceptr,
>  	case GQSPI_SELECT_FLASH_CS_BOTH:
>  		instanceptr->genfifocs = GQSPI_GENFIFO_CS_LOWER |
>  			GQSPI_GENFIFO_CS_UPPER;
> +		break;
>  	case GQSPI_SELECT_FLASH_CS_UPPER:
>  		instanceptr->genfifocs = GQSPI_GENFIFO_CS_UPPER;
>  		break;
> 

Acked-by: Michal Simek <michal.simek@xilinx.com>

Thanks,
Michal

WARNING: multiple messages have this Message-ID (diff)
From: Michal Simek <michal.simek-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
To: Dan Carpenter
	<dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
	Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Ranjit Waghmode
	<ranjit.waghmode-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
Cc: "Michal Simek"
	<michal.simek-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>,
	"Sören Brinkmann"
	<soren.brinkmann-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>,
	linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [patch] spi: zynq: missing break statement
Date: Thu, 25 Jun 2015 10:32:27 +0200	[thread overview]
Message-ID: <558BBC9B.8030004@xilinx.com> (raw)
In-Reply-To: <20150624143133.GE1702@mwanda>

On 06/24/2015 04:31 PM, Dan Carpenter wrote:
> There is a missing break statement here so selecting both only selects
> upper.
> 
> Fixes: dfe11a11d523 ('spi: Add support for Zynq Ultrascale+ MPSoC GQSPI controller')
> Signed-off-by: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> 
> diff --git a/drivers/spi/spi-zynqmp-gqspi.c b/drivers/spi/spi-zynqmp-gqspi.c
> index 87b20a5..f23f36e 100644
> --- a/drivers/spi/spi-zynqmp-gqspi.c
> +++ b/drivers/spi/spi-zynqmp-gqspi.c
> @@ -214,6 +214,7 @@ static void zynqmp_gqspi_selectslave(struct zynqmp_qspi *instanceptr,
>  	case GQSPI_SELECT_FLASH_CS_BOTH:
>  		instanceptr->genfifocs = GQSPI_GENFIFO_CS_LOWER |
>  			GQSPI_GENFIFO_CS_UPPER;
> +		break;
>  	case GQSPI_SELECT_FLASH_CS_UPPER:
>  		instanceptr->genfifocs = GQSPI_GENFIFO_CS_UPPER;
>  		break;
> 

Acked-by: Michal Simek <michal.simek-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>

Thanks,
Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2015-06-25  8:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-24 14:31 [patch] spi: zynq: missing break statement Dan Carpenter
2015-06-24 14:31 ` Dan Carpenter
2015-06-25  8:32 ` Michal Simek [this message]
2015-06-25  8:32   ` Michal Simek
2015-07-07 18:48 ` Applied "spi: zynq: missing break statement" to the spi tree Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=558BBC9B.8030004@xilinx.com \
    --to=michal.simek@xilinx.com \
    --cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
    --cc=kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=michal.simek-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org \
    --cc=ranjit.waghmode-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org \
    --cc=soren.brinkmann-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.