All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vlastimil Babka <vbabka@suse.cz>
To: Joonsoo Kim <iamjoonsoo.kim@lge.com>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Mel Gorman <mgorman@suse.de>, Rik van Riel <riel@redhat.com>,
	David Rientjes <rientjes@google.com>,
	Minchan Kim <minchan@kernel.org>
Subject: Re: [RFC PATCH 03/10] mm/compaction: always update cached pfn
Date: Thu, 25 Jun 2015 11:08:30 +0200	[thread overview]
Message-ID: <558BC50E.3030000@suse.cz> (raw)
In-Reply-To: <1435193121-25880-4-git-send-email-iamjoonsoo.kim@lge.com>

I can has commit log? :)

On 06/25/2015 02:45 AM, Joonsoo Kim wrote:
> Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
> ---
>   mm/compaction.c | 11 +++++++++++
>   1 file changed, 11 insertions(+)
>
> diff --git a/mm/compaction.c b/mm/compaction.c
> index 9c5d43c..2d8e211 100644
> --- a/mm/compaction.c
> +++ b/mm/compaction.c
> @@ -510,6 +510,10 @@ isolate_fail:
>   	if (locked)
>   		spin_unlock_irqrestore(&cc->zone->lock, flags);
>
> +	if (blockpfn == end_pfn &&
> +		blockpfn > cc->zone->compact_cached_free_pfn)
> +		cc->zone->compact_cached_free_pfn = blockpfn;
> +
>   	update_pageblock_skip(cc, valid_page, total_isolated,
>   			*start_pfn, end_pfn, blockpfn, false);
>
> @@ -811,6 +815,13 @@ isolate_success:
>   	if (locked)
>   		spin_unlock_irqrestore(&zone->lru_lock, flags);
>
> +	if (low_pfn == end_pfn && cc->mode != MIGRATE_ASYNC) {
> +		int sync = cc->mode != MIGRATE_ASYNC;
> +
> +		if (low_pfn > zone->compact_cached_migrate_pfn[sync])
> +			zone->compact_cached_migrate_pfn[sync] = low_pfn;
> +	}
> +
>   	update_pageblock_skip(cc, valid_page, nr_isolated,
>   			start_pfn, end_pfn, low_pfn, true);
>
>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Vlastimil Babka <vbabka@suse.cz>
To: Joonsoo Kim <iamjoonsoo.kim@lge.com>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Mel Gorman <mgorman@suse.de>, Rik van Riel <riel@redhat.com>,
	David Rientjes <rientjes@google.com>,
	Minchan Kim <minchan@kernel.org>
Subject: Re: [RFC PATCH 03/10] mm/compaction: always update cached pfn
Date: Thu, 25 Jun 2015 11:08:30 +0200	[thread overview]
Message-ID: <558BC50E.3030000@suse.cz> (raw)
In-Reply-To: <1435193121-25880-4-git-send-email-iamjoonsoo.kim@lge.com>

I can has commit log? :)

On 06/25/2015 02:45 AM, Joonsoo Kim wrote:
> Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
> ---
>   mm/compaction.c | 11 +++++++++++
>   1 file changed, 11 insertions(+)
>
> diff --git a/mm/compaction.c b/mm/compaction.c
> index 9c5d43c..2d8e211 100644
> --- a/mm/compaction.c
> +++ b/mm/compaction.c
> @@ -510,6 +510,10 @@ isolate_fail:
>   	if (locked)
>   		spin_unlock_irqrestore(&cc->zone->lock, flags);
>
> +	if (blockpfn == end_pfn &&
> +		blockpfn > cc->zone->compact_cached_free_pfn)
> +		cc->zone->compact_cached_free_pfn = blockpfn;
> +
>   	update_pageblock_skip(cc, valid_page, total_isolated,
>   			*start_pfn, end_pfn, blockpfn, false);
>
> @@ -811,6 +815,13 @@ isolate_success:
>   	if (locked)
>   		spin_unlock_irqrestore(&zone->lru_lock, flags);
>
> +	if (low_pfn == end_pfn && cc->mode != MIGRATE_ASYNC) {
> +		int sync = cc->mode != MIGRATE_ASYNC;
> +
> +		if (low_pfn > zone->compact_cached_migrate_pfn[sync])
> +			zone->compact_cached_migrate_pfn[sync] = low_pfn;
> +	}
> +
>   	update_pageblock_skip(cc, valid_page, nr_isolated,
>   			start_pfn, end_pfn, low_pfn, true);
>
>


  reply	other threads:[~2015-06-25  9:08 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-25  0:45 [RFC PATCH 00/10] redesign compaction algorithm Joonsoo Kim
2015-06-25  0:45 ` Joonsoo Kim
2015-06-25  0:45 ` [RFC PATCH 01/10] mm/compaction: update skip-bit if whole pageblock is really scanned Joonsoo Kim
2015-06-25  0:45   ` Joonsoo Kim
2015-06-25  0:45 ` [RFC PATCH 02/10] mm/compaction: skip useless pfn for scanner's cached pfn Joonsoo Kim
2015-06-25  0:45   ` Joonsoo Kim
2015-06-25  0:45 ` [RFC PATCH 03/10] mm/compaction: always update " Joonsoo Kim
2015-06-25  0:45   ` Joonsoo Kim
2015-06-25  9:08   ` Vlastimil Babka [this message]
2015-06-25  9:08     ` Vlastimil Babka
2015-06-25  0:45 ` [RFC PATCH 04/10] mm/compaction: clean-up restarting condition check Joonsoo Kim
2015-06-25  0:45   ` Joonsoo Kim
2015-06-25  0:45 ` [RFC PATCH 05/10] mm/compaction: make freepage scanner scans non-movable pageblock Joonsoo Kim
2015-06-25  0:45   ` Joonsoo Kim
2015-06-25  0:45 ` [RFC PATCH 06/10] mm/compaction: introduce compaction depleted state on zone Joonsoo Kim
2015-06-25  0:45   ` Joonsoo Kim
2015-06-25  0:45 ` [RFC PATCH 07/10] mm/compaction: limit compaction activity in compaction depleted state Joonsoo Kim
2015-06-25  0:45   ` Joonsoo Kim
2015-06-25  0:45 ` [RFC PATCH 08/10] mm/compaction: remove compaction deferring Joonsoo Kim
2015-06-25  0:45   ` Joonsoo Kim
2015-06-25  0:45 ` [RFC PATCH 09/10] mm/compaction: redesign compaction Joonsoo Kim
2015-06-25  0:45   ` Joonsoo Kim
2015-06-25  0:45 ` [RFC PATCH 10/10] mm/compaction: new threshold for compaction depleted zone Joonsoo Kim
2015-06-25  0:45   ` Joonsoo Kim
2015-06-25 11:03 ` [RFC PATCH 00/10] redesign compaction algorithm Mel Gorman
2015-06-25 11:03   ` Mel Gorman
2015-06-25 17:11   ` Joonsoo Kim
2015-06-25 17:11     ` Joonsoo Kim
2015-06-25 17:25     ` Mel Gorman
2015-06-25 17:25       ` Mel Gorman
2015-06-25 18:14       ` Joonsoo Kim
2015-06-25 18:14         ` Joonsoo Kim
2015-06-25 18:41         ` Mel Gorman
2015-06-25 18:41           ` Mel Gorman
2015-06-26  2:07           ` Joonsoo Kim
2015-06-26  2:07             ` Joonsoo Kim
2015-06-26 10:22             ` Mel Gorman
2015-06-26 10:22               ` Mel Gorman
2015-07-08  8:24               ` Joonsoo Kim
2015-07-08  8:24                 ` Joonsoo Kim
2015-07-21  9:27                 ` Vlastimil Babka
2015-07-21  9:27                   ` Vlastimil Babka
2015-07-23  5:33                   ` Joonsoo Kim
2015-07-23  5:33                     ` Joonsoo Kim
2015-06-25 18:56         ` Vlastimil Babka
2015-06-25 18:56           ` Vlastimil Babka
2015-06-26  2:14           ` Joonsoo Kim
2015-06-26  2:14             ` Joonsoo Kim
2015-06-26 11:22             ` Vlastimil Babka
2015-06-26 11:22               ` Vlastimil Babka
2015-06-25 13:35 ` Vlastimil Babka
2015-06-25 13:35   ` Vlastimil Babka
2015-06-25 17:32   ` Joonsoo Kim
2015-06-25 17:32     ` Joonsoo Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=558BC50E.3030000@suse.cz \
    --to=vbabka@suse.cz \
    --cc=akpm@linux-foundation.org \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=minchan@kernel.org \
    --cc=riel@redhat.com \
    --cc=rientjes@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.