All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
To: Fabio Estevam <fabio.estevam@freescale.com>, <shawnguo@kernel.org>
Cc: <kernel@pengutronix.de>, <eric.nelson@boundarydevices.com>,
	<linux@arm.linux.org.uk>, <linux-arm-kernel@lists.infradead.org>,
	<Ying.liu@freescale.com>, <mturquette@baylibre.com>,
	<linux-clk@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] clk: imx: clk-imx6q: Provide initial IPU clock settings for mx6dl
Date: Thu, 25 Jun 2015 19:22:07 +0300	[thread overview]
Message-ID: <558C2AAF.1010707@mentor.com> (raw)
In-Reply-To: <1435241830-20187-2-git-send-email-fabio.estevam@freescale.com>

Hi Fabio,

On 25.06.2015 17:17, Fabio Estevam wrote:
> Currently it is not possible to use HDMI and LVDS at the same time on a 
> imx6dl-sabresd board.
> 
> Fix this usecase by setting IMX6QDL_CLK_PLL3_PFD1_540M to 540MHz and
> also by setting it as the parent of IMX6QDL_CLK_IPU1_SEL.
> 
> Based on the configuration done in the FSL kernel.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> Changes since v1:
> - None. Newly introduced.
> 
>  drivers/clk/imx/clk-imx6q.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/clk/imx/clk-imx6q.c b/drivers/clk/imx/clk-imx6q.c
> index d046f8e..d735d8f 100644
> --- a/drivers/clk/imx/clk-imx6q.c
> +++ b/drivers/clk/imx/clk-imx6q.c
> @@ -494,6 +494,11 @@ static void __init imx6q_clocks_init(struct device_node *ccm_node)
>  		clk_set_parent(clk[IMX6QDL_CLK_LDB_DI1_SEL], clk[IMX6QDL_CLK_PLL5_VIDEO_DIV]);
>  	}
>  
> +	if (clk_on_imx6dl()) {
> +		clk_set_rate(clk[IMX6QDL_CLK_PLL3_PFD1_540M], 540000000);

I believe here IMX6QDL_CLK_PLL3_PFD1_540M rate can be set independently
of SoC flavour.

> +		clk_set_parent(clk[IMX6QDL_CLK_IPU1_SEL], clk[IMX6QDL_CLK_PLL3_PFD1_540M]);
> +	}
> +
>  	clk_set_parent(clk[IMX6QDL_CLK_IPU1_DI0_PRE_SEL], clk[IMX6QDL_CLK_PLL5_VIDEO_DIV]);
>  	clk_set_parent(clk[IMX6QDL_CLK_IPU1_DI1_PRE_SEL], clk[IMX6QDL_CLK_PLL5_VIDEO_DIV]);
>  	clk_set_parent(clk[IMX6QDL_CLK_IPU2_DI0_PRE_SEL], clk[IMX6QDL_CLK_PLL5_VIDEO_DIV]);
> 

--
With best wishes,
Vladimir

WARNING: multiple messages have this Message-ID (diff)
From: vladimir_zapolskiy@mentor.com (Vladimir Zapolskiy)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/2] clk: imx: clk-imx6q: Provide initial IPU clock settings for mx6dl
Date: Thu, 25 Jun 2015 19:22:07 +0300	[thread overview]
Message-ID: <558C2AAF.1010707@mentor.com> (raw)
In-Reply-To: <1435241830-20187-2-git-send-email-fabio.estevam@freescale.com>

Hi Fabio,

On 25.06.2015 17:17, Fabio Estevam wrote:
> Currently it is not possible to use HDMI and LVDS at the same time on a 
> imx6dl-sabresd board.
> 
> Fix this usecase by setting IMX6QDL_CLK_PLL3_PFD1_540M to 540MHz and
> also by setting it as the parent of IMX6QDL_CLK_IPU1_SEL.
> 
> Based on the configuration done in the FSL kernel.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> Changes since v1:
> - None. Newly introduced.
> 
>  drivers/clk/imx/clk-imx6q.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/clk/imx/clk-imx6q.c b/drivers/clk/imx/clk-imx6q.c
> index d046f8e..d735d8f 100644
> --- a/drivers/clk/imx/clk-imx6q.c
> +++ b/drivers/clk/imx/clk-imx6q.c
> @@ -494,6 +494,11 @@ static void __init imx6q_clocks_init(struct device_node *ccm_node)
>  		clk_set_parent(clk[IMX6QDL_CLK_LDB_DI1_SEL], clk[IMX6QDL_CLK_PLL5_VIDEO_DIV]);
>  	}
>  
> +	if (clk_on_imx6dl()) {
> +		clk_set_rate(clk[IMX6QDL_CLK_PLL3_PFD1_540M], 540000000);

I believe here IMX6QDL_CLK_PLL3_PFD1_540M rate can be set independently
of SoC flavour.

> +		clk_set_parent(clk[IMX6QDL_CLK_IPU1_SEL], clk[IMX6QDL_CLK_PLL3_PFD1_540M]);
> +	}
> +
>  	clk_set_parent(clk[IMX6QDL_CLK_IPU1_DI0_PRE_SEL], clk[IMX6QDL_CLK_PLL5_VIDEO_DIV]);
>  	clk_set_parent(clk[IMX6QDL_CLK_IPU1_DI1_PRE_SEL], clk[IMX6QDL_CLK_PLL5_VIDEO_DIV]);
>  	clk_set_parent(clk[IMX6QDL_CLK_IPU2_DI0_PRE_SEL], clk[IMX6QDL_CLK_PLL5_VIDEO_DIV]);
> 

--
With best wishes,
Vladimir

  reply	other threads:[~2015-06-25 16:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-25 14:17 [PATCH v2 1/2] ARM: dts: imx6qdl-sabresd: Allow HDMI and LVDS to work simultaneously Fabio Estevam
2015-06-25 14:17 ` Fabio Estevam
2015-06-25 14:17 ` [PATCH v2 2/2] clk: imx: clk-imx6q: Provide initial IPU clock settings for mx6dl Fabio Estevam
2015-06-25 14:17   ` Fabio Estevam
2015-06-25 16:22   ` Vladimir Zapolskiy [this message]
2015-06-25 16:22     ` Vladimir Zapolskiy
2015-06-26 10:34 ` [PATCH v2 1/2] ARM: dts: imx6qdl-sabresd: Allow HDMI and LVDS to work simultaneously Philipp Zabel
2015-06-26 10:34   ` Philipp Zabel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=558C2AAF.1010707@mentor.com \
    --to=vladimir_zapolskiy@mentor.com \
    --cc=Ying.liu@freescale.com \
    --cc=eric.nelson@boundarydevices.com \
    --cc=fabio.estevam@freescale.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mturquette@baylibre.com \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.