From: ast@plumgrid.com (Alexei Starovoitov)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH] arm64: bpf: fix endianness conversion bugs
Date: Fri, 26 Jun 2015 01:25:59 -0700 [thread overview]
Message-ID: <558D0C97.2070107@plumgrid.com> (raw)
In-Reply-To: <1435282755-12011-1-git-send-email-xi.wang@gmail.com>
On 6/25/15 6:39 PM, Xi Wang wrote:
> Upper bits should be zeroed in endianness conversion:
>
> - even when there's no need to change endianness (i.e., BPF_FROM_BE
> on big endian or BPF_FROM_LE on little endian);
>
> - after rev16.
>
> This patch fixes such bugs by emitting extra instructions to clear
> upper bits.
>
> Cc: Zi Shen Lim<zlim.lnx@gmail.com>
> Cc: Alexei Starovoitov<ast@plumgrid.com>
> Fixes: e54bcde3d69d ("arm64: eBPF JIT compiler")
> Signed-off-by: Xi Wang<xi.wang@gmail.com>
Acked-by: Alexei Starovoitov <ast@plumgrid.com>
> The current testsuite catches the 16-bit bugs. I'll send a separate
> patch that extends test_bpf to catch the 32-bit ones.
looking forward to it. Thanks.
WARNING: multiple messages have this Message-ID (diff)
From: Alexei Starovoitov <ast@plumgrid.com>
To: Xi Wang <xi.wang@gmail.com>, linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org, Zi Shen Lim <zlim.lnx@gmail.com>
Subject: Re: [RFC PATCH] arm64: bpf: fix endianness conversion bugs
Date: Fri, 26 Jun 2015 01:25:59 -0700 [thread overview]
Message-ID: <558D0C97.2070107@plumgrid.com> (raw)
In-Reply-To: <1435282755-12011-1-git-send-email-xi.wang@gmail.com>
On 6/25/15 6:39 PM, Xi Wang wrote:
> Upper bits should be zeroed in endianness conversion:
>
> - even when there's no need to change endianness (i.e., BPF_FROM_BE
> on big endian or BPF_FROM_LE on little endian);
>
> - after rev16.
>
> This patch fixes such bugs by emitting extra instructions to clear
> upper bits.
>
> Cc: Zi Shen Lim<zlim.lnx@gmail.com>
> Cc: Alexei Starovoitov<ast@plumgrid.com>
> Fixes: e54bcde3d69d ("arm64: eBPF JIT compiler")
> Signed-off-by: Xi Wang<xi.wang@gmail.com>
Acked-by: Alexei Starovoitov <ast@plumgrid.com>
> The current testsuite catches the 16-bit bugs. I'll send a separate
> patch that extends test_bpf to catch the 32-bit ones.
looking forward to it. Thanks.
next prev parent reply other threads:[~2015-06-26 8:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-26 1:39 [RFC PATCH] arm64: bpf: fix endianness conversion bugs Xi Wang
2015-06-26 1:39 ` Xi Wang
2015-06-26 8:25 ` Alexei Starovoitov [this message]
2015-06-26 8:25 ` Alexei Starovoitov
2015-06-26 13:17 ` Catalin Marinas
2015-06-26 13:17 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=558D0C97.2070107@plumgrid.com \
--to=ast@plumgrid.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.