All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sasha.levin@oracle.com>
To: linux-mm@kvack.org
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
	kirill@shutemov.name
Subject: Re: [PATCH 00/11] mm: debug: formatting memory management structs
Date: Fri, 26 Jun 2015 17:34:21 -0400	[thread overview]
Message-ID: <558DC55D.3000804@oracle.com> (raw)
In-Reply-To: <1431623414-1905-1-git-send-email-sasha.levin@oracle.com>

There were no objections beyond Andrew's request for a better changelog.

If there are no any further objections, can it be merged please?

On 05/14/2015 01:10 PM, Sasha Levin wrote:
> This patch series adds knowledge about various memory management structures
> to the standard print functions.
> 
> In essence, it allows us to easily print those structures:
> 
> 	printk("%pZp %pZm %pZv", page, mm, vma);
> 
> This allows us to customize output when hitting bugs even further, thus
> we introduce VM_BUG() which allows printing anything when hitting a bug
> rather than just a single piece of information.
> 
> This also means we can get rid of VM_BUG_ON_* since they're now nothing
> more than a format string.
> 
> Changes since RFC:
>  - Address comments by Kirill.
> 
> Sasha Levin (11):
>   mm: debug: format flags in a buffer
>   mm: debug: deal with a new family of MM pointers
>   mm: debug: dump VMA into a string rather than directly on screen
>   mm: debug: dump struct MM into a string rather than directly on
>     screen
>   mm: debug: dump page into a string rather than directly on screen
>   mm: debug: clean unused code
>   mm: debug: VM_BUG()
>   mm: debug: kill VM_BUG_ON_PAGE
>   mm: debug: kill VM_BUG_ON_VMA
>   mm: debug: kill VM_BUG_ON_MM
>   mm: debug: use VM_BUG() to help with debug output
> 
>  arch/arm/mm/mmap.c               |    2 +-
>  arch/frv/mm/elf-fdpic.c          |    4 +-
>  arch/mips/mm/gup.c               |    4 +-
>  arch/parisc/kernel/sys_parisc.c  |    2 +-
>  arch/powerpc/mm/hugetlbpage.c    |    2 +-
>  arch/powerpc/mm/pgtable_64.c     |    4 +-
>  arch/s390/mm/gup.c               |    2 +-
>  arch/s390/mm/mmap.c              |    2 +-
>  arch/s390/mm/pgtable.c           |    6 +--
>  arch/sh/mm/mmap.c                |    2 +-
>  arch/sparc/kernel/sys_sparc_64.c |    4 +-
>  arch/sparc/mm/gup.c              |    2 +-
>  arch/sparc/mm/hugetlbpage.c      |    4 +-
>  arch/tile/mm/hugetlbpage.c       |    2 +-
>  arch/x86/kernel/sys_x86_64.c     |    2 +-
>  arch/x86/mm/gup.c                |    8 ++--
>  arch/x86/mm/hugetlbpage.c        |    2 +-
>  arch/x86/mm/pgtable.c            |    6 +--
>  include/linux/huge_mm.h          |    2 +-
>  include/linux/hugetlb.h          |    2 +-
>  include/linux/hugetlb_cgroup.h   |    4 +-
>  include/linux/mm.h               |   22 ++++-----
>  include/linux/mmdebug.h          |   40 ++++++----------
>  include/linux/page-flags.h       |   26 +++++-----
>  include/linux/pagemap.h          |   11 +++--
>  include/linux/rmap.h             |    2 +-
>  kernel/fork.c                    |    2 +-
>  lib/vsprintf.c                   |   22 +++++++++
>  mm/balloon_compaction.c          |    4 +-
>  mm/cleancache.c                  |    6 +--
>  mm/compaction.c                  |    2 +-
>  mm/debug.c                       |   98 ++++++++++++++++++++------------------
>  mm/filemap.c                     |   18 +++----
>  mm/gup.c                         |   12 ++---
>  mm/huge_memory.c                 |   50 +++++++++----------
>  mm/hugetlb.c                     |   28 +++++------
>  mm/hugetlb_cgroup.c              |    2 +-
>  mm/internal.h                    |    8 ++--
>  mm/interval_tree.c               |    2 +-
>  mm/kasan/report.c                |    2 +-
>  mm/ksm.c                         |   13 ++---
>  mm/memcontrol.c                  |   48 +++++++++----------
>  mm/memory.c                      |   10 ++--
>  mm/memory_hotplug.c              |    2 +-
>  mm/migrate.c                     |    6 +--
>  mm/mlock.c                       |    4 +-
>  mm/mmap.c                        |   15 +++---
>  mm/mremap.c                      |    4 +-
>  mm/page_alloc.c                  |   28 +++++------
>  mm/page_io.c                     |    4 +-
>  mm/pagewalk.c                    |    2 +-
>  mm/pgtable-generic.c             |    8 ++--
>  mm/rmap.c                        |   20 ++++----
>  mm/shmem.c                       |   10 ++--
>  mm/slub.c                        |    4 +-
>  mm/swap.c                        |   39 +++++++--------
>  mm/swap_state.c                  |   16 +++----
>  mm/swapfile.c                    |    8 ++--
>  mm/vmscan.c                      |   24 +++++-----
>  59 files changed, 355 insertions(+), 335 deletions(-)
> 

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Sasha Levin <sasha.levin@oracle.com>
To: linux-mm@kvack.org
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
	kirill@shutemov.name
Subject: Re: [PATCH 00/11] mm: debug: formatting memory management structs
Date: Fri, 26 Jun 2015 17:34:21 -0400	[thread overview]
Message-ID: <558DC55D.3000804@oracle.com> (raw)
In-Reply-To: <1431623414-1905-1-git-send-email-sasha.levin@oracle.com>

There were no objections beyond Andrew's request for a better changelog.

If there are no any further objections, can it be merged please?

On 05/14/2015 01:10 PM, Sasha Levin wrote:
> This patch series adds knowledge about various memory management structures
> to the standard print functions.
> 
> In essence, it allows us to easily print those structures:
> 
> 	printk("%pZp %pZm %pZv", page, mm, vma);
> 
> This allows us to customize output when hitting bugs even further, thus
> we introduce VM_BUG() which allows printing anything when hitting a bug
> rather than just a single piece of information.
> 
> This also means we can get rid of VM_BUG_ON_* since they're now nothing
> more than a format string.
> 
> Changes since RFC:
>  - Address comments by Kirill.
> 
> Sasha Levin (11):
>   mm: debug: format flags in a buffer
>   mm: debug: deal with a new family of MM pointers
>   mm: debug: dump VMA into a string rather than directly on screen
>   mm: debug: dump struct MM into a string rather than directly on
>     screen
>   mm: debug: dump page into a string rather than directly on screen
>   mm: debug: clean unused code
>   mm: debug: VM_BUG()
>   mm: debug: kill VM_BUG_ON_PAGE
>   mm: debug: kill VM_BUG_ON_VMA
>   mm: debug: kill VM_BUG_ON_MM
>   mm: debug: use VM_BUG() to help with debug output
> 
>  arch/arm/mm/mmap.c               |    2 +-
>  arch/frv/mm/elf-fdpic.c          |    4 +-
>  arch/mips/mm/gup.c               |    4 +-
>  arch/parisc/kernel/sys_parisc.c  |    2 +-
>  arch/powerpc/mm/hugetlbpage.c    |    2 +-
>  arch/powerpc/mm/pgtable_64.c     |    4 +-
>  arch/s390/mm/gup.c               |    2 +-
>  arch/s390/mm/mmap.c              |    2 +-
>  arch/s390/mm/pgtable.c           |    6 +--
>  arch/sh/mm/mmap.c                |    2 +-
>  arch/sparc/kernel/sys_sparc_64.c |    4 +-
>  arch/sparc/mm/gup.c              |    2 +-
>  arch/sparc/mm/hugetlbpage.c      |    4 +-
>  arch/tile/mm/hugetlbpage.c       |    2 +-
>  arch/x86/kernel/sys_x86_64.c     |    2 +-
>  arch/x86/mm/gup.c                |    8 ++--
>  arch/x86/mm/hugetlbpage.c        |    2 +-
>  arch/x86/mm/pgtable.c            |    6 +--
>  include/linux/huge_mm.h          |    2 +-
>  include/linux/hugetlb.h          |    2 +-
>  include/linux/hugetlb_cgroup.h   |    4 +-
>  include/linux/mm.h               |   22 ++++-----
>  include/linux/mmdebug.h          |   40 ++++++----------
>  include/linux/page-flags.h       |   26 +++++-----
>  include/linux/pagemap.h          |   11 +++--
>  include/linux/rmap.h             |    2 +-
>  kernel/fork.c                    |    2 +-
>  lib/vsprintf.c                   |   22 +++++++++
>  mm/balloon_compaction.c          |    4 +-
>  mm/cleancache.c                  |    6 +--
>  mm/compaction.c                  |    2 +-
>  mm/debug.c                       |   98 ++++++++++++++++++++------------------
>  mm/filemap.c                     |   18 +++----
>  mm/gup.c                         |   12 ++---
>  mm/huge_memory.c                 |   50 +++++++++----------
>  mm/hugetlb.c                     |   28 +++++------
>  mm/hugetlb_cgroup.c              |    2 +-
>  mm/internal.h                    |    8 ++--
>  mm/interval_tree.c               |    2 +-
>  mm/kasan/report.c                |    2 +-
>  mm/ksm.c                         |   13 ++---
>  mm/memcontrol.c                  |   48 +++++++++----------
>  mm/memory.c                      |   10 ++--
>  mm/memory_hotplug.c              |    2 +-
>  mm/migrate.c                     |    6 +--
>  mm/mlock.c                       |    4 +-
>  mm/mmap.c                        |   15 +++---
>  mm/mremap.c                      |    4 +-
>  mm/page_alloc.c                  |   28 +++++------
>  mm/page_io.c                     |    4 +-
>  mm/pagewalk.c                    |    2 +-
>  mm/pgtable-generic.c             |    8 ++--
>  mm/rmap.c                        |   20 ++++----
>  mm/shmem.c                       |   10 ++--
>  mm/slub.c                        |    4 +-
>  mm/swap.c                        |   39 +++++++--------
>  mm/swap_state.c                  |   16 +++----
>  mm/swapfile.c                    |    8 ++--
>  mm/vmscan.c                      |   24 +++++-----
>  59 files changed, 355 insertions(+), 335 deletions(-)
> 


  parent reply	other threads:[~2015-06-26 21:34 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-14 17:10 [PATCH 00/11] mm: debug: formatting memory management structs Sasha Levin
2015-05-14 17:10 ` Sasha Levin
2015-05-14 17:10 ` [PATCH 01/11] mm: debug: format flags in a buffer Sasha Levin
2015-05-14 17:10   ` Sasha Levin
2015-05-14 17:10 ` [PATCH 02/11] mm: debug: deal with a new family of MM pointers Sasha Levin
2015-05-14 17:10   ` Sasha Levin
2015-05-14 17:10 ` [PATCH 03/11] mm: debug: dump VMA into a string rather than directly on screen Sasha Levin
2015-05-14 17:10   ` Sasha Levin
2015-05-14 17:10 ` [PATCH 04/11] mm: debug: dump struct MM " Sasha Levin
2015-05-14 17:10   ` Sasha Levin
2015-05-14 17:10 ` [PATCH 05/11] mm: debug: dump page " Sasha Levin
2015-05-14 17:10   ` Sasha Levin
2015-06-30 23:35   ` David Rientjes
2015-06-30 23:35     ` David Rientjes
2015-07-01  8:53     ` Kirill A. Shutemov
2015-07-01  8:53       ` Kirill A. Shutemov
2015-07-01 19:21     ` Sasha Levin
2015-07-01 19:21       ` Sasha Levin
2015-07-01 21:25       ` David Rientjes
2015-07-01 21:25         ` David Rientjes
2015-07-01 21:34         ` Kirill A. Shutemov
2015-07-01 21:34           ` Kirill A. Shutemov
2015-07-01 22:33         ` Vlastimil Babka
2015-07-01 22:33           ` Vlastimil Babka
2015-07-01 22:50         ` Sasha Levin
2015-07-01 22:50           ` Sasha Levin
2015-07-08 23:58           ` David Rientjes
2015-07-08 23:58             ` David Rientjes
2015-08-06 15:08             ` Sasha Levin
2015-08-06 15:08               ` Sasha Levin
2015-05-14 17:10 ` [PATCH 06/11] mm: debug: clean unused code Sasha Levin
2015-05-14 17:10   ` Sasha Levin
2015-05-14 17:10 ` [PATCH 07/11] mm: debug: VM_BUG() Sasha Levin
2015-05-14 17:10   ` Sasha Levin
2015-05-14 17:10 ` [PATCH 08/11] mm: debug: kill VM_BUG_ON_PAGE Sasha Levin
2015-05-14 17:10   ` Sasha Levin
2015-05-14 17:10 ` [PATCH 09/11] mm: debug: kill VM_BUG_ON_VMA Sasha Levin
2015-05-14 17:10   ` Sasha Levin
2015-05-14 17:10 ` [PATCH 10/11] mm: debug: kill VM_BUG_ON_MM Sasha Levin
2015-05-14 17:10   ` Sasha Levin
2015-05-14 17:10 ` [PATCH 11/11] mm: debug: use VM_BUG() to help with debug output Sasha Levin
2015-05-14 17:10   ` Sasha Levin
2015-05-14 20:24 ` [PATCH 00/11] mm: debug: formatting memory management structs Andrew Morton
2015-05-14 20:24   ` Andrew Morton
2015-05-14 20:26   ` Sasha Levin
2015-05-14 20:26     ` Sasha Levin
2015-06-26 21:34 ` Sasha Levin [this message]
2015-06-26 21:34   ` Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=558DC55D.3000804@oracle.com \
    --to=sasha.levin@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=kirill@shutemov.name \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.