All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@citrix.com>
To: Florian Westphal <fw@strlen.de>
Cc: Wei Liu <wei.liu2@citrix.com>,
	Ian Campbell <ian.campbell@citrix.com>,
	netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
	bernhard.thaler@wvnet.at,
	xen-devel <xen-devel@lists.xenproject.org>,
	pablo@netfilter.org, David Vrabel <david.vrabel@citrix.com>
Subject: Re: [Bridge] [Xen-devel] Unable to unregister netdevice after "netfilter: bridge: forward IPv6 fragmented packets"
Date: Tue, 30 Jun 2015 11:33:57 +0100	[thread overview]
Message-ID: <55927095.1060607@citrix.com> (raw)
In-Reply-To: <20150629185525.GF2324@breakpoint.cc>

Hi Florian,

On 29/06/15 19:55, Florian Westphal wrote:
> Julien Grall <julien.grall@citrix.com> wrote:
>> I tried to run the latest Linux tree
>> (4a10a91756ef381bced7b88cfb9232f660b92d93) as DOM0 Xen.
>> After destroying a guest using network, I got the following
>> lines in the DOM0 kernel log:
>>
>> unregister_netdevice: waiting for vif1.0 to become free. Usage count = 1
>>
>> The bisector pointed the problem after the commit
>> efb6de9b4ba0092b2c55f6a52d16294a8a698edd
>> "netfilter: bridge: forward IPv6 fragmented packets".
> 
> Seems we can leak skb in br_nf_dev_queue_xmit()...  Does this fix the problem?

It doesn't resolve the problem. I added some printk to see if the fixed
paths are executed and I don't see any.

Regards,


-- 
Julien Grall

WARNING: multiple messages have this Message-ID (diff)
From: Julien Grall <julien.grall@citrix.com>
To: Florian Westphal <fw@strlen.de>
Cc: Wei Liu <wei.liu2@citrix.com>,
	Ian Campbell <ian.campbell@citrix.com>, <netdev@vger.kernel.org>,
	<bridge@lists.linux-foundation.org>, <stephen@networkplumber.org>,
	<bernhard.thaler@wvnet.at>,
	xen-devel <xen-devel@lists.xenproject.org>, <pablo@netfilter.org>,
	David Vrabel <david.vrabel@citrix.com>
Subject: Re: [Xen-devel] Unable to unregister netdevice after "netfilter: bridge: forward IPv6 fragmented packets"
Date: Tue, 30 Jun 2015 11:33:57 +0100	[thread overview]
Message-ID: <55927095.1060607@citrix.com> (raw)
In-Reply-To: <20150629185525.GF2324@breakpoint.cc>

Hi Florian,

On 29/06/15 19:55, Florian Westphal wrote:
> Julien Grall <julien.grall@citrix.com> wrote:
>> I tried to run the latest Linux tree
>> (4a10a91756ef381bced7b88cfb9232f660b92d93) as DOM0 Xen.
>> After destroying a guest using network, I got the following
>> lines in the DOM0 kernel log:
>>
>> unregister_netdevice: waiting for vif1.0 to become free. Usage count = 1
>>
>> The bisector pointed the problem after the commit
>> efb6de9b4ba0092b2c55f6a52d16294a8a698edd
>> "netfilter: bridge: forward IPv6 fragmented packets".
> 
> Seems we can leak skb in br_nf_dev_queue_xmit()...  Does this fix the problem?

It doesn't resolve the problem. I added some printk to see if the fixed
paths are executed and I don't see any.

Regards,


-- 
Julien Grall

  parent reply	other threads:[~2015-06-30 10:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-29 16:03 [Bridge] Unable to unregister netdevice after "netfilter: bridge: forward IPv6 fragmented packets" Julien Grall
2015-06-29 16:03 ` Julien Grall
2015-06-29 18:55 ` Florian Westphal
2015-06-29 18:55 ` [Bridge] " Florian Westphal
2015-06-29 18:55   ` Florian Westphal
2015-06-30 10:33   ` Julien Grall
2015-06-30 10:33   ` Julien Grall [this message]
2015-06-30 10:33     ` [Xen-devel] " Julien Grall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55927095.1060607@citrix.com \
    --to=julien.grall@citrix.com \
    --cc=bernhard.thaler@wvnet.at \
    --cc=bridge@lists.linux-foundation.org \
    --cc=david.vrabel@citrix.com \
    --cc=fw@strlen.de \
    --cc=ian.campbell@citrix.com \
    --cc=netdev@vger.kernel.org \
    --cc=pablo@netfilter.org \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.