All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leon Alrae <leon.alrae@imgtec.com>
To: Andrew Bennett <Andrew.Bennett@imgtec.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: Riku Voipio <riku.voipio@iki.fi>
Subject: Re: [Qemu-devel] [PATCH] linux-user: Fix MIPS N64 trap and break instruction bug
Date: Tue, 30 Jun 2015 14:18:10 +0100	[thread overview]
Message-ID: <55929712.4090509@imgtec.com> (raw)
In-Reply-To: <0DA23CC379F5F945ACB41CF394B98277210E9658@LEMAIL01.le.imgtec.org>

On 29/06/2015 11:20, Andrew Bennett wrote:
> From: Andrew Bennett <andrew.bennett@imgtec.com>
> 
> For the MIPS N64 ABI when QEMU reads the break/trap instruction so that
> it can inspect the break/trap code it reads 8 rather than 4 bytes
> which means it finds the code field from the instruction after the 
> break/trap instruction.  This then causes the break/trap handling
> code to fail because it does not understand the code number.
> 
> The fix forces QEMU to always read 4 bytes of instruction data rather
> than deciding how much to read based on the ABI.
> 
> Signed-off-by: Andrew Bennett <andrew.bennett@imgtec.com>
> ---
>  linux-user/main.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Leon Alrae <leon.alrae@imgtec.com>

Thanks,
Leon

  reply	other threads:[~2015-06-30 13:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-29 10:20 [Qemu-devel] [PATCH] linux-user: Fix MIPS N64 trap and break instruction bug Andrew Bennett
2015-06-30 13:18 ` Leon Alrae [this message]
2015-07-15 15:54   ` Leon Alrae

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55929712.4090509@imgtec.com \
    --to=leon.alrae@imgtec.com \
    --cc=Andrew.Bennett@imgtec.com \
    --cc=qemu-devel@nongnu.org \
    --cc=riku.voipio@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.