From: vitalya@ti.com (Vitaly Andrianov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] keystone: adds cpu_die implementation
Date: Tue, 30 Jun 2015 09:47:55 -0400 [thread overview]
Message-ID: <55929E0B.9070704@ti.com> (raw)
In-Reply-To: <20150629213737.GF7557@n2100.arm.linux.org.uk>
On 06/29/2015 05:37 PM, Russell King - ARM Linux wrote:
> On Mon, Jun 29, 2015 at 10:28:14PM +0100, Russell King - ARM Linux wrote:
>> On Mon, Jun 29, 2015 at 02:43:44PM -0400, Vitaly Andrianov wrote:
>>>
>>>
>>> On 06/29/2015 01:52 PM, Mark Rutland wrote:
>>>> On Mon, Jun 29, 2015 at 06:52:32PM +0100, Vitaly Andrianov wrote:
>>>>> This commit add cpu_die implementation
>>>>>
>>>>> Signed-off-by: Vitaly Andrianov <vitalya@ti.com>
>>>>> ---
>>>>>
>>>>> The discussion of the "keystone: psci: adds cpu_die implementation" commit
>>>>> shows that if PCSI is enabled platform code doesn't need that implementation
>>>>> at all. Having PSCI commands in DTB should be sufficient. Unfortunately
>>>>> Keystone with LPAE enable requires some additional development.
>>>>
>>>> I don't follow.
>>>>
>>>> What do you need to implement for LPAE?
>>> Hi Mark,
>>>
>>> The Keystone platform needs to set ttbr1 when it boots secondary core.
>>> It is done in the keystone_smp_secondary_initmem(), which is
>>> .smp_secondary_init member of the keystone_smp_ops. I couldn't find a way
>>> how I can add similar function to psci_smp_ops.
>>
>> TTBR1 will be set by generic code. You don't need to do anything special
>> now that my fixes for TI's horrid physical address space switch are in.
>> (you may remember, you tested the patches...)
>
> Oh, it was Murali who tested it, not yourself. Sorry. Suggest you
> dig out the patches either from mainline (they're in Linus' tip) or
> ask Murali for them...
>
Thanks Russell,
Excellent. I'll test how it will work using PSCI framework.
Regards,
Vitaly
WARNING: multiple messages have this Message-ID (diff)
From: Vitaly Andrianov <vitalya@ti.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Mark Rutland <mark.rutland@arm.com>,
"grygorii.strashko@ti.com" <grygorii.strashko@ti.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>,
"ssantosh@kernel.org" <ssantosh@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] keystone: adds cpu_die implementation
Date: Tue, 30 Jun 2015 09:47:55 -0400 [thread overview]
Message-ID: <55929E0B.9070704@ti.com> (raw)
In-Reply-To: <20150629213737.GF7557@n2100.arm.linux.org.uk>
On 06/29/2015 05:37 PM, Russell King - ARM Linux wrote:
> On Mon, Jun 29, 2015 at 10:28:14PM +0100, Russell King - ARM Linux wrote:
>> On Mon, Jun 29, 2015 at 02:43:44PM -0400, Vitaly Andrianov wrote:
>>>
>>>
>>> On 06/29/2015 01:52 PM, Mark Rutland wrote:
>>>> On Mon, Jun 29, 2015 at 06:52:32PM +0100, Vitaly Andrianov wrote:
>>>>> This commit add cpu_die implementation
>>>>>
>>>>> Signed-off-by: Vitaly Andrianov <vitalya@ti.com>
>>>>> ---
>>>>>
>>>>> The discussion of the "keystone: psci: adds cpu_die implementation" commit
>>>>> shows that if PCSI is enabled platform code doesn't need that implementation
>>>>> at all. Having PSCI commands in DTB should be sufficient. Unfortunately
>>>>> Keystone with LPAE enable requires some additional development.
>>>>
>>>> I don't follow.
>>>>
>>>> What do you need to implement for LPAE?
>>> Hi Mark,
>>>
>>> The Keystone platform needs to set ttbr1 when it boots secondary core.
>>> It is done in the keystone_smp_secondary_initmem(), which is
>>> .smp_secondary_init member of the keystone_smp_ops. I couldn't find a way
>>> how I can add similar function to psci_smp_ops.
>>
>> TTBR1 will be set by generic code. You don't need to do anything special
>> now that my fixes for TI's horrid physical address space switch are in.
>> (you may remember, you tested the patches...)
>
> Oh, it was Murali who tested it, not yourself. Sorry. Suggest you
> dig out the patches either from mainline (they're in Linus' tip) or
> ask Murali for them...
>
Thanks Russell,
Excellent. I'll test how it will work using PSCI framework.
Regards,
Vitaly
next prev parent reply other threads:[~2015-06-30 13:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-29 17:52 [PATCH] keystone: adds cpu_die implementation Vitaly Andrianov
2015-06-29 17:52 ` Vitaly Andrianov
2015-06-29 17:52 ` Mark Rutland
2015-06-29 17:52 ` Mark Rutland
2015-06-29 18:43 ` Vitaly Andrianov
2015-06-29 18:43 ` Vitaly Andrianov
2015-06-29 21:12 ` santosh.shilimkar at oracle.com
2015-06-29 21:12 ` santosh.shilimkar
2015-06-29 21:28 ` Russell King - ARM Linux
2015-06-29 21:28 ` Russell King - ARM Linux
2015-06-29 21:37 ` Russell King - ARM Linux
2015-06-29 21:37 ` Russell King - ARM Linux
2015-06-30 13:47 ` Vitaly Andrianov [this message]
2015-06-30 13:47 ` Vitaly Andrianov
2015-06-30 14:54 ` Russell King - ARM Linux
2015-06-30 14:54 ` Russell King - ARM Linux
2015-06-30 16:38 ` Vitaly Andrianov
2015-06-30 16:38 ` Vitaly Andrianov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55929E0B.9070704@ti.com \
--to=vitalya@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.