All of lore.kernel.org
 help / color / mirror / Atom feed
From: George Dunlap <george.dunlap@eu.citrix.com>
To: Ian Campbell <ian.campbell@citrix.com>
Cc: xen-devel@lists.xenproject.org,
	Ian Jackson <ian.jackson@eu.citrix.com>,
	Wei Liu <wei.liu2@citrix.com>,
	Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [PATCH] libxl: locally attach disks with hotplug scripts for bootloader execution
Date: Tue, 30 Jun 2015 15:15:15 +0100	[thread overview]
Message-ID: <5592A473.1020403@eu.citrix.com> (raw)
In-Reply-To: <1435667719.21469.127.camel@citrix.com>

On 06/30/2015 01:35 PM, Ian Campbell wrote:
> On Thu, 2015-06-25 at 18:22 +0100, George Dunlap wrote:
>> Although having said that -- isn't there also a bug here wrt qdisk
>> backends in a driver domain not being attached?
>>
>> Could we do something like the attached patch?
> 
> As an alternative (rather than an incremental) to Roger's, right?
> 
> I didn't have any comments (i.e. LGTM) but I was hoping for an ack or
> R-by/T-by from Roger.

I think he was waiting for me to confirm that it would work with blktap,
which I haven't had time to test yet.

Or rather, I've tested it with my new
use-blktap-scripts-rather-than-the-library patches, but we want to avoid
regressions if we can.

 -George

  reply	other threads:[~2015-06-30 14:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-25 14:17 [PATCH] libxl: locally attach disks with hotplug scripts for bootloader execution Roger Pau Monne
2015-06-25 16:30 ` George Dunlap
2015-06-25 17:22 ` George Dunlap
2015-06-29  8:35   ` Roger Pau Monné
2015-06-30 12:35   ` Ian Campbell
2015-06-30 14:15     ` George Dunlap [this message]
2015-06-30 12:31 ` Ian Campbell
2015-06-30 13:55   ` Roger Pau Monné

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5592A473.1020403@eu.citrix.com \
    --to=george.dunlap@eu.citrix.com \
    --cc=ian.campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=roger.pau@citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.