Re: [meta-browser][PATCH v2] chromium: List all PACKAGECONFIG settings to avoid warning

[Robert Yang <liezhi.yang@windriver.com>]

Hi Gary,

On 07/01/2015 04:55 AM, Gary Thomas wrote:
> OE-core now warns if PACKAGECONFIG is used to set an option that
> does not have a corresponding PACKAGECONFIG[option]="xxx" line.
> This recipe makes use of many such options & this patch suppresses
> those warnings by listing the options.
>
> Signed-off-by: Gary Thomas <gary@mlbassoc.com>
> ---
>   recipes-browser/chromium/chromium.inc | 7 +++++++
>   1 file changed, 7 insertions(+)
>
> diff --git a/recipes-browser/chromium/chromium.inc b/recipes-browser/chromium/chromium.inc
> index 8e83f6a..973d1c9 100644
> --- a/recipes-browser/chromium/chromium.inc
> +++ b/recipes-browser/chromium/chromium.inc
> @@ -17,6 +17,13 @@ PACKAGECONFIG ??= "use-egl"
>   # automatically and silently fall back to GLX
>   PACKAGECONFIG[use-egl] = ",,virtual/egl virtual/libgles2"
>
> +# Additional PACKAGECONFIG options - listed here to avoid warnings
> +PACKAGECONFIG[component-build] = ""
> +PACKAGECONFIG[disable-api-keys-info-bar] = ""
> +PACKAGECONFIG[ignore-lost-context] = ""
> +PACKAGECONFIG[impl-side-painting] = ""
> +PACKAGECONFIG[use-gl] = ""

Since you don't really use PACKAGECONFIG, why not use
ANY_OTHER_VALUE_YOU_LIKE rather than PACKAGECONFIG to configure it ?

// Robert


> +
>   GYP_DEFINES += "${ARMFPABI} release_extra_cflags='-Wno-error=unused-local-typedefs' sysroot=''"
>
>   do_configure() {
>