All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gary Thomas <gary@mlbassoc.com>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [meta-browser][PATCH v2] chromium: List all PACKAGECONFIG settings to avoid warning
Date: Wed, 01 Jul 2015 09:54:03 -0600	[thread overview]
Message-ID: <55940D1B.2070105@mlbassoc.com> (raw)
In-Reply-To: <CAJTo0LZVwcE2JHe5CAaaXHHKKMPJdWqC2Tw_OTQfaza_2DTcCQ@mail.gmail.com>

On 2015-07-01 09:47, Burton, Ross wrote:
> On 1 July 2015 at 15:12, Gary Thomas <gary@mlbassoc.com> wrote:
>
>> No, it's much better to use the standard mechanism (PACKAGECONFIG) rather
>> than making up something special for this recipe.  The patch is needed only
>> to suppress warnings about how it's being used.
>>
>
> I kinda of agree with Robert here - the standard method isn't being used,
> but the variable is being used.

Actually, it *is* using PACKAGECONFIG correctly for some of the settings.

>
> As the chromium recipe doesn't inherit autotools EXTRA_OECONF will only be
> set by the PACKAGECONFIG handler, so it would be an improvement if the
> enable/disable arguments were specified as usual in the flags and then
> EXTRA_OEGYP just included EXTRA_OECONF.  (untested but might work, cmake
> recipes certainly did this)

I didn't write this recipe and just wanted to reduce the warnings.
If someone else wants to rework it, that would be great.

-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------


  reply	other threads:[~2015-07-01 15:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-30 20:55 [meta-browser][PATCH v2] chromium: List all PACKAGECONFIG settings to avoid warning Gary Thomas
2015-07-01  8:22 ` Robert Yang
2015-07-01 14:12   ` Gary Thomas
2015-07-01 15:47     ` Burton, Ross
2015-07-01 15:54       ` Gary Thomas [this message]
2015-07-01 19:36       ` Max Krummenacher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55940D1B.2070105@mlbassoc.com \
    --to=gary@mlbassoc.com \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.