All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: elena.ufimtseva@oracle.com, xen-devel@lists.xen.org
Cc: yang.z.zhang@intel.com, kevin.tian@intel.com, tim@xen.org,
	boris.ostrovsky@oracle.com, jbeulich@suse.com
Subject: Re: [PATCH v4] dmar: device scope mem leak fix
Date: Wed, 1 Jul 2015 11:00:45 +0100	[thread overview]
Message-ID: <5593BA4D.7000409@citrix.com> (raw)
In-Reply-To: <1435706410-24751-1-git-send-email-elena.ufimtseva@oracle.com>

On 01/07/15 00:20, elena.ufimtseva@oracle.com wrote:
> --- a/xen/drivers/passthrough/vtd/dmar.c
> +++ b/xen/drivers/passthrough/vtd/dmar.c
> @@ -81,6 +81,13 @@ static int __init acpi_register_rmrr_unit(struct acpi_rmrr_unit *rmrr)
>      return 0;
>  }
>  
> +static void scope_devices_free(struct dmar_scope *scope)
> +{
> +    if ( scope )
> +        scope->devices_cnt = 0;
> +    xfree(scope->devices);

This is very liable to suffer a NULL pointer dereference.

~Andrew

  reply	other threads:[~2015-07-01 10:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-30 23:20 [PATCH v4] dmar: device scope mem leak fix elena.ufimtseva
2015-07-01 10:00 ` Andrew Cooper [this message]
2015-07-01 18:15   ` Elena Ufimtseva

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5593BA4D.7000409@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=elena.ufimtseva@oracle.com \
    --cc=jbeulich@suse.com \
    --cc=kevin.tian@intel.com \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xen.org \
    --cc=yang.z.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.