From: vitalya@ti.com (Vitaly Andrianov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] keystone: dts: add psci command definition
Date: Wed, 1 Jul 2015 09:05:31 -0400 [thread overview]
Message-ID: <5593E59B.9090304@ti.com> (raw)
In-Reply-To: <20150701124101.GB2310@leverpostej>
On 07/01/2015 08:41 AM, Mark Rutland wrote:
> On Wed, Jul 01, 2015 at 01:13:04PM +0100, Vitaly Andrianov wrote:
>> This commit adds definition for cpu_on, cpu_off and cpu_suspend commands.
>> These definitions must match the corresponding PSCI definitions in
>> boot monitor.
>>
>> Signed-off-by: Vitaly Andrianov <vitalya@ti.com>
>> ---
>> arch/arm/boot/dts/keystone.dtsi | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/keystone.dtsi b/arch/arm/boot/dts/keystone.dtsi
>> index c06542b..ab60fca 100644
>> --- a/arch/arm/boot/dts/keystone.dtsi
>> +++ b/arch/arm/boot/dts/keystone.dtsi
>> @@ -58,6 +58,14 @@
>> <GIC_SPI 23 IRQ_TYPE_EDGE_RISING>;
>> };
>>
>> + psci {
>> + compatible = "arm,psci";
>> + method = "smc";
>> + cpu_suspend = <0x84000001>;
>> + cpu_off = <0x84000002>;
>> + cpu_on = <0x84000003>;
>> + };
>
> It would be nice to have this injected automatically by the bootlaoder
> when PSCI is present, as that way users of existing systems can upgrade
> their DTB and still have things boot.
>
> Thanks,
> Mark.
>
So, KS2 kernel doesn't need that commit and has to wait this from
u-boot? Actually PSCI support is a part of KS2 boot-monitor. U-boot is
just responsible to load and start it, but doesn't know whether PSCI is
supported.
In any case you are right. The DTS also doesn't know whether boot-
monitor supports PSCI. It is better to make u-boot to fix up the dts.
Let's forget about this patch. I'll work on dts fix-up in u-boot.
Thanks,
Vitaly
>> +
>> soc {
>> #address-cells = <1>;
>> #size-cells = <1>;
>> --
>> 1.9.1
>>
WARNING: multiple messages have this Message-ID (diff)
From: Vitaly Andrianov <vitalya-l0cyMroinI0@public.gmane.org>
To: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>
Cc: "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org"
<linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
"ssantosh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org"
<ssantosh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org"
<robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Pawel Moll <Pawel.Moll-5wv7dgnIgG8@public.gmane.org>,
"ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org"
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
"galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org"
<galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] keystone: dts: add psci command definition
Date: Wed, 1 Jul 2015 09:05:31 -0400 [thread overview]
Message-ID: <5593E59B.9090304@ti.com> (raw)
In-Reply-To: <20150701124101.GB2310@leverpostej>
On 07/01/2015 08:41 AM, Mark Rutland wrote:
> On Wed, Jul 01, 2015 at 01:13:04PM +0100, Vitaly Andrianov wrote:
>> This commit adds definition for cpu_on, cpu_off and cpu_suspend commands.
>> These definitions must match the corresponding PSCI definitions in
>> boot monitor.
>>
>> Signed-off-by: Vitaly Andrianov <vitalya-l0cyMroinI0@public.gmane.org>
>> ---
>> arch/arm/boot/dts/keystone.dtsi | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/keystone.dtsi b/arch/arm/boot/dts/keystone.dtsi
>> index c06542b..ab60fca 100644
>> --- a/arch/arm/boot/dts/keystone.dtsi
>> +++ b/arch/arm/boot/dts/keystone.dtsi
>> @@ -58,6 +58,14 @@
>> <GIC_SPI 23 IRQ_TYPE_EDGE_RISING>;
>> };
>>
>> + psci {
>> + compatible = "arm,psci";
>> + method = "smc";
>> + cpu_suspend = <0x84000001>;
>> + cpu_off = <0x84000002>;
>> + cpu_on = <0x84000003>;
>> + };
>
> It would be nice to have this injected automatically by the bootlaoder
> when PSCI is present, as that way users of existing systems can upgrade
> their DTB and still have things boot.
>
> Thanks,
> Mark.
>
So, KS2 kernel doesn't need that commit and has to wait this from
u-boot? Actually PSCI support is a part of KS2 boot-monitor. U-boot is
just responsible to load and start it, but doesn't know whether PSCI is
supported.
In any case you are right. The DTS also doesn't know whether boot-
monitor supports PSCI. It is better to make u-boot to fix up the dts.
Let's forget about this patch. I'll work on dts fix-up in u-boot.
Thanks,
Vitaly
>> +
>> soc {
>> #address-cells = <1>;
>> #size-cells = <1>;
>> --
>> 1.9.1
>>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Vitaly Andrianov <vitalya@ti.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
"ssantosh@kernel.org" <ssantosh@kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
Pawel Moll <Pawel.Moll@arm.com>,
"ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>,
"galak@codeaurora.org" <galak@codeaurora.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH] keystone: dts: add psci command definition
Date: Wed, 1 Jul 2015 09:05:31 -0400 [thread overview]
Message-ID: <5593E59B.9090304@ti.com> (raw)
In-Reply-To: <20150701124101.GB2310@leverpostej>
On 07/01/2015 08:41 AM, Mark Rutland wrote:
> On Wed, Jul 01, 2015 at 01:13:04PM +0100, Vitaly Andrianov wrote:
>> This commit adds definition for cpu_on, cpu_off and cpu_suspend commands.
>> These definitions must match the corresponding PSCI definitions in
>> boot monitor.
>>
>> Signed-off-by: Vitaly Andrianov <vitalya@ti.com>
>> ---
>> arch/arm/boot/dts/keystone.dtsi | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/keystone.dtsi b/arch/arm/boot/dts/keystone.dtsi
>> index c06542b..ab60fca 100644
>> --- a/arch/arm/boot/dts/keystone.dtsi
>> +++ b/arch/arm/boot/dts/keystone.dtsi
>> @@ -58,6 +58,14 @@
>> <GIC_SPI 23 IRQ_TYPE_EDGE_RISING>;
>> };
>>
>> + psci {
>> + compatible = "arm,psci";
>> + method = "smc";
>> + cpu_suspend = <0x84000001>;
>> + cpu_off = <0x84000002>;
>> + cpu_on = <0x84000003>;
>> + };
>
> It would be nice to have this injected automatically by the bootlaoder
> when PSCI is present, as that way users of existing systems can upgrade
> their DTB and still have things boot.
>
> Thanks,
> Mark.
>
So, KS2 kernel doesn't need that commit and has to wait this from
u-boot? Actually PSCI support is a part of KS2 boot-monitor. U-boot is
just responsible to load and start it, but doesn't know whether PSCI is
supported.
In any case you are right. The DTS also doesn't know whether boot-
monitor supports PSCI. It is better to make u-boot to fix up the dts.
Let's forget about this patch. I'll work on dts fix-up in u-boot.
Thanks,
Vitaly
>> +
>> soc {
>> #address-cells = <1>;
>> #size-cells = <1>;
>> --
>> 1.9.1
>>
next prev parent reply other threads:[~2015-07-01 13:05 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-01 12:13 [PATCH] ARM: psci: keystone: remove keystone_smp_ops code if psci is supported Vitaly Andrianov
2015-07-01 12:13 ` Vitaly Andrianov
2015-07-01 12:13 ` Vitaly Andrianov
2015-07-01 12:13 ` [PATCH] keystone: dts: add psci command definition Vitaly Andrianov
2015-07-01 12:13 ` Vitaly Andrianov
2015-07-01 12:13 ` Vitaly Andrianov
2015-07-01 12:41 ` Mark Rutland
2015-07-01 12:41 ` Mark Rutland
2015-07-01 12:41 ` Mark Rutland
2015-07-01 13:05 ` Vitaly Andrianov [this message]
2015-07-01 13:05 ` Vitaly Andrianov
2015-07-01 13:05 ` Vitaly Andrianov
2015-07-01 15:03 ` santosh shilimkar
2015-07-01 15:03 ` santosh shilimkar
2015-07-01 15:03 ` santosh shilimkar
2015-07-01 12:39 ` [PATCH] ARM: psci: keystone: remove keystone_smp_ops code if psci is supported Mark Rutland
2015-07-01 12:39 ` Mark Rutland
2015-07-01 12:39 ` Mark Rutland
2015-07-01 14:12 ` Russell King - ARM Linux
2015-07-01 14:12 ` Russell King - ARM Linux
2015-07-01 14:12 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5593E59B.9090304@ti.com \
--to=vitalya@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.