From: Marc Zyngier <marc.zyngier@arm.com>
To: Christoffer Dall <christoffer.dall@linaro.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Cc: Steve Capper <steve.capper@linaro.org>,
"agraf@suse.de" <agraf@suse.de>,
Catalin Marinas <Catalin.Marinas@arm.com>,
"kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>,
"dirk@dmllr.de" <dirk@dmllr.de>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH] arm64: Don't report clear pmds and puds as huge
Date: Wed, 01 Jul 2015 14:07:12 +0100 [thread overview]
Message-ID: <5593E600.2090107@arm.com> (raw)
In-Reply-To: <1435752511-7079-1-git-send-email-christoffer.dall@linaro.org>
On 01/07/15 13:08, Christoffer Dall wrote:
> The current pmd_huge() and pud_huge() functions simply check if the table
> bit is not set and reports the entries as huge in that case. This is
> counter-intuitive as a clear pmd/pud cannot also be a huge pmd/pud, and
> it is inconsistent with at least arm and x86.
>
> To prevent others from making the same mistake as me in looking at code
> that calls these functions and to fix an issue with KVM on arm64 that
> causes memory corruption due to incorrect page reference counting
> resulting from this mistake, let's change the behavior.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Christoffer Dall <christoffer.dall@linaro.org>
FWIW:
Acked-by: Marc Zyngier <marc.zyngier@arm.com>
M.
--
Jazz is not dead. It just smells funny...
WARNING: multiple messages have this Message-ID (diff)
From: marc.zyngier@arm.com (Marc Zyngier)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: Don't report clear pmds and puds as huge
Date: Wed, 01 Jul 2015 14:07:12 +0100 [thread overview]
Message-ID: <5593E600.2090107@arm.com> (raw)
In-Reply-To: <1435752511-7079-1-git-send-email-christoffer.dall@linaro.org>
On 01/07/15 13:08, Christoffer Dall wrote:
> The current pmd_huge() and pud_huge() functions simply check if the table
> bit is not set and reports the entries as huge in that case. This is
> counter-intuitive as a clear pmd/pud cannot also be a huge pmd/pud, and
> it is inconsistent with at least arm and x86.
>
> To prevent others from making the same mistake as me in looking at code
> that calls these functions and to fix an issue with KVM on arm64 that
> causes memory corruption due to incorrect page reference counting
> resulting from this mistake, let's change the behavior.
>
> Cc: stable at vger.kernel.org
> Signed-off-by: Christoffer Dall <christoffer.dall@linaro.org>
FWIW:
Acked-by: Marc Zyngier <marc.zyngier@arm.com>
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2015-07-01 13:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-01 12:08 [PATCH] arm64: Don't report clear pmds and puds as huge Christoffer Dall
2015-07-01 12:08 ` Christoffer Dall
2015-07-01 12:24 ` Steve Capper
2015-07-01 12:24 ` Steve Capper
2015-07-01 12:59 ` Christoffer Dall
2015-07-01 12:59 ` Christoffer Dall
2015-07-01 13:07 ` Marc Zyngier [this message]
2015-07-01 13:07 ` Marc Zyngier
2015-07-01 13:18 ` Catalin Marinas
2015-07-01 13:18 ` Catalin Marinas
2015-07-01 13:28 ` Catalin Marinas
2015-07-01 13:28 ` Catalin Marinas
2015-07-01 13:56 ` Steve Capper
2015-07-01 13:56 ` Steve Capper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5593E600.2090107@arm.com \
--to=marc.zyngier@arm.com \
--cc=Catalin.Marinas@arm.com \
--cc=agraf@suse.de \
--cc=christoffer.dall@linaro.org \
--cc=dirk@dmllr.de \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=stable@vger.kernel.org \
--cc=steve.capper@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.