From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Ben Catterall <Ben.Catterall@citrix.com>, xen-devel@lists.xenproject.org
Cc: keir@xen.org, ian.campbell@citrix.com,
George Dunlap <george.dunlap@eu.citrix.com>,
tim@xen.org, ian.jackson@eu.citrix.com,
stefano.stabellini@citrix.com, jbeulich@suse.com
Subject: Re: [PATCH 1/3] xen/domain_page: Convert map_domain_page_global() to using mfn_t
Date: Wed, 1 Jul 2015 14:53:54 +0100 [thread overview]
Message-ID: <5593F0F2.8020802@citrix.com> (raw)
In-Reply-To: <1435758095-20821-2-git-send-email-Ben.Catterall@citrix.com>
On 01/07/15 14:41, Ben Catterall wrote:
> From: Andrew Cooper <andrew.cooper3@citrix.com>
>
> The sh_map/unmap wrappers can be dropped, and take the opportunity to turn
> some #define's into static inlines, for added type saftey.
>
> As part of adding the type safety, GCC highlights an problematic include cycle
> with arm/mm.h including domain_page.h which includes xen/mm.h and falls over
> __page_to_mfn being used before being declared. Simply dropping the inclusion
> of domain_page.h fixes the compilation issue.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> CC: Jan Beulich <JBeulich@suse.com>
> CC: Tim Deegan <tim@xen.org>
> CC: Ian Campbell <ian.campbell@citrix.com>
> CC: Stefano Stabellini <stefano.stabellini@citrix.com>
One thing to note is that the mm maintainer has changed since I wrote
this patch. CC'ing George with his new hat on. (The same applies to
all patches in this series)
~Andrew
next prev parent reply other threads:[~2015-07-01 13:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-01 13:41 [PATCH 0/3] Ben Catterall
2015-07-01 13:41 ` [PATCH 1/3] xen/domain_page: Convert map_domain_page_global() to using mfn_t Ben Catterall
2015-07-01 13:53 ` Andrew Cooper [this message]
2015-07-01 13:41 ` [PATCH 2/3] xen/domain_page: Convert copy/clear_domain_page() " Ben Catterall
2015-07-01 13:57 ` Andrew Cooper
2015-07-01 16:07 ` David Vrabel
2015-07-01 16:09 ` Andrew Cooper
2015-07-01 13:41 ` [PATCH 3/3] Convert map_domain_page() to use the new mfn_t type Ben Catterall
2015-07-01 16:22 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5593F0F2.8020802@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=Ben.Catterall@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=keir@xen.org \
--cc=stefano.stabellini@citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.