* [PATCH] libxl: Do not try to destroy domain -1 on failed create
@ 2015-07-01 14:22 Ian Jackson
2015-07-01 14:31 ` Ian Campbell
2015-07-01 14:41 ` Julien Grall
0 siblings, 2 replies; 3+ messages in thread
From: Ian Jackson @ 2015-07-01 14:22 UTC (permalink / raw)
To: xen-devel; +Cc: Julien Grall, Ian Jackson
Perhaps since f0c4c53f "libxl: domain create: Do not destroy on ao
abort", we have destroyed guest_domid==-1 if domain creation fails
without actually creating a domid.
Reported-by: Julien Grall <julien.grall@citrix.com>
CC: Julien Grall <julien.grall@citrix.com>
Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
---
tools/libxl/libxl_create.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/libxl/libxl_create.c b/tools/libxl/libxl_create.c
index f366a09..f799081 100644
--- a/tools/libxl/libxl_create.c
+++ b/tools/libxl/libxl_create.c
@@ -1543,7 +1543,7 @@ static void domcreate_complete(libxl__egc *egc,
libxl_domain_config_dispose(d_config_saved);
if (!retain_domain) {
- if (dcs->guest_domid) {
+ if (dcs->guest_domid > 0) {
dcs->dds.ao = ao;
dcs->dds.domid = dcs->guest_domid;
dcs->dds.callback = domcreate_destruction_cb;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] libxl: Do not try to destroy domain -1 on failed create
2015-07-01 14:22 [PATCH] libxl: Do not try to destroy domain -1 on failed create Ian Jackson
@ 2015-07-01 14:31 ` Ian Campbell
2015-07-01 14:41 ` Julien Grall
1 sibling, 0 replies; 3+ messages in thread
From: Ian Campbell @ 2015-07-01 14:31 UTC (permalink / raw)
To: Ian Jackson; +Cc: Julien Grall, xen-devel
On Wed, 2015-07-01 at 15:22 +0100, Ian Jackson wrote:
> Perhaps since f0c4c53f "libxl: domain create: Do not destroy on ao
> abort", we have destroyed guest_domid==-1 if domain creation fails
> without actually creating a domid.
>
> Reported-by: Julien Grall <julien.grall@citrix.com>
> CC: Julien Grall <julien.grall@citrix.com>
> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] libxl: Do not try to destroy domain -1 on failed create
2015-07-01 14:22 [PATCH] libxl: Do not try to destroy domain -1 on failed create Ian Jackson
2015-07-01 14:31 ` Ian Campbell
@ 2015-07-01 14:41 ` Julien Grall
1 sibling, 0 replies; 3+ messages in thread
From: Julien Grall @ 2015-07-01 14:41 UTC (permalink / raw)
To: Ian Jackson, xen-devel
Hi Ian,
On 01/07/15 15:22, Ian Jackson wrote:
> Perhaps since f0c4c53f "libxl: domain create: Do not destroy on ao
> abort", we have destroyed guest_domid==-1 if domain creation fails
> without actually creating a domid.
>
> Reported-by: Julien Grall <julien.grall@citrix.com>
> CC: Julien Grall <julien.grall@citrix.com>
> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
Thank you, it removes the 3 following lines from xl output:
libxl: error: libxl.c:1586:libxl__destroy_domid: non-existant domain -1
libxl: error: libxl.c:1544:domain_destroy_callback: unable to destroy
guest with domid 4294967295
libxl: error: libxl_create.c:1567:domcreate_destruction_cb: unable to
destroy domain 4294967295 following failed creation
Tested-by: Julien Grall <julien.grall@citrix.com>
Regards,
--
Julien Grall
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-07-01 14:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-01 14:22 [PATCH] libxl: Do not try to destroy domain -1 on failed create Ian Jackson
2015-07-01 14:31 ` Ian Campbell
2015-07-01 14:41 ` Julien Grall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.