All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Stuebner <heiko@sntech.de>
To: xianting.tian@linux.alibaba.com, palmer@dabbelt.com,
	palmer@rivosinc.com, liaochang1@huawei.com, jszhang@kernel.org,
	arnd@arndb.de, guoren@kernel.org
Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-riscv@lists.infradead.org, x86@kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Guo Ren <guoren@linux.alibaba.com>, Guo Ren <guoren@kernel.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH V4 3/3] arch: crash: Remove duplicate declaration in smp.h
Date: Fri, 23 Sep 2022 13:00:32 +0200	[thread overview]
Message-ID: <5594014.Sb9uPGUboI@phil> (raw)
In-Reply-To: <20220921033134.3133319-4-guoren@kernel.org>

Am Mittwoch, 21. September 2022, 05:31:34 CEST schrieb guoren@kernel.org:
> From: Guo Ren <guoren@linux.alibaba.com>
> 
> Remove crash_smp_send_stop declarations in arm64, x86 asm/smp.h which
> has been done in include/linux/smp.h.

nit: the commit message could reference the commit that brought in the
generic declarations, which was
	6f1f942cd5fb ("smp: kernel/panic.c - silence warnings")

other than that
Reviewed-by: Heiko Stuebner <heiko@sntech.de>


> Signed-off-by: Guo Ren <guoren@linux.alibaba.com>
> Signed-off-by: Guo Ren <guoren@kernel.org>
> Acked-by: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> ---
>  arch/arm64/include/asm/smp.h | 1 -
>  arch/x86/include/asm/crash.h | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/arch/arm64/include/asm/smp.h b/arch/arm64/include/asm/smp.h
> index fc55f5a57a06..a108ac93fd8f 100644
> --- a/arch/arm64/include/asm/smp.h
> +++ b/arch/arm64/include/asm/smp.h
> @@ -141,7 +141,6 @@ static inline void cpu_panic_kernel(void)
>   */
>  bool cpus_are_stuck_in_kernel(void);
>  
> -extern void crash_smp_send_stop(void);
>  extern bool smp_crash_stop_failed(void);
>  extern void panic_smp_self_stop(void);
>  
> diff --git a/arch/x86/include/asm/crash.h b/arch/x86/include/asm/crash.h
> index 8b6bd63530dc..6a9be4907c82 100644
> --- a/arch/x86/include/asm/crash.h
> +++ b/arch/x86/include/asm/crash.h
> @@ -7,6 +7,5 @@ struct kimage;
>  int crash_load_segments(struct kimage *image);
>  int crash_setup_memmap_entries(struct kimage *image,
>  		struct boot_params *params);
> -void crash_smp_send_stop(void);
>  
>  #endif /* _ASM_X86_CRASH_H */
> 





WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: xianting.tian@linux.alibaba.com, palmer@dabbelt.com,
	palmer@rivosinc.com, liaochang1@huawei.com, jszhang@kernel.org,
	arnd@arndb.de, guoren@kernel.org
Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-riscv@lists.infradead.org, x86@kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Guo Ren <guoren@linux.alibaba.com>, Guo Ren <guoren@kernel.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH V4 3/3] arch: crash: Remove duplicate declaration in smp.h
Date: Fri, 23 Sep 2022 13:00:32 +0200	[thread overview]
Message-ID: <5594014.Sb9uPGUboI@phil> (raw)
In-Reply-To: <20220921033134.3133319-4-guoren@kernel.org>

Am Mittwoch, 21. September 2022, 05:31:34 CEST schrieb guoren@kernel.org:
> From: Guo Ren <guoren@linux.alibaba.com>
> 
> Remove crash_smp_send_stop declarations in arm64, x86 asm/smp.h which
> has been done in include/linux/smp.h.

nit: the commit message could reference the commit that brought in the
generic declarations, which was
	6f1f942cd5fb ("smp: kernel/panic.c - silence warnings")

other than that
Reviewed-by: Heiko Stuebner <heiko@sntech.de>


> Signed-off-by: Guo Ren <guoren@linux.alibaba.com>
> Signed-off-by: Guo Ren <guoren@kernel.org>
> Acked-by: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> ---
>  arch/arm64/include/asm/smp.h | 1 -
>  arch/x86/include/asm/crash.h | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/arch/arm64/include/asm/smp.h b/arch/arm64/include/asm/smp.h
> index fc55f5a57a06..a108ac93fd8f 100644
> --- a/arch/arm64/include/asm/smp.h
> +++ b/arch/arm64/include/asm/smp.h
> @@ -141,7 +141,6 @@ static inline void cpu_panic_kernel(void)
>   */
>  bool cpus_are_stuck_in_kernel(void);
>  
> -extern void crash_smp_send_stop(void);
>  extern bool smp_crash_stop_failed(void);
>  extern void panic_smp_self_stop(void);
>  
> diff --git a/arch/x86/include/asm/crash.h b/arch/x86/include/asm/crash.h
> index 8b6bd63530dc..6a9be4907c82 100644
> --- a/arch/x86/include/asm/crash.h
> +++ b/arch/x86/include/asm/crash.h
> @@ -7,6 +7,5 @@ struct kimage;
>  int crash_load_segments(struct kimage *image);
>  int crash_setup_memmap_entries(struct kimage *image,
>  		struct boot_params *params);
> -void crash_smp_send_stop(void);
>  
>  #endif /* _ASM_X86_CRASH_H */
> 





_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: xianting.tian@linux.alibaba.com, palmer@dabbelt.com,
	palmer@rivosinc.com, liaochang1@huawei.com, jszhang@kernel.org,
	arnd@arndb.de, guoren@kernel.org
Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-riscv@lists.infradead.org, x86@kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Guo Ren <guoren@linux.alibaba.com>, Guo Ren <guoren@kernel.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH V4 3/3] arch: crash: Remove duplicate declaration in smp.h
Date: Fri, 23 Sep 2022 13:00:32 +0200	[thread overview]
Message-ID: <5594014.Sb9uPGUboI@phil> (raw)
In-Reply-To: <20220921033134.3133319-4-guoren@kernel.org>

Am Mittwoch, 21. September 2022, 05:31:34 CEST schrieb guoren@kernel.org:
> From: Guo Ren <guoren@linux.alibaba.com>
> 
> Remove crash_smp_send_stop declarations in arm64, x86 asm/smp.h which
> has been done in include/linux/smp.h.

nit: the commit message could reference the commit that brought in the
generic declarations, which was
	6f1f942cd5fb ("smp: kernel/panic.c - silence warnings")

other than that
Reviewed-by: Heiko Stuebner <heiko@sntech.de>


> Signed-off-by: Guo Ren <guoren@linux.alibaba.com>
> Signed-off-by: Guo Ren <guoren@kernel.org>
> Acked-by: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> ---
>  arch/arm64/include/asm/smp.h | 1 -
>  arch/x86/include/asm/crash.h | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/arch/arm64/include/asm/smp.h b/arch/arm64/include/asm/smp.h
> index fc55f5a57a06..a108ac93fd8f 100644
> --- a/arch/arm64/include/asm/smp.h
> +++ b/arch/arm64/include/asm/smp.h
> @@ -141,7 +141,6 @@ static inline void cpu_panic_kernel(void)
>   */
>  bool cpus_are_stuck_in_kernel(void);
>  
> -extern void crash_smp_send_stop(void);
>  extern bool smp_crash_stop_failed(void);
>  extern void panic_smp_self_stop(void);
>  
> diff --git a/arch/x86/include/asm/crash.h b/arch/x86/include/asm/crash.h
> index 8b6bd63530dc..6a9be4907c82 100644
> --- a/arch/x86/include/asm/crash.h
> +++ b/arch/x86/include/asm/crash.h
> @@ -7,6 +7,5 @@ struct kimage;
>  int crash_load_segments(struct kimage *image);
>  int crash_setup_memmap_entries(struct kimage *image,
>  		struct boot_params *params);
> -void crash_smp_send_stop(void);
>  
>  #endif /* _ASM_X86_CRASH_H */
> 





_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-09-23 11:00 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-21  3:31 [PATCH V4 0/3] riscv: kexec: Fxiup crash_save percpu and machine_kexec_mask_interrupts guoren
2022-09-21  3:31 ` guoren
2022-09-21  3:31 ` guoren
2022-09-21  3:31 ` [PATCH V4 1/3] riscv: kexec: Fixup irq controller broken in kexec crash path guoren
2022-09-21  3:31   ` guoren
2022-09-21  3:31   ` guoren
2022-09-21  3:31 ` [PATCH V4 2/3] riscv: kexec: Fixup crash_smp_send_stop without multi cores guoren
2022-09-21  3:31   ` guoren
2022-09-21  3:31   ` guoren
2022-09-21  3:31 ` [PATCH V4 3/3] arch: crash: Remove duplicate declaration in smp.h guoren
2022-09-21  3:31   ` guoren
2022-09-21  3:31   ` guoren
2022-09-23 11:00   ` Heiko Stuebner [this message]
2022-09-23 11:00     ` Heiko Stuebner
2022-09-23 11:00     ` Heiko Stuebner
2022-09-24 10:56     ` Guo Ren
2022-09-24 10:56       ` Guo Ren
2022-09-24 10:56       ` Guo Ren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5594014.Sb9uPGUboI@phil \
    --to=heiko@sntech.de \
    --cc=arnd@arndb.de \
    --cc=catalin.marinas@arm.com \
    --cc=guoren@kernel.org \
    --cc=guoren@linux.alibaba.com \
    --cc=jszhang@kernel.org \
    --cc=liaochang1@huawei.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=palmer@rivosinc.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --cc=xianting.tian@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.