All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Denis V. Lunev" <den@openvz.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: <qemu-devel@nongnu.org>, <kvm@vger.kernel.org>,
	Andrey Smetanin <asmetanin@virtuozzo.com>,
	Gleb Natapov <gleb@kernel.org>,
	Peter Hornyack <peterhornyack@google.com>
Subject: Re: [PATCH 3/9] kvm: add hyper-v crash msrs values
Date: Wed, 1 Jul 2015 18:53:57 +0300	[thread overview]
Message-ID: <55940D15.9050108@openvz.org> (raw)
In-Reply-To: <55940074.1010606@redhat.com>

On 01/07/15 18:00, Paolo Bonzini wrote:
>
> On 30/06/2015 13:33, Denis V. Lunev wrote:
>> +#define HV_X64_MSR_CRASH_CTL_NOTIFY		(1ULL << 63)
>> +#define HV_X64_MSR_CRASH_CTL_CONTENTS	\
>> +		(HV_X64_MSR_CRASH_CTL_NOTIFY)
> Why is HV_X64_MSR_CRASH_CTL_CONTENTS needed?  Can I just remove it?
>
> Paolo
this was a direct request from Peter Hornyack <peterhornyack@google.com>

"I suggest here:

#define HV_X64_MSR_CRASH_CTL_CONTENTS  \
         (HV_CRASH_CTL_CRASH_NOTIFY)

To allow for more crash actions to be added in the future."

Den

WARNING: multiple messages have this Message-ID (diff)
From: "Denis V. Lunev" <den@openvz.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Andrey Smetanin <asmetanin@virtuozzo.com>,
	Gleb Natapov <gleb@kernel.org>,
	qemu-devel@nongnu.org, kvm@vger.kernel.org,
	Peter Hornyack <peterhornyack@google.com>
Subject: Re: [Qemu-devel] [PATCH 3/9] kvm: add hyper-v crash msrs values
Date: Wed, 1 Jul 2015 18:53:57 +0300	[thread overview]
Message-ID: <55940D15.9050108@openvz.org> (raw)
In-Reply-To: <55940074.1010606@redhat.com>

On 01/07/15 18:00, Paolo Bonzini wrote:
>
> On 30/06/2015 13:33, Denis V. Lunev wrote:
>> +#define HV_X64_MSR_CRASH_CTL_NOTIFY		(1ULL << 63)
>> +#define HV_X64_MSR_CRASH_CTL_CONTENTS	\
>> +		(HV_X64_MSR_CRASH_CTL_NOTIFY)
> Why is HV_X64_MSR_CRASH_CTL_CONTENTS needed?  Can I just remove it?
>
> Paolo
this was a direct request from Peter Hornyack <peterhornyack@google.com>

"I suggest here:

#define HV_X64_MSR_CRASH_CTL_CONTENTS  \
         (HV_CRASH_CTL_CRASH_NOTIFY)

To allow for more crash actions to be added in the future."

Den

  reply	other threads:[~2015-07-01 15:54 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-30 11:33 [PATCH v3 0/9] HyperV equivalent of pvpanic driver Denis V. Lunev
2015-06-30 11:33 ` [Qemu-devel] " Denis V. Lunev
2015-06-30 11:33 ` [PATCH 1/9] kvm/x86: move Hyper-V MSR's/hypercall code into hyperv.c file Denis V. Lunev
2015-06-30 11:33   ` [Qemu-devel] " Denis V. Lunev
2015-07-01  0:11   ` Peter Hornyack
2015-07-01  0:11     ` [Qemu-devel] " Peter Hornyack
2015-06-30 11:33 ` [PATCH 2/9] kvm: introduce vcpu_debug = kvm_debug + vcpu context Denis V. Lunev
2015-06-30 11:33   ` [Qemu-devel] " Denis V. Lunev
2015-07-01  0:12   ` Peter Hornyack
2015-07-01  0:12     ` [Qemu-devel] " Peter Hornyack
2015-06-30 11:33 ` [PATCH 3/9] kvm: add hyper-v crash msrs values Denis V. Lunev
2015-06-30 11:33   ` [Qemu-devel] " Denis V. Lunev
2015-07-01  0:14   ` Peter Hornyack
2015-07-01  0:14     ` [Qemu-devel] " Peter Hornyack
2015-07-01 15:00   ` Paolo Bonzini
2015-07-01 15:00     ` [Qemu-devel] " Paolo Bonzini
2015-07-01 15:53     ` Denis V. Lunev [this message]
2015-07-01 15:53       ` Denis V. Lunev
2015-07-01 16:06       ` Peter Hornyack
2015-07-01 16:06         ` [Qemu-devel] " Peter Hornyack
2015-07-01 16:48         ` Paolo Bonzini
2015-07-01 16:48           ` [Qemu-devel] " Paolo Bonzini
2015-06-30 11:33 ` [PATCH 4/9] kvm/x86: added hyper-v crash msrs into kvm hyperv context Denis V. Lunev
2015-06-30 11:33   ` [Qemu-devel] " Denis V. Lunev
2015-07-01  0:14   ` Peter Hornyack
2015-07-01  0:14     ` [Qemu-devel] " Peter Hornyack
2015-06-30 11:33 ` [PATCH 5/9] kvm: added KVM_REQ_HV_CRASH value to notify qemu about hyper-v crash Denis V. Lunev
2015-06-30 11:33   ` [Qemu-devel] " Denis V. Lunev
2015-07-01  0:14   ` Peter Hornyack
2015-07-01  0:14     ` [Qemu-devel] " Peter Hornyack
2015-06-30 11:33 ` [PATCH 6/9] kvm/x86: mark hyper-v crash msrs as partition wide Denis V. Lunev
2015-06-30 11:33   ` [Qemu-devel] " Denis V. Lunev
2015-07-01  0:15   ` Peter Hornyack
2015-07-01  0:15     ` [Qemu-devel] " Peter Hornyack
2015-06-30 11:33 ` [PATCH 7/9] kvm/x86: added hyper-v crash data and ctl msr's get/set'ers Denis V. Lunev
2015-06-30 11:33   ` [Qemu-devel] " Denis V. Lunev
2015-07-01  0:15   ` Peter Hornyack
2015-07-01  0:15     ` [Qemu-devel] " Peter Hornyack
2015-07-01 16:47   ` Paolo Bonzini
2015-07-01 16:47     ` [Qemu-devel] " Paolo Bonzini
2015-06-30 11:33 ` [PATCH 8/9] kvm/x86: add sending hyper-v crash notification to user space Denis V. Lunev
2015-06-30 11:33   ` [Qemu-devel] " Denis V. Lunev
2015-07-01  0:16   ` Peter Hornyack
2015-07-01  0:16     ` [Qemu-devel] " Peter Hornyack
2015-07-01 15:12   ` Paolo Bonzini
2015-07-01 15:12     ` [Qemu-devel] " Paolo Bonzini
2015-06-30 11:33 ` [PATCH 9/9] qemu/kvm: kvm hyper-v based guest crash event handling Denis V. Lunev
2015-06-30 11:33   ` [Qemu-devel] " Denis V. Lunev
2015-07-01 15:07   ` Paolo Bonzini
2015-07-01 15:07     ` [Qemu-devel] " Paolo Bonzini
2015-07-02 13:19     ` Andrey Smetanin
2015-07-02 13:19       ` [Qemu-devel] " Andrey Smetanin
2015-07-02 13:30       ` Paolo Bonzini
2015-07-02 13:30         ` [Qemu-devel] " Paolo Bonzini
2015-06-30 12:26 ` [Qemu-devel] [PATCH v3 0/9] HyperV equivalent of pvpanic driver Daniel P. Berrange
2015-06-30 12:26   ` Daniel P. Berrange
2015-06-30 12:38   ` Denis V. Lunev
2015-06-30 12:38     ` Denis V. Lunev
2015-07-01 14:09 ` Paolo Bonzini
2015-07-01 14:09   ` [Qemu-devel] " Paolo Bonzini
2015-07-01 15:55   ` Denis V. Lunev
2015-07-01 15:55     ` [Qemu-devel] " Denis V. Lunev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55940D15.9050108@openvz.org \
    --to=den@openvz.org \
    --cc=asmetanin@virtuozzo.com \
    --cc=gleb@kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=peterhornyack@google.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.