From: Guenter Roeck <linux@roeck-us.net>
To: Joachim Eastwood <manabian@gmail.com>,
Ariel D'Alessandro <ariel@vanguardiasur.com.ar>
Cc: linux-watchdog@vger.kernel.org, wim@iguana.be,
Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 1/2] watchdog: NXP LPC18xx Watchdog Timer Driver
Date: Wed, 01 Jul 2015 17:14:39 -0700 [thread overview]
Message-ID: <5594826F.6090203@roeck-us.net> (raw)
In-Reply-To: <CAGhQ9VzLX_hy2Z=jUH6on0_sOZBp_mg5cC0JXkHntWxxrr2K6A@mail.gmail.com>
On 07/01/2015 04:04 PM, Joachim Eastwood wrote:
> Hi Ariel,
>
>> +/*
>> + * NXP LPC18xx Watchdog Timer (WDT)
>
> I think you should use "Windowed Watchdog Timer (WWDT)" here since
> that is name from the user manual, even though the driver doesn't have
> window functionality.
> At least use wwdt for the compatible string, ie: "nxp,lpc1850-wwdt".
>
> I don't think Guenter asked you to remove the "Windowed" part last
> time, but only asked what it meant.
I did, separately, but I don't want to start a war of words either.
No one will know what that term means, and I am personally not too hot
having to explain it to others.
If you insist using the term, please add a comment into the code
explaining what it is and that the driver does not support it.
Guenter
WARNING: multiple messages have this Message-ID (diff)
From: linux@roeck-us.net (Guenter Roeck)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/2] watchdog: NXP LPC18xx Watchdog Timer Driver
Date: Wed, 01 Jul 2015 17:14:39 -0700 [thread overview]
Message-ID: <5594826F.6090203@roeck-us.net> (raw)
In-Reply-To: <CAGhQ9VzLX_hy2Z=jUH6on0_sOZBp_mg5cC0JXkHntWxxrr2K6A@mail.gmail.com>
On 07/01/2015 04:04 PM, Joachim Eastwood wrote:
> Hi Ariel,
>
>> +/*
>> + * NXP LPC18xx Watchdog Timer (WDT)
>
> I think you should use "Windowed Watchdog Timer (WWDT)" here since
> that is name from the user manual, even though the driver doesn't have
> window functionality.
> At least use wwdt for the compatible string, ie: "nxp,lpc1850-wwdt".
>
> I don't think Guenter asked you to remove the "Windowed" part last
> time, but only asked what it meant.
I did, separately, but I don't want to start a war of words either.
No one will know what that term means, and I am personally not too hot
having to explain it to others.
If you insist using the term, please add a comment into the code
explaining what it is and that the driver does not support it.
Guenter
next prev parent reply other threads:[~2015-07-02 0:14 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-01 20:52 [PATCH v2 0/2] Add support for NXP LPC18xx Watchdog timer Ariel D'Alessandro
2015-07-01 20:52 ` Ariel D'Alessandro
2015-07-01 20:52 ` [PATCH v2 1/2] watchdog: NXP LPC18xx Watchdog Timer Driver Ariel D'Alessandro
2015-07-01 20:52 ` Ariel D'Alessandro
2015-07-01 23:04 ` Joachim Eastwood
2015-07-01 23:04 ` Joachim Eastwood
2015-07-02 0:14 ` Guenter Roeck [this message]
2015-07-02 0:14 ` Guenter Roeck
2015-07-02 9:03 ` Joachim Eastwood
2015-07-02 9:03 ` Joachim Eastwood
2015-07-05 2:46 ` Ariel D'Alessandro
2015-07-05 2:46 ` Ariel D'Alessandro
2015-07-03 14:56 ` Ezequiel Garcia
2015-07-03 14:56 ` Ezequiel Garcia
2015-07-05 2:06 ` Ariel D'Alessandro
2015-07-05 2:06 ` Ariel D'Alessandro
2015-07-05 2:36 ` Guenter Roeck
2015-07-05 2:36 ` Guenter Roeck
2015-07-01 20:52 ` [PATCH v2 2/2] DT: watchdog: Add NXP LPC18xx Watchdog Timer binding documentation Ariel D'Alessandro
2015-07-01 20:52 ` Ariel D'Alessandro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5594826F.6090203@roeck-us.net \
--to=linux@roeck-us.net \
--cc=ariel@vanguardiasur.com.ar \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=manabian@gmail.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.