All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chanwoo Choi <cw00.choi@samsung.com>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: s.nawrocki@samsung.com, tomasz.figa@gmail.com,
	mturquette@baylibre.com, sboyd@codeaurora.org, kgene@kernel.org,
	thomas.ab@samsung.com, b.zolnierkie@samsung.com,
	kyungmin.park@samsung.com, linux-samsung-soc@vger.kernel.org,
	linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v5 2/3] ARM: dts: Add CPU OPP and regulator supply property for Exynos3250
Date: Thu, 02 Jul 2015 09:29:49 +0900	[thread overview]
Message-ID: <559485FD.7030805@samsung.com> (raw)
In-Reply-To: <55947F65.8010404@samsung.com>

On 07/02/2015 09:01 AM, Krzysztof Kozlowski wrote:
> On 01.07.2015 22:21, Chanwoo Choi wrote:
>> This patch add CPU operating points which include CPU frequency and regulator
>> voltage to use generic cpufreq drivers.
>>
>> Cc: Kukjin Kim <kgene@kernel.org>
>> Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
>> Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
>> ---
>>  arch/arm/boot/dts/exynos3250-monk.dts   |  4 ++++
>>  arch/arm/boot/dts/exynos3250-rinato.dts |  4 ++++
>>  arch/arm/boot/dts/exynos3250.dtsi       | 15 +++++++++++++++
>>  3 files changed, 23 insertions(+)
> 
> The patch looks good. Could you put the 'cpu' nodes in alphabetical
> order? The order for Rinato board is already broken but still putting it
> after 'adc' node would be better.
> 
> With the change above:
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

OK. I'll resend it.

Thanks,
Chanwoo Choi


WARNING: multiple messages have this Message-ID (diff)
From: cw00.choi@samsung.com (Chanwoo Choi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 2/3] ARM: dts: Add CPU OPP and regulator supply property for Exynos3250
Date: Thu, 02 Jul 2015 09:29:49 +0900	[thread overview]
Message-ID: <559485FD.7030805@samsung.com> (raw)
In-Reply-To: <55947F65.8010404@samsung.com>

On 07/02/2015 09:01 AM, Krzysztof Kozlowski wrote:
> On 01.07.2015 22:21, Chanwoo Choi wrote:
>> This patch add CPU operating points which include CPU frequency and regulator
>> voltage to use generic cpufreq drivers.
>>
>> Cc: Kukjin Kim <kgene@kernel.org>
>> Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
>> Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
>> ---
>>  arch/arm/boot/dts/exynos3250-monk.dts   |  4 ++++
>>  arch/arm/boot/dts/exynos3250-rinato.dts |  4 ++++
>>  arch/arm/boot/dts/exynos3250.dtsi       | 15 +++++++++++++++
>>  3 files changed, 23 insertions(+)
> 
> The patch looks good. Could you put the 'cpu' nodes in alphabetical
> order? The order for Rinato board is already broken but still putting it
> after 'adc' node would be better.
> 
> With the change above:
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

OK. I'll resend it.

Thanks,
Chanwoo Choi

  reply	other threads:[~2015-07-02  0:29 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-01 13:21 [PATCH v5 0/3] cpufreq: Use cpufreq-dt driver for Exynos3250 Chanwoo Choi
2015-07-01 13:21 ` Chanwoo Choi
2015-07-01 13:21 ` Chanwoo Choi
2015-07-01 13:21 ` [PATCH v5 1/3] clk: samsung: exynos3250: Add cpu clock configuration data and instaniate cpu clock Chanwoo Choi
2015-07-01 13:21   ` Chanwoo Choi
2015-07-02  0:05   ` Krzysztof Kozlowski
2015-07-02  0:05     ` Krzysztof Kozlowski
2015-07-02  0:40   ` Stephen Boyd
2015-07-02  0:40     ` Stephen Boyd
2015-07-01 13:21 ` [PATCH v5 2/3] ARM: dts: Add CPU OPP and regulator supply property for Exynos3250 Chanwoo Choi
2015-07-01 13:21   ` Chanwoo Choi
2015-07-02  0:01   ` Krzysztof Kozlowski
2015-07-02  0:01     ` Krzysztof Kozlowski
2015-07-02  0:29     ` Chanwoo Choi [this message]
2015-07-02  0:29       ` Chanwoo Choi
2015-07-01 13:21 ` [PATCH v5 3/3] ARM: exynos: Add exynos3250 compatible to use generic cpufreq driver Chanwoo Choi
2015-07-01 13:21   ` Chanwoo Choi
2015-07-01 23:58   ` Krzysztof Kozlowski
2015-07-01 23:58     ` Krzysztof Kozlowski
2015-07-01 23:58     ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=559485FD.7030805@samsung.com \
    --to=cw00.choi@samsung.com \
    --cc=b.zolnierkie@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=k.kozlowski@samsung.com \
    --cc=kgene@kernel.org \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=s.nawrocki@samsung.com \
    --cc=sboyd@codeaurora.org \
    --cc=thomas.ab@samsung.com \
    --cc=tomasz.figa@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.