All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Eric Auger <eric.auger@linaro.org>,
	eric.auger@st.com, linux-arm-kernel@lists.infradead.org,
	kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org,
	christoffer.dall@linaro.org, marc.zyngier@arm.com,
	alex.williamson@redhat.com, avi.kivity@gmail.com,
	mtosatti@redhat.com, feng.wu@intel.com, joro@8bytes.org,
	b.reynal@virtualopensystems.com
Cc: linux-kernel@vger.kernel.org, patches@linaro.org
Subject: Re: [RFC 12/17] irq: bypass: Extend skeleton for ARM forwarding control
Date: Thu, 2 Jul 2015 15:40:47 +0200	[thread overview]
Message-ID: <55953F5F.9090203@redhat.com> (raw)
In-Reply-To: <1435843047-6327-13-git-send-email-eric.auger@linaro.org>



On 02/07/2015 15:17, Eric Auger wrote:
> - new fields are added on producer side: linux irq, vfio_device handle,
>   active which reflects whether the source is active (at interrupt
>   controller level or at VFIO level - automasked -) and finally an
>   opaque pointer which will be used to point to the vfio_platform_device
>   in this series.

Linux IRQ and active should be okay.  As to the vfio_device handle, you
should link it from the vfio_platform_device instead.  And for the
vfio_platform_device, you can link it from the vfio_platform_irq instead.

Once you've done this, embed the irq_bypass_producer struct in the
vfio_platform_irq struct; in the new kvm_arch_* functions, go back to
the vfio_platform_irq struct via container_of.  From there you can
retrieve pointers to the vfio_platform_device and the vfio_device.

> - new fields on consumer side: the kvm handle, the gsi

You do not need to add these.  Instead, add the kvm handle to irqfd
only.  Like above, embed the irq_bypass_consumer struct in the irqfd
struct; in the new kvm_arch_* functions, go back to the
vfio_platform_irq struct via container_of.

Paolo

WARNING: multiple messages have this Message-ID (diff)
From: pbonzini@redhat.com (Paolo Bonzini)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC 12/17] irq: bypass: Extend skeleton for ARM forwarding control
Date: Thu, 2 Jul 2015 15:40:47 +0200	[thread overview]
Message-ID: <55953F5F.9090203@redhat.com> (raw)
In-Reply-To: <1435843047-6327-13-git-send-email-eric.auger@linaro.org>



On 02/07/2015 15:17, Eric Auger wrote:
> - new fields are added on producer side: linux irq, vfio_device handle,
>   active which reflects whether the source is active (at interrupt
>   controller level or at VFIO level - automasked -) and finally an
>   opaque pointer which will be used to point to the vfio_platform_device
>   in this series.

Linux IRQ and active should be okay.  As to the vfio_device handle, you
should link it from the vfio_platform_device instead.  And for the
vfio_platform_device, you can link it from the vfio_platform_irq instead.

Once you've done this, embed the irq_bypass_producer struct in the
vfio_platform_irq struct; in the new kvm_arch_* functions, go back to
the vfio_platform_irq struct via container_of.  From there you can
retrieve pointers to the vfio_platform_device and the vfio_device.

> - new fields on consumer side: the kvm handle, the gsi

You do not need to add these.  Instead, add the kvm handle to irqfd
only.  Like above, embed the irq_bypass_consumer struct in the irqfd
struct; in the new kvm_arch_* functions, go back to the
vfio_platform_irq struct via container_of.

Paolo

  reply	other threads:[~2015-07-02 13:29 UTC|newest]

Thread overview: 89+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-02 13:17 [RFC 00/17] ARM IRQ forward control based on IRQ bypass manager Eric Auger
2015-07-02 13:17 ` Eric Auger
2015-07-02 13:17 ` [RFC 01/17] VFIO: platform: test forwarded state when selecting IRQ handler Eric Auger
2015-07-02 13:17   ` Eric Auger
2015-07-02 13:17 ` [RFC 02/17] VFIO: platform: single handler using function pointer Eric Auger
2015-07-02 13:17   ` Eric Auger
2015-07-02 13:17 ` [RFC 03/17] VFIO: Introduce vfio_device_external_ops Eric Auger
2015-07-02 13:17   ` Eric Auger
2015-07-02 13:17 ` [RFC 04/17] VFIO: pci: initialize vfio_device_external_ops Eric Auger
2015-07-02 13:17   ` Eric Auger
2015-07-02 13:17 ` [RFC 05/17] VFIO: platform: implement vfio_device_external_ops callbacks Eric Auger
2015-07-02 13:17   ` Eric Auger
2015-07-02 13:17 ` [RFC 06/17] VFIO: add vfio_external_{mask|is_active|set_automasked} Eric Auger
2015-07-02 13:17   ` Eric Auger
2015-07-02 13:17 ` [RFC 07/17] KVM: arm: rename pause into power_off Eric Auger
2015-07-02 13:17   ` Eric Auger
2015-07-02 13:17 ` [RFC 08/17] kvm: arm/arm64: implement kvm_arm_[halt,resume]_guest Eric Auger
2015-07-02 13:17   ` Eric Auger
2015-07-03 11:55   ` [RFC 08/17] kvm: arm/arm64: implement kvm_arm_[halt, resume]_guest Eric Auger
2015-07-03 11:55     ` [RFC 08/17] kvm: arm/arm64: implement kvm_arm_[halt,resume]_guest Eric Auger
2015-07-03 11:55     ` [RFC 08/17] kvm: arm/arm64: implement kvm_arm_[halt, resume]_guest Eric Auger
2015-07-03 12:14     ` [RFC 08/17] kvm: arm/arm64: implement kvm_arm_[halt,resume]_guest Marc Zyngier
2015-07-03 12:14       ` [RFC 08/17] kvm: arm/arm64: implement kvm_arm_[halt, resume]_guest Marc Zyngier
2015-07-02 13:17 ` [RFC 09/17] bypass: IRQ bypass manager proto by Alex Eric Auger
2015-07-02 13:17   ` Eric Auger
2015-07-03  2:16   ` Wu, Feng
2015-07-03  2:16     ` Wu, Feng
2015-07-03  2:16     ` Wu, Feng
2015-07-03  5:32     ` Eric Auger
2015-07-03  5:32       ` Eric Auger
2015-07-02 13:17 ` [RFC 10/17] KVM: arm: select IRQ_BYPASS_MANAGER Eric Auger
2015-07-02 13:17   ` Eric Auger
2015-07-02 13:17 ` [RFC 11/17] VFIO: platform: " Eric Auger
2015-07-02 13:17   ` Eric Auger
2015-07-02 13:17 ` [RFC 12/17] irq: bypass: Extend skeleton for ARM forwarding control Eric Auger
2015-07-02 13:17   ` Eric Auger
2015-07-02 13:40   ` Paolo Bonzini [this message]
2015-07-02 13:40     ` Paolo Bonzini
2015-07-03  2:19     ` Wu, Feng
2015-07-03  2:19       ` Wu, Feng
2015-07-03  2:19       ` Wu, Feng
2015-07-03  2:24       ` Wu, Feng
2015-07-03  2:24         ` Wu, Feng
2015-07-03  6:54         ` Eric Auger
2015-07-03  6:54           ` Eric Auger
2015-07-03  7:02           ` Paolo Bonzini
2015-07-03  7:02             ` Paolo Bonzini
2015-07-03 13:12     ` Eric Auger
2015-07-03 13:12       ` Eric Auger
2015-07-03 17:20       ` Paolo Bonzini
2015-07-03 17:20         ` Paolo Bonzini
2015-07-03 17:23         ` Eric Auger
2015-07-03 17:23           ` Eric Auger
2015-07-03  2:43   ` Wu, Feng
2015-07-03  2:43     ` Wu, Feng
2015-07-03  2:43     ` Wu, Feng
2015-07-03  6:52     ` Paolo Bonzini
2015-07-03  6:52       ` Paolo Bonzini
2015-07-03  7:00       ` Wu, Feng
2015-07-03  7:00         ` Wu, Feng
2015-07-03  7:00         ` Wu, Feng
2015-07-03  7:06         ` Paolo Bonzini
2015-07-03  7:06           ` Paolo Bonzini
2015-07-03  7:16           ` Wu, Feng
2015-07-03  7:16             ` Wu, Feng
2015-07-03  7:08   ` Paolo Bonzini
2015-07-03  7:08     ` Paolo Bonzini
2015-07-02 13:17 ` [RFC 13/17] KVM: introduce kvm_arch functions for IRQ bypass Eric Auger
2015-07-02 13:17   ` Eric Auger
2015-07-02 13:41   ` Paolo Bonzini
2015-07-02 13:41     ` Paolo Bonzini
2015-07-02 13:17 ` [RFC 14/17] KVM: arm/arm64: vgic: forwarding control Eric Auger
2015-07-02 13:17   ` Eric Auger
2015-07-02 13:17 ` [RFC 15/17] KVM: arm/arm64: implement IRQ bypass consumer functions Eric Auger
2015-07-02 13:17   ` Eric Auger
2015-07-02 13:17 ` [RFC 16/17] KVM: eventfd: add irq bypass consumer management Eric Auger
2015-07-02 13:17   ` Eric Auger
2015-07-02 13:42   ` Paolo Bonzini
2015-07-02 13:42     ` Paolo Bonzini
2015-07-02 13:53     ` Eric Auger
2015-07-02 13:53       ` Eric Auger
2015-07-06  7:55   ` Wu, Feng
2015-07-06  7:55     ` Wu, Feng
2015-07-06 11:19     ` Eric Auger
2015-07-06 11:19       ` Eric Auger
2015-07-06 12:17       ` Wu, Feng
2015-07-06 12:17         ` Wu, Feng
2015-07-02 13:17 ` [RFC 17/17] VFIO: platform: add irq bypass producer management Eric Auger
2015-07-02 13:17   ` Eric Auger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55953F5F.9090203@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=alex.williamson@redhat.com \
    --cc=avi.kivity@gmail.com \
    --cc=b.reynal@virtualopensystems.com \
    --cc=christoffer.dall@linaro.org \
    --cc=eric.auger@linaro.org \
    --cc=eric.auger@st.com \
    --cc=feng.wu@intel.com \
    --cc=joro@8bytes.org \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marc.zyngier@arm.com \
    --cc=mtosatti@redhat.com \
    --cc=patches@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.