From: Toshiaki Makita <toshiaki.makita1@gmail.com>
To: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Cc: netdev@vger.kernel.org, vyasevich@gmail.com,
bridge@lists.linux-foundation.org, davem@davemloft.net,
roopa@cumulusnetworks.com
Subject: Re: [Bridge] [PATCH net] bridge: vlan: fix usage of vlan 0 and 4095 again
Date: Fri, 03 Jul 2015 00:46:23 +0900 [thread overview]
Message-ID: <55955CCF.4020106@gmail.com> (raw)
In-Reply-To: <1435841297-44200-1-git-send-email-nikolay@cumulusnetworks.com>
On 15/07/02 (木) 21:48, Nikolay Aleksandrov wrote:
> Vlan ids 0 and 4095 were disallowed by commit:
> 8adff41c3d25 ("bridge: Don't use VID 0 and 4095 in vlan filtering")
> but then the check was removed when vlan ranges were introduced by:
> bdced7ef7838 ("bridge: support for multiple vlans and vlan ranges in setlink and dellink requests")
> So reintroduce the vlan range check.
> Before patch:
> [root@testvm ~]# bridge vlan add vid 0 dev eth0 master
> (succeeds)
> After Patch:
> [root@testvm ~]# bridge vlan add vid 0 dev eth0 master
> RTNETLINK answers: Invalid argument
>
> Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
> Fixes: bdced7ef7838 ("bridge: support for multiple vlans and vlan ranges in setlink and dellink requests")
Thank you for fixing this.
Acked-by: Toshiaki Makita <toshiaki.makita1@gmail.com>
WARNING: multiple messages have this Message-ID (diff)
From: Toshiaki Makita <toshiaki.makita1@gmail.com>
To: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Cc: netdev@vger.kernel.org, vyasevich@gmail.com,
bridge@lists.linux-foundation.org, davem@davemloft.net,
roopa@cumulusnetworks.com
Subject: Re: [PATCH net] bridge: vlan: fix usage of vlan 0 and 4095 again
Date: Fri, 03 Jul 2015 00:46:23 +0900 [thread overview]
Message-ID: <55955CCF.4020106@gmail.com> (raw)
In-Reply-To: <1435841297-44200-1-git-send-email-nikolay@cumulusnetworks.com>
On 15/07/02 (木) 21:48, Nikolay Aleksandrov wrote:
> Vlan ids 0 and 4095 were disallowed by commit:
> 8adff41c3d25 ("bridge: Don't use VID 0 and 4095 in vlan filtering")
> but then the check was removed when vlan ranges were introduced by:
> bdced7ef7838 ("bridge: support for multiple vlans and vlan ranges in setlink and dellink requests")
> So reintroduce the vlan range check.
> Before patch:
> [root@testvm ~]# bridge vlan add vid 0 dev eth0 master
> (succeeds)
> After Patch:
> [root@testvm ~]# bridge vlan add vid 0 dev eth0 master
> RTNETLINK answers: Invalid argument
>
> Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
> Fixes: bdced7ef7838 ("bridge: support for multiple vlans and vlan ranges in setlink and dellink requests")
Thank you for fixing this.
Acked-by: Toshiaki Makita <toshiaki.makita1@gmail.com>
next prev parent reply other threads:[~2015-07-02 15:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-02 12:48 [Bridge] [PATCH net] bridge: vlan: fix usage of vlan 0 and 4095 again Nikolay Aleksandrov
2015-07-02 12:48 ` Nikolay Aleksandrov
2015-07-02 15:46 ` Toshiaki Makita [this message]
2015-07-02 15:46 ` Toshiaki Makita
2015-07-02 19:19 ` [Bridge] " David Miller
2015-07-02 19:19 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55955CCF.4020106@gmail.com \
--to=toshiaki.makita1@gmail.com \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=roopa@cumulusnetworks.com \
--cc=vyasevich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.