All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gregory CLEMENT <gregory.clement@free-electrons.com>
To: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
	Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
	linux-arm-kernel@lists.infradead.org,
	Maxime Ripard <maxime.ripard@free-electrons.com>,
	Boris BREZILLON <boris.brezillon@free-electrons.com>,
	Lior Amsalem <alior@marvell.com>,
	Tawfik Bayouk <tawfik@marvell.com>,
	Nadav Haklai <nadavh@marvell.com>,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/4] ARM: mvebu: Allow using the GIC for wakeup in standby mode
Date: Fri, 03 Jul 2015 09:18:48 +0200	[thread overview]
Message-ID: <55963758.30200@free-electrons.com> (raw)
In-Reply-To: <20150701175436.7dff0754@free-electrons.com>

Hi Thomas,

On 01/07/2015 17:54, Thomas Petazzoni wrote:
> Dear Gregory CLEMENT,
> 
> On Tue, 30 Jun 2015 19:18:59 +0200, Gregory CLEMENT wrote:
> 
>>  static void __init mvebu_init_irq(void)
>>  {
>> +	if (of_machine_is_compatible("marvell,armada375") ||
>> +	    of_machine_is_compatible("marvell,armada380") ||
>> +	    of_machine_is_compatible("marvell,armada390"))
> 
> What we really want to know is if we're using the GIC, so what about
> instead:
> 
> 	np = of_find_compatible_node(NULL, NULL, "arm,cortex-a9-gic");
> 	if (np)
> 		gic_set_irqchip_flags(IRQCHIP_SKIP_SET_WAKE |
> 				      IRQCHIP_MASK_ON_SUSPEND);
> 	of_node_put(np);
> 
> (Not even compile-tested).

Indeed it is better. I will make the change.

Thanks,

Gregory


> 
> Thanks,
> 
> Thomas
> 


-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

WARNING: multiple messages have this Message-ID (diff)
From: gregory.clement@free-electrons.com (Gregory CLEMENT)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/4] ARM: mvebu: Allow using the GIC for wakeup in standby mode
Date: Fri, 03 Jul 2015 09:18:48 +0200	[thread overview]
Message-ID: <55963758.30200@free-electrons.com> (raw)
In-Reply-To: <20150701175436.7dff0754@free-electrons.com>

Hi Thomas,

On 01/07/2015 17:54, Thomas Petazzoni wrote:
> Dear Gregory CLEMENT,
> 
> On Tue, 30 Jun 2015 19:18:59 +0200, Gregory CLEMENT wrote:
> 
>>  static void __init mvebu_init_irq(void)
>>  {
>> +	if (of_machine_is_compatible("marvell,armada375") ||
>> +	    of_machine_is_compatible("marvell,armada380") ||
>> +	    of_machine_is_compatible("marvell,armada390"))
> 
> What we really want to know is if we're using the GIC, so what about
> instead:
> 
> 	np = of_find_compatible_node(NULL, NULL, "arm,cortex-a9-gic");
> 	if (np)
> 		gic_set_irqchip_flags(IRQCHIP_SKIP_SET_WAKE |
> 				      IRQCHIP_MASK_ON_SUSPEND);
> 	of_node_put(np);
> 
> (Not even compile-tested).

Indeed it is better. I will make the change.

Thanks,

Gregory


> 
> Thanks,
> 
> Thomas
> 


-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2015-07-03  7:18 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-30 17:18 [PATCH v2 0/4] Add standby support for the recent mvebu SoCs Gregory CLEMENT
2015-06-30 17:18 ` Gregory CLEMENT
2015-06-30 17:18 ` [PATCH v2 1/4] ARM: mvebu: Use __init for the PM initialization functions Gregory CLEMENT
2015-06-30 17:18   ` Gregory CLEMENT
2015-06-30 17:18   ` Gregory CLEMENT
2015-07-01 15:18   ` Thomas Petazzoni
2015-07-01 15:18     ` Thomas Petazzoni
2015-06-30 17:18 ` [PATCH v2 2/4] ARM: mvebu: Add standby support Gregory CLEMENT
2015-06-30 17:18   ` Gregory CLEMENT
2015-07-01 15:47   ` Thomas Petazzoni
2015-07-01 15:47     ` Thomas Petazzoni
2015-07-03 11:39     ` Gregory CLEMENT
2015-07-03 11:39       ` Gregory CLEMENT
2015-07-03 12:17       ` Thomas Petazzoni
2015-07-03 12:17         ` Thomas Petazzoni
2015-07-03 12:21         ` Gregory CLEMENT
2015-07-03 12:21           ` Gregory CLEMENT
2015-07-03 12:33           ` Thomas Petazzoni
2015-07-03 12:33             ` Thomas Petazzoni
2015-06-30 17:18 ` [PATCH v2 3/4] ARM: mvebu: Allow using the GIC for wakeup in standby mode Gregory CLEMENT
2015-06-30 17:18   ` Gregory CLEMENT
2015-07-01 15:54   ` Thomas Petazzoni
2015-07-01 15:54     ` Thomas Petazzoni
2015-07-03  7:18     ` Gregory CLEMENT [this message]
2015-07-03  7:18       ` Gregory CLEMENT
2015-07-27 11:02     ` Sudeep Holla
2015-07-27 11:02       ` Sudeep Holla
2015-07-28  9:42       ` Gregory CLEMENT
2015-07-28  9:42         ` Gregory CLEMENT
2015-07-01 16:05   ` Sudeep Holla
2015-07-01 16:05     ` Sudeep Holla
2015-07-01 16:56     ` Geert Uytterhoeven
2015-07-01 16:56       ` Geert Uytterhoeven
2015-06-30 17:19 ` [PATCH v2 4/4] ARM: mvebu: Warn about the wake-up sources not taken into account in suspend Gregory CLEMENT
2015-06-30 17:19   ` Gregory CLEMENT
2015-07-01 16:04   ` Thomas Petazzoni
2015-07-01 16:04     ` Thomas Petazzoni
2015-07-03  9:55     ` Gregory CLEMENT
2015-07-03  9:55       ` Gregory CLEMENT
2015-07-25 15:20 ` [PATCH v2 0/4] Add standby support for the recent mvebu SoCs Gregory CLEMENT
2015-07-25 15:20   ` Gregory CLEMENT

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55963758.30200@free-electrons.com \
    --to=gregory.clement@free-electrons.com \
    --cc=alior@marvell.com \
    --cc=andrew@lunn.ch \
    --cc=boris.brezillon@free-electrons.com \
    --cc=ezequiel.garcia@free-electrons.com \
    --cc=jason@lakedaemon.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=maxime.ripard@free-electrons.com \
    --cc=nadavh@marvell.com \
    --cc=sebastian.hesselbarth@gmail.com \
    --cc=tawfik@marvell.com \
    --cc=thomas.petazzoni@free-electrons.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.