From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: Reyad Attiyat <reyad.attiyat@gmail.com>,
Mathias Nyman <mathias.nyman@intel.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] usb: xhci: Add support for URB_ZERO_PACKET to bulk/sg transfers
Date: Fri, 03 Jul 2015 16:39:58 +0300 [thread overview]
Message-ID: <559690AE.5050507@linux.intel.com> (raw)
In-Reply-To: <CA+BWVURbWoJQ+NbOXyKLrtm5Hq2JwB_UyPhaKQtCxj0df3chxA@mail.gmail.com>
On 02.07.2015 22:00, Reyad Attiyat wrote:
> This version of the patch changes last_trb varible name to
> last_trb_num and fixes code style. I have also added a td to the urb
> td array. This now gets prepared properl,y with prepare_transfer(),
> and is handled correctly when transferred and completed. It only calls
> the urb completion callback once as there is a check in finish_td() to
> ensure that all td's have been received.
>
> If you think I should change anything else please let me know.
>
> Thank you,
> Reyad Attiyat
>
> On Thu, Jul 2, 2015 at 1:54 PM, Reyad Attiyat <reyad.attiyat@gmail.com> wrote:
>> This commit checks for the URB_ZERO_PACKET flag and creates an extra
>> zero-length td if the urb transfer length is a multiple of the endpoint's
>> max packet length.
>>
>> Signed-off-by: Reyad Attiyat <reyad.attiyat@gmail.com>
>> ---
Looks good, Thank you
I assume it works with your wireless card?
I'll go on a two weeks vacation starting now, but after that I'll
send it forward. (it should go to usb-next and reach 4.3 kernel anyway)
-Mathias
prev parent reply other threads:[~2015-07-03 13:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-02 18:54 [PATCH v3] usb: xhci: Add support for URB_ZERO_PACKET to bulk/sg transfers Reyad Attiyat
2015-07-02 19:00 ` Reyad Attiyat
2015-07-03 13:39 ` Mathias Nyman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559690AE.5050507@linux.intel.com \
--to=mathias.nyman@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=reyad.attiyat@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.