All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Osipenko <digetx@gmail.com>
To: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
	QEMU Developers <qemu-devel@nongnu.org>,
	Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 3/3] arm_mptimer: Respect IT bit state
Date: Sat, 04 Jul 2015 22:58:15 +0300	[thread overview]
Message-ID: <55983AD7.2030700@gmail.com> (raw)
In-Reply-To: <CAEgOgz54J9Dkt4kV7Ef1g4SSMR8hrPtWeuAmSuaXrvtEK4Z7+A@mail.gmail.com>

Hello Peter,

04.07.2015 22:39, Peter Crosthwaite пишет:
>
> You also need to trigger timerblock_update_irq on change of state for
> the control bit itself. "case 8: /* Control.  */" in the _write
> handler needs to call this fn.
>

Right, as it will mask/unmask interrupt line. Good catch, thanks.

-- 
Dmitry

  reply	other threads:[~2015-07-04 19:58 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-02 22:52 [Qemu-devel] arm_mptimer fixes Dmitry Osipenko
2015-07-02 22:52 ` [Qemu-devel] [PATCH 1/3 v3] arm_mptimer: Fix timer shutdown Dmitry Osipenko
2015-07-02 22:52 ` [Qemu-devel] [PATCH 2/3] arm_mptimer: Fix ONE-SHOT -> PERIODIC mode change Dmitry Osipenko
2015-07-04 19:36   ` Peter Crosthwaite
2015-07-04 23:13     ` Dmitry Osipenko
2015-07-02 22:52 ` [Qemu-devel] [PATCH 3/3] arm_mptimer: Respect IT bit state Dmitry Osipenko
2015-07-04 19:39   ` Peter Crosthwaite
2015-07-04 19:58     ` Dmitry Osipenko [this message]
2015-07-05 15:39 ` [Qemu-devel] [v2] arm_mptimer fixes Dmitry Osipenko
2015-07-05 15:39   ` [Qemu-devel] [PATCH 1/2] arm_mptimer: Fix timer shutdown and mode change Dmitry Osipenko
2015-07-05 19:07     ` Peter Crosthwaite
2015-07-05 20:00       ` Dmitry Osipenko
2015-07-05 21:19     ` Peter Crosthwaite
2015-07-05 21:29       ` Dmitry Osipenko
2015-07-05 15:39   ` [Qemu-devel] [PATCH v2 2/2] arm_mptimer: Respect IT bit state Dmitry Osipenko
2015-07-05 19:41     ` Peter Crosthwaite
2015-07-05 19:52   ` [Qemu-devel] [v2] arm_mptimer fixes Peter Crosthwaite
2015-07-05 20:05     ` Dmitry Osipenko
2015-07-05 20:14     ` Dmitry Osipenko
2015-07-05 22:47 ` [Qemu-devel] [PATCH v3 0/2] " Dmitry Osipenko
2015-07-05 22:47   ` [Qemu-devel] [PATCH v2 1/2] arm_mptimer: Fix timer shutdown and mode change Dmitry Osipenko
2015-07-05 22:47   ` [Qemu-devel] [PATCH v3 2/2] arm_mptimer: Respect IT bit state Dmitry Osipenko
2015-07-06  1:02     ` Dmitry Osipenko
2015-07-06  1:27       ` [Qemu-devel] [PATCH v4] " Dmitry Osipenko
2015-07-06  9:23         ` Peter Maydell
2015-07-06 13:11           ` Dmitry Osipenko
2015-07-06 13:16             ` Peter Maydell
2015-07-06 13:38               ` Dmitry Osipenko
2015-07-06 16:45                 ` Peter Crosthwaite
2015-07-06 17:58                   ` Dmitry Osipenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55983AD7.2030700@gmail.com \
    --to=digetx@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.crosthwaite@xilinx.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.