* [PATCH 1/2] iio:light:ltr501: fix regmap dependency [not found] <cover.1435487041.git.knaack.h@gmx.de> @ 2015-06-28 10:31 ` Hartmut Knaack 2015-06-29 7:56 ` Daniel Baluta 2015-06-28 10:31 ` [PATCH 2/2] iio:light:ltr501: fix variable in ltr501_init Hartmut Knaack 1 sibling, 1 reply; 6+ messages in thread From: Hartmut Knaack @ 2015-06-28 10:31 UTC (permalink / raw) To: linux-iio Cc: Jonathan Cameron, Lars-Peter Clausen, Peter Meerwald, Kuppuswamy Sathyanarayanan, Daniel Baluta The use of regmap in commit [1] requires REGMAP_I2C to be selected, in order to meet all dependencies. [1] 2f2c96338afc9f90aa5a0fca04ece1a5c389ee31 "iio: ltr501: Add regmap support." Signed-off-by: Hartmut Knaack <knaack.h@gmx.de> --- drivers/iio/light/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/iio/light/Kconfig b/drivers/iio/light/Kconfig index 730fa80..1f1e103 100644 --- a/drivers/iio/light/Kconfig +++ b/drivers/iio/light/Kconfig @@ -199,6 +199,7 @@ config SENSORS_LM3533 config LTR501 tristate "LTR-501ALS-01 light sensor" depends on I2C + select REGMAP_I2C select IIO_BUFFER select IIO_TRIGGERED_BUFFER help -- 2.3.6 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] iio:light:ltr501: fix regmap dependency 2015-06-28 10:31 ` [PATCH 1/2] iio:light:ltr501: fix regmap dependency Hartmut Knaack @ 2015-06-29 7:56 ` Daniel Baluta 2015-07-05 13:16 ` Jonathan Cameron 0 siblings, 1 reply; 6+ messages in thread From: Daniel Baluta @ 2015-06-29 7:56 UTC (permalink / raw) To: Hartmut Knaack Cc: linux-iio@vger.kernel.org, Jonathan Cameron, Lars-Peter Clausen, Peter Meerwald, Kuppuswamy Sathyanarayanan, Daniel Baluta On Sun, Jun 28, 2015 at 1:31 PM, Hartmut Knaack <knaack.h@gmx.de> wrote: > The use of regmap in commit [1] requires REGMAP_I2C to be selected, in > order to meet all dependencies. > > [1] 2f2c96338afc9f90aa5a0fca04ece1a5c389ee31 > "iio: ltr501: Add regmap support." The standard way to do this is: Fixes: 2f2c96338afc ("iio: ltr501: Add regmap support.") > > Signed-off-by: Hartmut Knaack <knaack.h@gmx.de> Otherwise, Acked-by: Daniel Baluta <daniel.baluta@intel.com> > --- > drivers/iio/light/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/iio/light/Kconfig b/drivers/iio/light/Kconfig > index 730fa80..1f1e103 100644 > --- a/drivers/iio/light/Kconfig > +++ b/drivers/iio/light/Kconfig > @@ -199,6 +199,7 @@ config SENSORS_LM3533 > config LTR501 > tristate "LTR-501ALS-01 light sensor" > depends on I2C > + select REGMAP_I2C > select IIO_BUFFER > select IIO_TRIGGERED_BUFFER > help > -- > 2.3.6 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] iio:light:ltr501: fix regmap dependency 2015-06-29 7:56 ` Daniel Baluta @ 2015-07-05 13:16 ` Jonathan Cameron 0 siblings, 0 replies; 6+ messages in thread From: Jonathan Cameron @ 2015-07-05 13:16 UTC (permalink / raw) To: Daniel Baluta, Hartmut Knaack Cc: linux-iio@vger.kernel.org, Lars-Peter Clausen, Peter Meerwald, Kuppuswamy Sathyanarayanan On 29/06/15 08:56, Daniel Baluta wrote: > On Sun, Jun 28, 2015 at 1:31 PM, Hartmut Knaack <knaack.h@gmx.de> wrote: >> The use of regmap in commit [1] requires REGMAP_I2C to be selected, in >> order to meet all dependencies. >> >> [1] 2f2c96338afc9f90aa5a0fca04ece1a5c389ee31 >> "iio: ltr501: Add regmap support." > > The standard way to do this is: > > Fixes: 2f2c96338afc ("iio: ltr501: Add regmap support.") > >> >> Signed-off-by: Hartmut Knaack <knaack.h@gmx.de> > > Otherwise, > > Acked-by: Daniel Baluta <daniel.baluta@intel.com> Hmm. My filters had eaten this patch for some reason... Anyhow, dug it out and applied. Hopefully nothing else has gone missing! Jonathan > >> --- >> drivers/iio/light/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/iio/light/Kconfig b/drivers/iio/light/Kconfig >> index 730fa80..1f1e103 100644 >> --- a/drivers/iio/light/Kconfig >> +++ b/drivers/iio/light/Kconfig >> @@ -199,6 +199,7 @@ config SENSORS_LM3533 >> config LTR501 >> tristate "LTR-501ALS-01 light sensor" >> depends on I2C >> + select REGMAP_I2C >> select IIO_BUFFER >> select IIO_TRIGGERED_BUFFER >> help >> -- >> 2.3.6 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-iio" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/2] iio:light:ltr501: fix variable in ltr501_init [not found] <cover.1435487041.git.knaack.h@gmx.de> 2015-06-28 10:31 ` [PATCH 1/2] iio:light:ltr501: fix regmap dependency Hartmut Knaack @ 2015-06-28 10:31 ` Hartmut Knaack 2015-06-29 7:57 ` Daniel Baluta 1 sibling, 1 reply; 6+ messages in thread From: Hartmut Knaack @ 2015-06-28 10:31 UTC (permalink / raw) To: linux-iio Cc: Jonathan Cameron, Lars-Peter Clausen, Peter Meerwald, Kuppuswamy Sathyanarayanan, Daniel Baluta When filling data->als_contr, the register content read into status needs to be used, instead of the return status value of regmap_read. This fixes: 8592a7eefa540303dd9e60fa49340d09ca9376b4 "iio: ltr501: Add support for ltr559 chip" Signed-off-by: Hartmut Knaack <knaack.h@gmx.de> --- drivers/iio/light/ltr501.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/light/ltr501.c b/drivers/iio/light/ltr501.c index 1ef7d37..b5a0e66 100644 --- a/drivers/iio/light/ltr501.c +++ b/drivers/iio/light/ltr501.c @@ -1302,7 +1302,7 @@ static int ltr501_init(struct ltr501_data *data) if (ret < 0) return ret; - data->als_contr = ret | data->chip_info->als_mode_active; + data->als_contr = status | data->chip_info->als_mode_active; ret = regmap_read(data->regmap, LTR501_PS_CONTR, &status); if (ret < 0) -- 2.3.6 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] iio:light:ltr501: fix variable in ltr501_init 2015-06-28 10:31 ` [PATCH 2/2] iio:light:ltr501: fix variable in ltr501_init Hartmut Knaack @ 2015-06-29 7:57 ` Daniel Baluta 2015-06-29 9:51 ` Hartmut Knaack 0 siblings, 1 reply; 6+ messages in thread From: Daniel Baluta @ 2015-06-29 7:57 UTC (permalink / raw) To: Hartmut Knaack Cc: linux-iio@vger.kernel.org, Jonathan Cameron, Lars-Peter Clausen, Peter Meerwald, Kuppuswamy Sathyanarayanan, Daniel Baluta On Sun, Jun 28, 2015 at 1:31 PM, Hartmut Knaack <knaack.h@gmx.de> wrote: > When filling data->als_contr, the register content read into status needs > to be used, instead of the return status value of regmap_read. > > This fixes: 8592a7eefa540303dd9e60fa49340d09ca9376b4 > "iio: ltr501: Add support for ltr559 chip" > Ditto, as per previous patch: Fixes: 8592a7eefa540 ("iio: ltr501: Add support for ltr559 chip") Also, I'm pretty sure that checkpatch.pl should have warned you about this. > Signed-off-by: Hartmut Knaack <knaack.h@gmx.de> > --- > drivers/iio/light/ltr501.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/light/ltr501.c b/drivers/iio/light/ltr501.c > index 1ef7d37..b5a0e66 100644 > --- a/drivers/iio/light/ltr501.c > +++ b/drivers/iio/light/ltr501.c > @@ -1302,7 +1302,7 @@ static int ltr501_init(struct ltr501_data *data) > if (ret < 0) > return ret; > > - data->als_contr = ret | data->chip_info->als_mode_active; > + data->als_contr = status | data->chip_info->als_mode_active; > > ret = regmap_read(data->regmap, LTR501_PS_CONTR, &status); > if (ret < 0) > -- > 2.3.6 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] iio:light:ltr501: fix variable in ltr501_init 2015-06-29 7:57 ` Daniel Baluta @ 2015-06-29 9:51 ` Hartmut Knaack 0 siblings, 0 replies; 6+ messages in thread From: Hartmut Knaack @ 2015-06-29 9:51 UTC (permalink / raw) To: Daniel Baluta Cc: linux-iio@vger.kernel.org, Jonathan Cameron, Lars-Peter Clausen, Peter Meerwald, Kuppuswamy Sathyanarayanan Daniel Baluta schrieb am 29.06.2015 um 09:57: > On Sun, Jun 28, 2015 at 1:31 PM, Hartmut Knaack <knaack.h@gmx.de> wrote: >> When filling data->als_contr, the register content read into status needs >> to be used, instead of the return status value of regmap_read. >> >> This fixes: 8592a7eefa540303dd9e60fa49340d09ca9376b4 >> "iio: ltr501: Add support for ltr559 chip" >> > > Ditto, as per previous patch: > > Fixes: 8592a7eefa540 ("iio: ltr501: Add support for ltr559 chip") > > Also, I'm pretty sure that checkpatch.pl should have warned you about > this. > Unfortunately it doesn't. But I will keep it in mind. >> Signed-off-by: Hartmut Knaack <knaack.h@gmx.de> >> --- >> drivers/iio/light/ltr501.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/iio/light/ltr501.c b/drivers/iio/light/ltr501.c >> index 1ef7d37..b5a0e66 100644 >> --- a/drivers/iio/light/ltr501.c >> +++ b/drivers/iio/light/ltr501.c >> @@ -1302,7 +1302,7 @@ static int ltr501_init(struct ltr501_data *data) >> if (ret < 0) >> return ret; >> >> - data->als_contr = ret | data->chip_info->als_mode_active; >> + data->als_contr = status | data->chip_info->als_mode_active; >> >> ret = regmap_read(data->regmap, LTR501_PS_CONTR, &status); >> if (ret < 0) >> -- >> 2.3.6 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-iio" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-07-05 13:16 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <cover.1435487041.git.knaack.h@gmx.de>
2015-06-28 10:31 ` [PATCH 1/2] iio:light:ltr501: fix regmap dependency Hartmut Knaack
2015-06-29 7:56 ` Daniel Baluta
2015-07-05 13:16 ` Jonathan Cameron
2015-06-28 10:31 ` [PATCH 2/2] iio:light:ltr501: fix variable in ltr501_init Hartmut Knaack
2015-06-29 7:57 ` Daniel Baluta
2015-06-29 9:51 ` Hartmut Knaack
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.