From: Richard Henderson <rth@twiddle.net>
To: Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru>, qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, leon.alrae@imgtec.com, agraf@suse.de,
aurelien@aurel32.net
Subject: Re: [Qemu-devel] [PATCH v5 08/11] target-i386: exception handling for seg_helper functions
Date: Mon, 6 Jul 2015 13:13:30 +0100 [thread overview]
Message-ID: <559A70EA.2040109@twiddle.net> (raw)
In-Reply-To: <20150706082622.11980.74680.stgit@PASHA-ISP>
On 07/06/2015 09:26 AM, Pavel Dovgalyuk wrote:
> This patch fixes exception handling for seg_helper functions.
>
> Signed-off-by: Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>
No, you don't want to discriminately change every call. That was my original
point about not needing to change seg_helper.c or smm_helper.c.
Further, any such changes would go along with the changes in translate.c to
remove the state saving there.
I would only change those that are "normal" memory operations, like fp loads
etc. The segmentation changes are rare. The task state helpers require state
saving anyway, so requiring a TCG search is a pessimization.
r~
next prev parent reply other threads:[~2015-07-06 12:13 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-06 8:25 [Qemu-devel] [PATCH v5 00/11] Fix exceptions handling for MIPS, PowerPC, and i386 Pavel Dovgalyuk
2015-07-06 8:25 ` [Qemu-devel] [PATCH v5 01/11] softmmu: add helper function to pass through retaddr Pavel Dovgalyuk
2015-07-06 10:22 ` Aurelien Jarno
2015-07-06 8:25 ` [Qemu-devel] [PATCH v5 02/11] cpu-exec: introduce loop exit with restore function Pavel Dovgalyuk
2015-07-06 10:22 ` Aurelien Jarno
2015-07-06 8:25 ` [Qemu-devel] [PATCH v5 03/11] target-mips: improve exceptions handling Pavel Dovgalyuk
2015-07-06 10:23 ` Aurelien Jarno
2015-07-06 8:26 ` [Qemu-devel] [PATCH v5 04/11] target-i386: introduce new raise_exception functions Pavel Dovgalyuk
2015-07-06 11:57 ` Richard Henderson
2015-07-06 12:12 ` Aurelien Jarno
2015-07-06 8:26 ` [Qemu-devel] [PATCH v5 05/11] target-i386: exception handling for FPU instructions Pavel Dovgalyuk
2015-07-06 12:04 ` Richard Henderson
2015-07-06 12:42 ` Pavel Dovgaluk
[not found] ` <559a77d3.4e58980a.7a073.ffff997eSMTPIN_ADDED_BROKEN@mx.google.com>
2015-07-06 15:11 ` Richard Henderson
2015-07-06 12:12 ` Aurelien Jarno
2015-07-06 8:26 ` [Qemu-devel] [PATCH v5 06/11] target-i386: exception handling for div instructions Pavel Dovgalyuk
2015-07-06 12:04 ` Richard Henderson
2015-07-06 12:14 ` Aurelien Jarno
2015-07-06 8:26 ` [Qemu-devel] [PATCH v5 07/11] target-i386: exception handling for memory helpers Pavel Dovgalyuk
2015-07-06 12:07 ` Richard Henderson
2015-07-06 12:19 ` Aurelien Jarno
2015-07-06 8:26 ` [Qemu-devel] [PATCH v5 08/11] target-i386: exception handling for seg_helper functions Pavel Dovgalyuk
2015-07-06 12:13 ` Richard Henderson [this message]
2015-07-06 12:15 ` Pavel Dovgaluk
2015-07-07 10:13 ` Pavel Dovgaluk
2015-07-06 8:26 ` [Qemu-devel] [PATCH v5 09/11] target-i386: exception handling for other helper functions Pavel Dovgalyuk
2015-07-06 8:26 ` [Qemu-devel] [PATCH v5 10/11] target-i386: remove useless PC updates Pavel Dovgalyuk
2015-07-06 12:21 ` Aurelien Jarno
2015-07-06 8:26 ` [Qemu-devel] [PATCH v5 11/11] target-ppc: exceptions handling in icount mode Pavel Dovgalyuk
2015-07-06 12:21 ` Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559A70EA.2040109@twiddle.net \
--to=rth@twiddle.net \
--cc=Pavel.Dovgaluk@ispras.ru \
--cc=agraf@suse.de \
--cc=aurelien@aurel32.net \
--cc=leon.alrae@imgtec.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.