From: Tero Kristo <t-kristo@ti.com>
To: Tony Lindgren <tony@atomide.com>,
Grygorii Strashko <grygorii.strashko@ti.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
linux-omap@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org, Nishanth Menon <nm@ti.com>
Subject: Re: [PATCH] pinctrl: single: dra7: remove PCS_QUIRK_SHARED_IRQ
Date: Tue, 7 Jul 2015 10:23:08 +0300 [thread overview]
Message-ID: <559B7E5C.2010204@ti.com> (raw)
In-Reply-To: <20150706152549.GL10705@atomide.com>
On 07/06/2015 06:25 PM, Tony Lindgren wrote:
> * Grygorii Strashko <grygorii.strashko@ti.com> [150706 08:14]:
>> On DRA7 there is one pinctrl domain (dra7_pmx_core) and
>> PRCM wake-up IRQ is not shared, so remove quirk.
>>
>> Cc: Nishanth Menon <nm@ti.com>
>> Cc: Tony Lindgren <tony@atomide.com>
>> Fixes: 31320beaa3d3 ('pinctrl: single: Add DRA7 pinctrl compatibility')
>> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
>> ---
>> drivers/pinctrl/pinctrl-single.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c
>> index 0b8d480..9b24b343 100644
>> --- a/drivers/pinctrl/pinctrl-single.c
>> +++ b/drivers/pinctrl/pinctrl-single.c
>> @@ -1983,7 +1983,6 @@ static const struct pcs_soc_data pinctrl_single_omap_wkup = {
>> };
>>
>> static const struct pcs_soc_data pinctrl_single_dra7 = {
>> - .flags = PCS_QUIRK_SHARED_IRQ,
>> .irq_enable_mask = (1 << 24), /* WAKEUPENABLE */
>> .irq_status_mask = (1 << 25), /* WAKEUPEVENT */
>> };
>
> Tero, care to take a look at this one and ack if OK?
Looks fine to me.
Acked-by: Tero Kristo <t-kristo@ti.com>
>
> Regards,
>
> Tony
>
WARNING: multiple messages have this Message-ID (diff)
From: Tero Kristo <t-kristo@ti.com>
To: Tony Lindgren <tony@atomide.com>,
Grygorii Strashko <grygorii.strashko@ti.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
<linux-omap@vger.kernel.org>, <linux-gpio@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, Nishanth Menon <nm@ti.com>
Subject: Re: [PATCH] pinctrl: single: dra7: remove PCS_QUIRK_SHARED_IRQ
Date: Tue, 7 Jul 2015 10:23:08 +0300 [thread overview]
Message-ID: <559B7E5C.2010204@ti.com> (raw)
In-Reply-To: <20150706152549.GL10705@atomide.com>
On 07/06/2015 06:25 PM, Tony Lindgren wrote:
> * Grygorii Strashko <grygorii.strashko@ti.com> [150706 08:14]:
>> On DRA7 there is one pinctrl domain (dra7_pmx_core) and
>> PRCM wake-up IRQ is not shared, so remove quirk.
>>
>> Cc: Nishanth Menon <nm@ti.com>
>> Cc: Tony Lindgren <tony@atomide.com>
>> Fixes: 31320beaa3d3 ('pinctrl: single: Add DRA7 pinctrl compatibility')
>> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
>> ---
>> drivers/pinctrl/pinctrl-single.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c
>> index 0b8d480..9b24b343 100644
>> --- a/drivers/pinctrl/pinctrl-single.c
>> +++ b/drivers/pinctrl/pinctrl-single.c
>> @@ -1983,7 +1983,6 @@ static const struct pcs_soc_data pinctrl_single_omap_wkup = {
>> };
>>
>> static const struct pcs_soc_data pinctrl_single_dra7 = {
>> - .flags = PCS_QUIRK_SHARED_IRQ,
>> .irq_enable_mask = (1 << 24), /* WAKEUPENABLE */
>> .irq_status_mask = (1 << 25), /* WAKEUPEVENT */
>> };
>
> Tero, care to take a look at this one and ack if OK?
Looks fine to me.
Acked-by: Tero Kristo <t-kristo@ti.com>
>
> Regards,
>
> Tony
>
next prev parent reply other threads:[~2015-07-07 7:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-06 15:11 [PATCH] pinctrl: single: dra7: remove PCS_QUIRK_SHARED_IRQ Grygorii Strashko
2015-07-06 15:11 ` Grygorii Strashko
2015-07-06 15:25 ` Tony Lindgren
2015-07-07 7:23 ` Tero Kristo [this message]
2015-07-07 7:23 ` Tero Kristo
2015-07-07 7:43 ` Tony Lindgren
2015-07-16 12:36 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559B7E5C.2010204@ti.com \
--to=t-kristo@ti.com \
--cc=grygorii.strashko@ti.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.