From: Jennifer Herbert <Jennifer.Herbert@citrix.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: stefano.stabellini@eu.citrix.com, wei.liu2@citrix.com,
ian.campbell@citrix.com, xen-devel@lists.xen.org
Subject: Re: [PATCH 2/7] libxc: Use const pointer in local_file_dump()
Date: Tue, 7 Jul 2015 13:16:03 +0100 [thread overview]
Message-ID: <559BC303.5030508@citrix.com> (raw)
In-Reply-To: <21910.43476.413848.221992@mariner.uk.xensource.com>
On 03/07/15 16:27, Ian Jackson wrote:
> Jennifer Herbert writes ("[Xen-devel] [PATCH 2/7] libxc: Use const pointer in local_file_dump()"):
>> By adding the const keyword, it is clearer to people and static analysis
>> tools that no changes to the data are to be made.
> Would it be wrong for a future patch to add a field to dump_args which
> gets modified ? AFAICT the answer is `no'. So I don't understand why
> it ought to be const.
>
> Does your Coverity instance complain about every instance where a
> struct exists which is not marked const but which could be ?
Coverity see da->fd being passed to local_file_dump, as a modifiable
entity and concludes this function may be overwriting this, and end up
leaking the handle.
It wouldn't be wrong to modify a new field, I just hadn't considered
that likely. Since maybe it is, I'll just mark as false positive.
-jenny
next prev parent reply other threads:[~2015-07-07 12:16 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-01 17:37 [PATCH 0/7] libxc: Fix a number of coverity issues Jennifer Herbert
2015-07-01 17:37 ` [PATCH 1/7] libxc: fix uninitialized variable in xc_cpuid_pv_policy() Jennifer Herbert
2015-07-02 13:19 ` Andrew Cooper
2015-07-03 14:39 ` Andrew Cooper
2015-07-03 15:15 ` Ian Jackson
2015-07-03 15:39 ` Ian Campbell
2015-07-03 15:47 ` Ian Jackson
2015-07-03 15:50 ` Ian Campbell
2015-07-03 15:57 ` Andrew Cooper
2015-07-01 17:37 ` [PATCH 2/7] libxc: Use const pointer in local_file_dump() Jennifer Herbert
2015-07-03 15:27 ` Ian Jackson
2015-07-07 12:16 ` Jennifer Herbert [this message]
2015-07-07 12:15 ` Ian Jackson
2015-07-01 17:37 ` [PATCH 3/7] libxc: Fix uninitialized valiables in xc_cpuid_hvm_policy() Jennifer Herbert
2015-07-03 15:30 ` Ian Jackson
2015-07-01 17:37 ` [PATCH 4/7] libxc: Prevent dereferencing NULL pointers returned from xc_dom_allocate() Jennifer Herbert
2015-07-03 15:17 ` Ian Jackson
2015-07-03 16:01 ` Ian Campbell
2015-07-01 17:37 ` [PATCH 5/7] libxc: Removing dead code " Jennifer Herbert
2015-07-03 14:41 ` Andrew Cooper
2015-07-03 15:24 ` Ian Jackson
2015-07-03 15:31 ` Ian Campbell
2015-07-03 15:33 ` Ian Jackson
2015-07-03 15:46 ` Ian Campbell
2015-07-03 15:48 ` Ian Jackson
2015-07-01 17:37 ` [PATCH 6/7] libxc: Fix misleading use of strncpy code in build_hvm_info() Jennifer Herbert
2015-07-03 14:41 ` Andrew Cooper
2015-07-03 15:25 ` Ian Jackson
2015-07-03 16:01 ` Ian Campbell
2015-07-01 17:37 ` [PATCH 7/7] libxc: Prevent NULL pointer dereference in stdiostream_vmessage() Jennifer Herbert
2015-07-03 15:29 ` Ian Jackson
2015-07-03 15:37 ` Ian Campbell
2015-07-03 15:44 ` Ian Jackson
2015-07-02 13:23 ` [PATCH 0/7] libxc: Fix a number of coverity issues Andrew Cooper
2015-07-03 14:21 ` Ian Campbell
2015-07-03 14:20 ` Ian Campbell
2015-07-03 14:22 ` Andrew Cooper
2015-07-03 14:42 ` Ian Campbell
2015-07-03 14:49 ` Andrew Cooper
2015-07-03 15:13 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559BC303.5030508@citrix.com \
--to=jennifer.herbert@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=ian.campbell@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.