All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christopher J. Morrone <morrone2@llnl.gov>
To: lustre-devel@lists.lustre.org
Subject: [lustre-devel] [PATCH] [PATCH] staging/lustre: Remove unused MDS_CLOSE_CLEANUP	define
Date: Tue, 07 Jul 2015 12:57:38 -0700	[thread overview]
Message-ID: <559C2F32.5040104@llnl.gov> (raw)
In-Reply-To: <20150707153234.GA1872@lusbld01.us.cray.com>

Unless there is code in this client that explicitly prevents it from 
connecting with a pre-2.4.0 server, perhaps this flag should not be removed.

Chris

On 07/07/2015 08:32 AM, Ben Evans wrote:
> Previously, MDS_CLOSE_CLEANUP was used to detect file closing,
> due to eviction. This flag is no longer used.
>
> Signed-off-by: Aurelien Degremont <aurelien.degremont@cea.fr>
> Intel-bug-ID: http://jira.hpdd.intel.com/browse/LU-3677
> Reviewed-on: http://review.whamcloud.com/7195
> Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
> Reviewed-by: Jinshan Xiong <jinshan.xiong@intel.com>
> Reviewed-by: John L. Hammond <john.hammond@intel.com>
> Reviewed-by: Fan Yong <fan.yong@intel.com>
> Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
> Signed-off-by: Ben Evans <bevans@cray.com>
> ---
>   .../lustre/lustre/include/lustre/lustre_idl.h      |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/lustre/lustre/include/lustre/lustre_idl.h b/drivers/staging/lustre/lustre/include/lustre/lustre_idl.h
> index 4d72d6e..bea70cb 100644
> --- a/drivers/staging/lustre/lustre/include/lustre/lustre_idl.h
> +++ b/drivers/staging/lustre/lustre/include/lustre/lustre_idl.h
> @@ -2390,7 +2390,7 @@ enum mds_op_bias {
>   	MDS_PERM_BYPASS		= 1 << 3,
>   	MDS_SOM			= 1 << 4,
>   	MDS_QUOTA_IGNORE	= 1 << 5,
> -	MDS_CLOSE_CLEANUP	= 1 << 6,
> +	/* MDS_CLOSE_CLEANUP = 1 << 6, obsolete since 2.4.0 */
>   	MDS_KEEP_ORPHAN		= 1 << 7,
>   	MDS_RECOV_OPEN		= 1 << 8,
>   	MDS_DATA_MODIFIED	= 1 << 9,
>

  reply	other threads:[~2015-07-07 19:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-07 15:32 [lustre-devel] [PATCH] [PATCH] staging/lustre: Remove unused MDS_CLOSE_CLEANUP define Ben Evans
2015-07-07 19:57 ` Christopher J. Morrone [this message]
2015-07-08  0:44   ` Dilger, Andreas
2015-07-08  0:42 ` Dilger, Andreas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=559C2F32.5040104@llnl.gov \
    --to=morrone2@llnl.gov \
    --cc=lustre-devel@lists.lustre.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.