From: Alan Coopersmith <alan.coopersmith@oracle.com>
To: Emil Velikov <emil.l.velikov@gmail.com>
Cc: ML dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH:libdrm] include <sys/sysmacros.h> directly for major() and minor()
Date: Wed, 08 Jul 2015 10:39:00 -0700 [thread overview]
Message-ID: <559D6034.2020602@oracle.com> (raw)
In-Reply-To: <CACvgo53D3-toEcQ0m+n=COdDL8vmjdiU7dmBqJX=mehV+QoMrQ@mail.gmail.com>
On 07/ 8/15 09:19 AM, Emil Velikov wrote:
> Hi Alan
>
> On 7 July 2015 at 01:45, Alan Coopersmith <alan.coopersmith@oracle.com> wrote:
>> Linux seems to pick this up via another header, but Solaris needs it
>> explictly included, or we get undefined symbol errors for major & minor.
>>
> A slightly pedandic suggestion:
> Can we use sys/types.h + sys/mkdev.h as the manpage suggests. We
> already do so in xf86drm.c
Sure - I'd thought sysmacros.h was mentioned in a manpage, but can't find that
now. It builds fine with those instead, so v2 patch follows.
--
-Alan Coopersmith- alan.coopersmith@oracle.com
Oracle Solaris Engineering - http://blogs.oracle.com/alanc
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-07-08 17:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-07 0:45 [PATCH:libdrm] include <sys/sysmacros.h> directly for major() and minor() Alan Coopersmith
2015-07-08 16:19 ` Emil Velikov
2015-07-08 17:39 ` Alan Coopersmith [this message]
2015-07-08 17:41 ` [PATCH:libdrm] include <sys/types.h> & <sys/mkdev.h> " Alan Coopersmith
2015-07-08 17:59 ` Emil Velikov
2015-07-08 18:01 ` Alan Coopersmith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559D6034.2020602@oracle.com \
--to=alan.coopersmith@oracle.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.