[PATCH:libdrm] include <sys/sysmacros.h> directly for major() and minor()

[PATCH:libdrm] include <sys/sysmacros.h> directly for major() and minor()

[Alan Coopersmith]

Linux seems to pick this up via another header, but Solaris needs it
explictly included, or we get undefined symbol errors for major & minor.

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
---
 libkms/linux.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/libkms/linux.c b/libkms/linux.c
index 4d47148..f1767c8 100644
--- a/libkms/linux.c
+++ b/libkms/linux.c
@@ -40,6 +40,7 @@
 #include <string.h>
 #include <unistd.h>
 #include <sys/stat.h>
+#include <sys/sysmacros.h>
 
 #include "libdrm_macros.h"
 #include "internal.h"
-- 
1.7.9.2

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH:libdrm] include <sys/sysmacros.h> directly for major() and minor()

[Emil Velikov]

Hi Alan

On 7 July 2015 at 01:45, Alan Coopersmith <alan.coopersmith@oracle.com> wrote:
> Linux seems to pick this up via another header, but Solaris needs it
> explictly included, or we get undefined symbol errors for major & minor.
>
A slightly pedandic suggestion:
Can we use sys/types.h + sys/mkdev.h as the manpage suggests. We
already do so in xf86drm.c

Thanks
Emil
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH:libdrm] include <sys/sysmacros.h> directly for major() and minor()

[Alan Coopersmith]

On 07/ 8/15 09:19 AM, Emil Velikov wrote:
> Hi Alan
>
> On 7 July 2015 at 01:45, Alan Coopersmith <alan.coopersmith@oracle.com> wrote:
>> Linux seems to pick this up via another header, but Solaris needs it
>> explictly included, or we get undefined symbol errors for major & minor.
>>
> A slightly pedandic suggestion:
> Can we use sys/types.h + sys/mkdev.h as the manpage suggests. We
> already do so in xf86drm.c

Sure - I'd thought sysmacros.h was mentioned in a manpage, but can't find that 
now.  It builds fine with those instead, so v2 patch follows.

-- 
	-Alan Coopersmith-              alan.coopersmith@oracle.com
	 Oracle Solaris Engineering - http://blogs.oracle.com/alanc
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH:libdrm] include <sys/types.h> & <sys/mkdev.h> directly for major() and minor()

[Alan Coopersmith]

Linux seems to pick these up via another header, but Solaris needs them
explictly included, or we get undefined symbol errors for major & minor.

v2: use headers documented in makedev(3C) man page instead of sysmacros.h

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
---
 libkms/linux.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/libkms/linux.c b/libkms/linux.c
index 4d47148..53e03c3 100644
--- a/libkms/linux.c
+++ b/libkms/linux.c
@@ -40,6 +40,8 @@
 #include <string.h>
 #include <unistd.h>
 #include <sys/stat.h>
+#include <sys/types.h>
+#include <sys/mkdev.h>
 
 #include "libdrm_macros.h"
 #include "internal.h"
-- 
1.7.9.2

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH:libdrm] include <sys/types.h> & <sys/mkdev.h> directly for major() and minor()

[Emil Velikov]

On 8 July 2015 at 18:41, Alan Coopersmith <alan.coopersmith@oracle.com> wrote:
> Linux seems to pick these up via another header, but Solaris needs them
> explictly included, or we get undefined symbol errors for major & minor.
>
> v2: use headers documented in makedev(3C) man page instead of sysmacros.h
>
> Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
> ---
>  libkms/linux.c |    2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/libkms/linux.c b/libkms/linux.c
> index 4d47148..53e03c3 100644
> --- a/libkms/linux.c
> +++ b/libkms/linux.c
> @@ -40,6 +40,8 @@
>  #include <string.h>
>  #include <unistd.h>
>  #include <sys/stat.h>
> +#include <sys/types.h>
> +#include <sys/mkdev.h>
I'll add the HAVE_SYS_MKDEV_H guard around the latter, and push this
in the next few days. Unless someone objects that is ;-)

Thank you Alan,
Emil
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH:libdrm] include <sys/types.h> & <sys/mkdev.h> directly for major() and minor()

[Alan Coopersmith]

On 07/ 8/15 10:59 AM, Emil Velikov wrote:
> On 8 July 2015 at 18:41, Alan Coopersmith <alan.coopersmith@oracle.com> wrote:
>> Linux seems to pick these up via another header, but Solaris needs them
>> explictly included, or we get undefined symbol errors for major & minor.
>>
>> v2: use headers documented in makedev(3C) man page instead of sysmacros.h
>>
>> Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
>> ---
>>   libkms/linux.c |    2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/libkms/linux.c b/libkms/linux.c
>> index 4d47148..53e03c3 100644
>> --- a/libkms/linux.c
>> +++ b/libkms/linux.c
>> @@ -40,6 +40,8 @@
>>   #include <string.h>
>>   #include <unistd.h>
>>   #include <sys/stat.h>
>> +#include <sys/types.h>
>> +#include <sys/mkdev.h>
> I'll add the HAVE_SYS_MKDEV_H guard around the latter, and push this
> in the next few days. Unless someone objects that is ;-)

Oh, whoops, I forgot to check if there was a guard needed - that sounds
great to me, thanks.

-- 
	-Alan Coopersmith-              alan.coopersmith@oracle.com
	 Oracle Solaris Engineering - http://blogs.oracle.com/alanc
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel