From: Stephen Boyd <sboyd@codeaurora.org>
To: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: "Mike Turquette" <mturquette@baylibre.com>,
linux-clk@vger.kernel.org, "Jonathan Corbet" <corbet@lwn.net>,
"Tony Lindgren" <tony@atomide.com>,
"Ralf Baechle" <ralf@linux-mips.org>,
"Emilio López" <emilio@elopez.com.ar>,
"Maxime Ripard" <maxime.ripard@free-electrons.com>,
"Tero Kristo" <t-kristo@ti.com>,
"Peter De Schrijver" <pdeschrijver@nvidia.com>,
"Prashant Gaikwad" <pgaikwad@nvidia.com>,
"Stephen Warren" <swarren@wwwdotorg.org>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Alexandre Courbot" <gnurou@gmail.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
linux-mips@linux-mips.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH v5] clk: change clk_ops' ->determine_rate() prototype
Date: Wed, 08 Jul 2015 11:07:42 -0700 [thread overview]
Message-ID: <559D66EE.4060707@codeaurora.org> (raw)
In-Reply-To: <20150708110005.704c49ff@bbrezillon>
On 07/08/2015 02:00 AM, Boris Brezillon wrote:
> Hi Stephen,
>
> On Tue, 7 Jul 2015 17:57:48 -0700
> Stephen Boyd <sboyd@codeaurora.org> wrote:
>
>> On 07/07, Boris Brezillon wrote:
>>>
>>> } else {
>>> pr_err("clk: clk_composite_determine_rate function called, but no mux or rate callback set!\n");
>>> + req->rate = 0;
>>> return 0;
>> Shouldn't this return an error now? And then assigning req->rate
>> wouldn't be necessary. Sorry I must have missed this last round.
>>
> Actually I wanted to keep the existing behavior: return a 0 rate (not
> an error) when there is no mux or rate ops.
>
> That's something we can change afterwards, but it might reveals
> new bugs if some users are checking for a 0 rate to detect errors.
>
Ok. Care to send the patch now to do that while we're thinking about it?
We can test it out for a month or two.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5] clk: change clk_ops' ->determine_rate() prototype
Date: Wed, 08 Jul 2015 11:07:42 -0700 [thread overview]
Message-ID: <559D66EE.4060707@codeaurora.org> (raw)
In-Reply-To: <20150708110005.704c49ff@bbrezillon>
On 07/08/2015 02:00 AM, Boris Brezillon wrote:
> Hi Stephen,
>
> On Tue, 7 Jul 2015 17:57:48 -0700
> Stephen Boyd <sboyd@codeaurora.org> wrote:
>
>> On 07/07, Boris Brezillon wrote:
>>>
>>> } else {
>>> pr_err("clk: clk_composite_determine_rate function called, but no mux or rate callback set!\n");
>>> + req->rate = 0;
>>> return 0;
>> Shouldn't this return an error now? And then assigning req->rate
>> wouldn't be necessary. Sorry I must have missed this last round.
>>
> Actually I wanted to keep the existing behavior: return a 0 rate (not
> an error) when there is no mux or rate ops.
>
> That's something we can change afterwards, but it might reveals
> new bugs if some users are checking for a 0 rate to detect errors.
>
Ok. Care to send the patch now to do that while we're thinking about it?
We can test it out for a month or two.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2015-07-08 18:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-07 18:48 [PATCH v5] clk: change clk_ops' ->determine_rate() prototype Boris Brezillon
2015-07-07 18:48 ` Boris Brezillon
2015-07-08 0:57 ` Stephen Boyd
2015-07-08 0:57 ` Stephen Boyd
2015-07-08 9:00 ` Boris Brezillon
2015-07-08 9:00 ` Boris Brezillon
2015-07-08 9:00 ` Boris Brezillon
2015-07-08 18:07 ` Stephen Boyd [this message]
2015-07-08 18:07 ` Stephen Boyd
2015-07-09 20:39 ` Boris Brezillon
2015-07-09 20:39 ` Boris Brezillon
2015-07-09 20:39 ` Boris Brezillon
2015-07-09 20:39 ` Boris Brezillon
2015-07-09 20:39 ` Boris Brezillon
2015-07-09 20:39 ` Boris Brezillon
2015-07-13 23:02 ` Stephen Boyd
2015-07-13 23:02 ` Stephen Boyd
2015-07-14 10:47 ` Boris Brezillon
2015-07-14 10:47 ` Boris Brezillon
2015-07-13 9:01 ` Tero Kristo
2015-07-13 9:01 ` Tero Kristo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559D66EE.4060707@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=boris.brezillon@free-electrons.com \
--cc=corbet@lwn.net \
--cc=emilio@elopez.com.ar \
--cc=gnurou@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=mturquette@baylibre.com \
--cc=pdeschrijver@nvidia.com \
--cc=pgaikwad@nvidia.com \
--cc=ralf@linux-mips.org \
--cc=swarren@wwwdotorg.org \
--cc=t-kristo@ti.com \
--cc=thierry.reding@gmail.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.