From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Pavel Machek <pavel@ucw.cz>, Greg KH <greg@kroah.com>,
balbi@ti.com, george.cherian@ti.com, tony@atomide.com,
varkabhadram@gmail.com, linux-kernel@vger.kernel.org
Cc: pali.rohar@gmail.com, sre@debian.org, sre@ring0.de,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-omap@vger.kernel.org, khilman@kernel.org,
aaro.koskinen@iki.fi, ivo.g.dimitrov.75@gmail.com,
patrikbachan@gmail.com
Subject: Re: musb-hdrc: "Vbus off, timeout 1100 msec" message does not belong in sysfs
Date: Fri, 10 Jul 2015 09:17:39 +0200 [thread overview]
Message-ID: <559F7193.7090508@linutronix.de> (raw)
In-Reply-To: <20150709214610.GA20890@amd>
On 07/09/2015 11:46 PM, Pavel Machek wrote:
> On Thu 2015-07-09 23:39:22, Pavel Machek wrote:
>> Hi!
Hi,
>>
>> sysfs should contain one value per file. This one has at least two,
>> with nice english sentence as a bonus.
>>
>> root@n900:/sys/devices/platform/68000000.ocp/480ab000.usb_otg_hs/musb-hdrc.0.auto#
>> cat vbus
>> Vbus off, timeout 1100 msec
>>
>> :-(.
>
> Plus, documentation for this is nowhere to be seen:
>
> pavel@amd:/data/l/linux-n900$ grep -ri musb Documentation/ABI/
> pavel@amd:/data/l/linux-n900$
that is a shame indeed. It is part of the driver since TUSB support was
merged via commit 550a7375f ("USB: Add MUSB and TUSB support") about 7
years ago.
The parameter expects the timeout values which is used to poll the port
for mode changes (host/device mode) since it can not be detected on its
own.
Felipe knows best if it is better to document it or remove it. I can't
remember that I needed it on am335x.
> Pavel
>
Sebastian
WARNING: multiple messages have this Message-ID (diff)
From: bigeasy@linutronix.de (Sebastian Andrzej Siewior)
To: linux-arm-kernel@lists.infradead.org
Subject: musb-hdrc: "Vbus off, timeout 1100 msec" message does not belong in sysfs
Date: Fri, 10 Jul 2015 09:17:39 +0200 [thread overview]
Message-ID: <559F7193.7090508@linutronix.de> (raw)
In-Reply-To: <20150709214610.GA20890@amd>
On 07/09/2015 11:46 PM, Pavel Machek wrote:
> On Thu 2015-07-09 23:39:22, Pavel Machek wrote:
>> Hi!
Hi,
>>
>> sysfs should contain one value per file. This one has at least two,
>> with nice english sentence as a bonus.
>>
>> root at n900:/sys/devices/platform/68000000.ocp/480ab000.usb_otg_hs/musb-hdrc.0.auto#
>> cat vbus
>> Vbus off, timeout 1100 msec
>>
>> :-(.
>
> Plus, documentation for this is nowhere to be seen:
>
> pavel at amd:/data/l/linux-n900$ grep -ri musb Documentation/ABI/
> pavel at amd:/data/l/linux-n900$
that is a shame indeed. It is part of the driver since TUSB support was
merged via commit 550a7375f ("USB: Add MUSB and TUSB support") about 7
years ago.
The parameter expects the timeout values which is used to poll the port
for mode changes (host/device mode) since it can not be detected on its
own.
Felipe knows best if it is better to document it or remove it. I can't
remember that I needed it on am335x.
> Pavel
>
Sebastian
next prev parent reply other threads:[~2015-07-10 7:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-09 21:39 musb-hdrc: "Vbus off, timeout 1100 msec" message does not belong in sysfs Pavel Machek
2015-07-09 21:46 ` Pavel Machek
2015-07-09 21:46 ` Pavel Machek
2015-07-09 21:46 ` Pavel Machek
2015-07-09 21:54 ` Pali Rohár
2015-07-09 21:54 ` Pali Rohár
2015-07-10 7:17 ` Sebastian Andrzej Siewior [this message]
2015-07-10 7:17 ` Sebastian Andrzej Siewior
2015-07-13 20:30 ` Felipe Balbi
2015-07-13 20:30 ` Felipe Balbi
2015-07-13 20:30 ` Felipe Balbi
2015-07-10 19:50 ` Felipe Balbi
2015-07-10 21:46 ` Pavel Machek
2015-07-10 23:21 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559F7193.7090508@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=aaro.koskinen@iki.fi \
--cc=balbi@ti.com \
--cc=george.cherian@ti.com \
--cc=greg@kroah.com \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=pali.rohar@gmail.com \
--cc=patrikbachan@gmail.com \
--cc=pavel@ucw.cz \
--cc=sre@debian.org \
--cc=sre@ring0.de \
--cc=tony@atomide.com \
--cc=varkabhadram@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.