[PATCH] parse/ast.py: MethodNode fix character mapping error

[PATCH] parse/ast.py: MethodNode fix character mapping error

[Aníbal Limón]

When found an anonymous function the func name is made by filename
and lineno, the filename need to be converted to string before using
translation because produces an error of encoding.

Signed-off-by: Aníbal Limón <anibal.limon@linux.intel.com>
---
 lib/bb/parse/ast.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/bb/parse/ast.py b/lib/bb/parse/ast.py
index 1130b14..4937006 100644
--- a/lib/bb/parse/ast.py
+++ b/lib/bb/parse/ast.py
@@ -149,7 +149,7 @@ class MethodNode(AstNode):
     def eval(self, data):
         text = '\n'.join(self.body)
         if self.func_name == "__anonymous":
-            funcname = ("__anon_%s_%s" % (self.lineno, self.filename.translate(MethodNode.tr_tbl)))
+            funcname = ("__anon_%s_%s" % (self.lineno, str(self.filename).translate(MethodNode.tr_tbl)))
             text = "def %s(d):\n" % (funcname) + text
             bb.methodpool.insert_method(funcname, text, self.filename)
             anonfuncs = data.getVar('__BBANONFUNCS', False) or []
-- 
1.9.1

Re: [PATCH] parse/ast.py: MethodNode fix character mapping error

[Richard Purdie]

On Fri, 2015-07-10 at 11:44 -0500, Aníbal Limón wrote:
> When found an anonymous function the func name is made by filename
> and lineno, the filename need to be converted to string before using
> translation because produces an error of encoding.

Could you explain a little about why we don't hit this error in general?

Cheers,

Richard

Re: [PATCH] parse/ast.py: MethodNode fix character mapping error

[Aníbal Limón]

Hi Richard,

Sorry it was my mistake in my code because i'm loading a recipe file 
using bb.cache.Cache.loadDataFull
passing an unicode filepath this causes the error but i think it need to 
be sanitized? to avoid this kind of
problems.

Cheers,
     alimon

On 10/07/15 11:55, Richard Purdie wrote:
> On Fri, 2015-07-10 at 11:44 -0500, Aníbal Limón wrote:
>> When found an anonymous function the func name is made by filename
>> and lineno, the filename need to be converted to string before using
>> translation because produces an error of encoding.
> Could you explain a little about why we don't hit this error in general?
>
> Cheers,
>
> Richard
>

Re: [PATCH] parse/ast.py: MethodNode fix character mapping error

[Christopher Larson]

[-- Attachment #1: Type: text/plain, Size: 1270 bytes --]

%s already converts the arguments to strings, last I checked. Am I missing
someting here?

On Fri, Jul 10, 2015 at 1:16 PM, Aníbal Limón <anibal.limon@linux.intel.com>
wrote:

> Hi Richard,
>
> Sorry it was my mistake in my code because i'm loading a recipe file using
> bb.cache.Cache.loadDataFull
> passing an unicode filepath this causes the error but i think it need to
> be sanitized? to avoid this kind of
> problems.
>
> Cheers,
>     alimon
>
>
> On 10/07/15 11:55, Richard Purdie wrote:
>
>> On Fri, 2015-07-10 at 11:44 -0500, Aníbal Limón wrote:
>>
>>> When found an anonymous function the func name is made by filename
>>> and lineno, the filename need to be converted to string before using
>>> translation because produces an error of encoding.
>>>
>> Could you explain a little about why we don't hit this error in general?
>>
>> Cheers,
>>
>> Richard
>>
>>
> --
> _______________________________________________
> bitbake-devel mailing list
> bitbake-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/bitbake-devel
>



-- 
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics

[-- Attachment #2: Type: text/html, Size: 2141 bytes --]