All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Heiko Stuebner <heiko@sntech.de>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Peter Meerwald <pmeerw@pmeerw.net>,
	linux-iio@vger.kernel.org, linux-rockchip@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND] iio: adc: rockchip_saradc: add missing MODULE_* data
Date: Sat, 11 Jul 2015 18:32:42 +0100	[thread overview]
Message-ID: <55A1533A.2080507@kernel.org> (raw)
In-Reply-To: <8215730.uluDfnE1h7@diego>

On 08/07/15 15:17, Heiko Stuebner wrote:
> The module-data is currently missing. This includes the license-information
> which makes the driver taint the kernel and miss symbols when compiled as
> module.
> 
> Fixes: 44d6f2ef94f9 ("iio: adc: add driver for Rockchip saradc")
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Sorry Heiko,

Not entirely sure why I haven't picked this up before.

Anyhow, now applied to the fixes-for-4.2 branch of iio.git
and marked for stable.  I need to catch up with a bit of a
backlog, but should get a pull request out to Greg sometime
early next week.

Jonathan
> ---
>  drivers/iio/adc/rockchip_saradc.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/iio/adc/rockchip_saradc.c b/drivers/iio/adc/rockchip_saradc.c
> index 8d4e019..9c311c1 100644
> --- a/drivers/iio/adc/rockchip_saradc.c
> +++ b/drivers/iio/adc/rockchip_saradc.c
> @@ -349,3 +349,7 @@ static struct platform_driver rockchip_saradc_driver = {
>  };
>  
>  module_platform_driver(rockchip_saradc_driver);
> +
> +MODULE_AUTHOR("Heiko Stuebner <heiko@sntech.de>");
> +MODULE_DESCRIPTION("Rockchip SARADC driver");
> +MODULE_LICENSE("GPL v2");
> 


WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
Cc: Hartmut Knaack <knaack.h-Mmb7MZpHnFY@public.gmane.org>,
	Lars-Peter Clausen <lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>,
	Peter Meerwald <pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org>,
	linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH RESEND] iio: adc: rockchip_saradc: add missing MODULE_* data
Date: Sat, 11 Jul 2015 18:32:42 +0100	[thread overview]
Message-ID: <55A1533A.2080507@kernel.org> (raw)
In-Reply-To: <8215730.uluDfnE1h7@diego>

On 08/07/15 15:17, Heiko Stuebner wrote:
> The module-data is currently missing. This includes the license-information
> which makes the driver taint the kernel and miss symbols when compiled as
> module.
> 
> Fixes: 44d6f2ef94f9 ("iio: adc: add driver for Rockchip saradc")
> Signed-off-by: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
Sorry Heiko,

Not entirely sure why I haven't picked this up before.

Anyhow, now applied to the fixes-for-4.2 branch of iio.git
and marked for stable.  I need to catch up with a bit of a
backlog, but should get a pull request out to Greg sometime
early next week.

Jonathan
> ---
>  drivers/iio/adc/rockchip_saradc.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/iio/adc/rockchip_saradc.c b/drivers/iio/adc/rockchip_saradc.c
> index 8d4e019..9c311c1 100644
> --- a/drivers/iio/adc/rockchip_saradc.c
> +++ b/drivers/iio/adc/rockchip_saradc.c
> @@ -349,3 +349,7 @@ static struct platform_driver rockchip_saradc_driver = {
>  };
>  
>  module_platform_driver(rockchip_saradc_driver);
> +
> +MODULE_AUTHOR("Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>");
> +MODULE_DESCRIPTION("Rockchip SARADC driver");
> +MODULE_LICENSE("GPL v2");
> 

  reply	other threads:[~2015-07-11 17:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-08 14:17 [PATCH RESEND] iio: adc: rockchip_saradc: add missing MODULE_* data Heiko Stuebner
2015-07-08 14:17 ` Heiko Stuebner
2015-07-11 17:32 ` Jonathan Cameron [this message]
2015-07-11 17:32   ` Jonathan Cameron
2015-07-11 18:59   ` Heiko Stübner
2015-07-11 18:59     ` Heiko Stübner
2015-07-13  9:23     ` Jonathan Cameron
2015-07-13  9:23       ` Jonathan Cameron
2015-07-13 20:52       ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55A1533A.2080507@kernel.org \
    --to=jic23@kernel.org \
    --cc=heiko@sntech.de \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.