Re: [Qemu-devel] Semantics of tcg_enabled() and what it means for multi-arch

[Paolo Bonzini <pbonzini@redhat.com>]

On 11/07/2015 22:46, Peter Crosthwaite wrote:
> include/exec/ram_addr.h:                if (tcg_enabled()) {
> include/exec/ram_addr.h:        uint8_t clients = tcg_enabled() ?
> DIRTY_CLIENTS_ALL : DIRTY_CLIENTS_NOCODE;
> memory.c:    mr->dirty_log_mask = tcg_enabled() ? (1 << DIRTY_MEMORY_CODE) : 0;
> memory.c:    mr->dirty_log_mask = tcg_enabled() ? (1 << DIRTY_MEMORY_CODE) : 0;
> memory.c:    mr->dirty_log_mask = tcg_enabled() ? (1 << DIRTY_MEMORY_CODE) : 0;
> memory.c:    mr->dirty_log_mask = tcg_enabled() ? (1 << DIRTY_MEMORY_CODE) : 0;
> 
> So what is the correct logic for populating dirty_log_mask and friends
> when there are 0. 1, or more TCG engines?

I think it should be set if there's at least one TCG engine.

Have you checked BTW it the DIRTY_MEMORY_CODE stuff works with multiple
tcg_ctxs _and_ the same page hosts code for more than one CPU type?
Offhand I have no idea of the answer...

Paolo