All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>,
	Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
	QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-trivial] [PATCH] virtio-input: enable on non-linux hosts
Date: Mon, 13 Jul 2015 14:17:08 +0200	[thread overview]
Message-ID: <55A3AC44.9070705@redhat.com> (raw)
In-Reply-To: <1436788900.26533.25.camel@redhat.com>



On 13/07/2015 14:01, Gerd Hoffmann wrote:
>> > 
>> > Did a build test on freebsd -- passed.
> Oops, the windows cross builds fails though (due to
> include/standard-headers/linux/input.h including sys/ioctl.h).
> 
> Ok, scratch that one, back to the drawing board ...

The sys/ioctl.h include doesn't seem too useful.  This patch compiles:

diff --git a/hw/input/virtio-input-host.c b/hw/input/virtio-input-host.c
index f7e3d84..3feecfd 100644
--- a/hw/input/virtio-input-host.c
+++ b/hw/input/virtio-input-host.c
@@ -12,6 +12,7 @@
 #include "hw/virtio/virtio-input.h"

 #include "standard-headers/linux/input.h"
+#include <sys/ioctl.h>

 /* ----------------------------------------------------------------- */

diff --git a/include/standard-headers/linux/input.h
b/include/standard-headers/linux/input.h
index a459dd2..b003c67 100644
--- a/include/standard-headers/linux/input.h
+++ b/include/standard-headers/linux/input.h
@@ -10,7 +10,6 @@


 #include <sys/time.h>
-#include <sys/ioctl.h>
 #include <sys/types.h>
 #include "standard-headers/linux/types.h"


Perhaps we can drop the include in scripts/update-linux-headers.sh?

Paolo


WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>,
	Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
	QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] virtio-input: enable on non-linux hosts
Date: Mon, 13 Jul 2015 14:17:08 +0200	[thread overview]
Message-ID: <55A3AC44.9070705@redhat.com> (raw)
In-Reply-To: <1436788900.26533.25.camel@redhat.com>



On 13/07/2015 14:01, Gerd Hoffmann wrote:
>> > 
>> > Did a build test on freebsd -- passed.
> Oops, the windows cross builds fails though (due to
> include/standard-headers/linux/input.h including sys/ioctl.h).
> 
> Ok, scratch that one, back to the drawing board ...

The sys/ioctl.h include doesn't seem too useful.  This patch compiles:

diff --git a/hw/input/virtio-input-host.c b/hw/input/virtio-input-host.c
index f7e3d84..3feecfd 100644
--- a/hw/input/virtio-input-host.c
+++ b/hw/input/virtio-input-host.c
@@ -12,6 +12,7 @@
 #include "hw/virtio/virtio-input.h"

 #include "standard-headers/linux/input.h"
+#include <sys/ioctl.h>

 /* ----------------------------------------------------------------- */

diff --git a/include/standard-headers/linux/input.h
b/include/standard-headers/linux/input.h
index a459dd2..b003c67 100644
--- a/include/standard-headers/linux/input.h
+++ b/include/standard-headers/linux/input.h
@@ -10,7 +10,6 @@


 #include <sys/time.h>
-#include <sys/ioctl.h>
 #include <sys/types.h>
 #include "standard-headers/linux/types.h"


Perhaps we can drop the include in scripts/update-linux-headers.sh?

Paolo

  reply	other threads:[~2015-07-13 12:17 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-13  7:30 [Qemu-trivial] [PATCH] virtio-input: enable on non-linux hosts Gerd Hoffmann
2015-07-13  7:30 ` [Qemu-devel] " Gerd Hoffmann
2015-07-13  8:56 ` [Qemu-trivial] " Peter Maydell
2015-07-13  8:56   ` Peter Maydell
2015-07-13 11:48   ` [Qemu-trivial] " Gerd Hoffmann
2015-07-13 11:48     ` Gerd Hoffmann
2015-07-13 12:01     ` [Qemu-trivial] " Gerd Hoffmann
2015-07-13 12:01       ` Gerd Hoffmann
2015-07-13 12:17       ` Paolo Bonzini [this message]
2015-07-13 12:17         ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55A3AC44.9070705@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.