From: Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com>
To: dwalker@fifo99.com, "Eric W. Biederman" <ebiederm@xmission.com>
Cc: linux-mips@linux-mips.org, Baoquan He <bhe@redhat.com>,
linux-s390@vger.kernel.org, linux-sh@vger.kernel.org,
kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-metag@vger.kernel.org,
HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com>,
linux-arm-kernel@lists.infradead.org,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
Andrew Morton <akpm@linux-foundation.org>,
linuxppc-dev@lists.ozlabs.org, Ingo Molnar <mingo@kernel.org>,
Vivek Goyal <vgoyal@redhat.com>
Subject: Re: [PATCH 1/3] panic: Disable crash_kexec_post_notifiers if kdump is not available
Date: Tue, 14 Jul 2015 10:56:13 +0900 [thread overview]
Message-ID: <55A46C3D.7000208@hitachi.com> (raw)
In-Reply-To: <20150713202611.GA16525@fifo99.com>
Hello Eric and Daniel,
(2015/07/14 5:26), dwalker@fifo99.com wrote:
> On Fri, Jul 10, 2015 at 08:41:28AM -0500, Eric W. Biederman wrote:
>> Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com> writes:
>>
>>> You can call panic notifiers and kmsg dumpers before kdump by
>>> specifying "crash_kexec_post_notifiers" as a boot parameter.
>>> However, it doesn't make sense if kdump is not available. In that
>>> case, disable "crash_kexec_post_notifiers" boot parameter so that
>>> you can't change the value of the parameter.
>>
>> Nacked-by: "Eric W. Biederman" <ebiederm@xmission.com>
>>
>> You are confusing kexec on panic and CONFIG_CRASH_DUMP
>> which is about the tools for reading the state of the previous kernel.
You are right. I mistook the meaning of CONFIG_CRASH_DUMP.
> I think it would make sense if he just replaced "kdump" with "kexec".
If a user specified crash_kexec_post_notifiers option with kexec
being totally disabled, it just disables notifier and kmsg dumper calls
(please see PATCH 3/3). So as Daniel said, I also think it makes sense
to hide crash_kexec_post_notifiers option if kexec is disabled.
Regards,
--
Hidehiro Kawai
Hitachi, Ltd. Research & Development Group
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
WARNING: multiple messages have this Message-ID (diff)
From: Hidehiro Kawai <hidehiro.kawai.ez-FCd8Q96Dh0JBDgjK7y7TUQ@public.gmane.org>
To: dwalker-zu3NM2574RrQT0dZR+AlfA@public.gmane.org,
"Eric W. Biederman"
<ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
Cc: Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
Vivek Goyal <vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org,
Baoquan He <bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-s390-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Ingo Molnar <mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
HATAYAMA Daisuke
<d.hatayama-+CUm20s59erQFUHtdCDX3A@public.gmane.org>,
Masami Hiramatsu
<masami.hiramatsu.pt-FCd8Q96Dh0JBDgjK7y7TUQ@public.gmane.org>,
linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
linux-metag-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 1/3] panic: Disable crash_kexec_post_notifiers if kdump is not available
Date: Tue, 14 Jul 2015 10:56:13 +0900 [thread overview]
Message-ID: <55A46C3D.7000208@hitachi.com> (raw)
In-Reply-To: <20150713202611.GA16525-zu3NM2574RrQT0dZR+AlfA@public.gmane.org>
Hello Eric and Daniel,
(2015/07/14 5:26), dwalker-zu3NM2574RrQT0dZR+AlfA@public.gmane.org wrote:
> On Fri, Jul 10, 2015 at 08:41:28AM -0500, Eric W. Biederman wrote:
>> Hidehiro Kawai <hidehiro.kawai.ez-FCd8Q96Dh0JBDgjK7y7TUQ@public.gmane.org> writes:
>>
>>> You can call panic notifiers and kmsg dumpers before kdump by
>>> specifying "crash_kexec_post_notifiers" as a boot parameter.
>>> However, it doesn't make sense if kdump is not available. In that
>>> case, disable "crash_kexec_post_notifiers" boot parameter so that
>>> you can't change the value of the parameter.
>>
>> Nacked-by: "Eric W. Biederman" <ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
>>
>> You are confusing kexec on panic and CONFIG_CRASH_DUMP
>> which is about the tools for reading the state of the previous kernel.
You are right. I mistook the meaning of CONFIG_CRASH_DUMP.
> I think it would make sense if he just replaced "kdump" with "kexec".
If a user specified crash_kexec_post_notifiers option with kexec
being totally disabled, it just disables notifier and kmsg dumper calls
(please see PATCH 3/3). So as Daniel said, I also think it makes sense
to hide crash_kexec_post_notifiers option if kexec is disabled.
Regards,
--
Hidehiro Kawai
Hitachi, Ltd. Research & Development Group
WARNING: multiple messages have this Message-ID (diff)
From: Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com>
To: dwalker@fifo99.com, "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Vivek Goyal <vgoyal@redhat.com>,
linux-mips@linux-mips.org, Baoquan He <bhe@redhat.com>,
linux-sh@vger.kernel.org, linux-s390@vger.kernel.org,
kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
Ingo Molnar <mingo@kernel.org>,
HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
linuxppc-dev@lists.ozlabs.org, linux-metag@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] panic: Disable crash_kexec_post_notifiers if kdump is not available
Date: Tue, 14 Jul 2015 10:56:13 +0900 [thread overview]
Message-ID: <55A46C3D.7000208@hitachi.com> (raw)
In-Reply-To: <20150713202611.GA16525@fifo99.com>
Hello Eric and Daniel,
(2015/07/14 5:26), dwalker@fifo99.com wrote:
> On Fri, Jul 10, 2015 at 08:41:28AM -0500, Eric W. Biederman wrote:
>> Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com> writes:
>>
>>> You can call panic notifiers and kmsg dumpers before kdump by
>>> specifying "crash_kexec_post_notifiers" as a boot parameter.
>>> However, it doesn't make sense if kdump is not available. In that
>>> case, disable "crash_kexec_post_notifiers" boot parameter so that
>>> you can't change the value of the parameter.
>>
>> Nacked-by: "Eric W. Biederman" <ebiederm@xmission.com>
>>
>> You are confusing kexec on panic and CONFIG_CRASH_DUMP
>> which is about the tools for reading the state of the previous kernel.
You are right. I mistook the meaning of CONFIG_CRASH_DUMP.
> I think it would make sense if he just replaced "kdump" with "kexec".
If a user specified crash_kexec_post_notifiers option with kexec
being totally disabled, it just disables notifier and kmsg dumper calls
(please see PATCH 3/3). So as Daniel said, I also think it makes sense
to hide crash_kexec_post_notifiers option if kexec is disabled.
Regards,
--
Hidehiro Kawai
Hitachi, Ltd. Research & Development Group
WARNING: multiple messages have this Message-ID (diff)
From: Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] panic: Disable crash_kexec_post_notifiers if kdump is not available
Date: Tue, 14 Jul 2015 01:56:13 +0000 [thread overview]
Message-ID: <55A46C3D.7000208@hitachi.com> (raw)
In-Reply-To: <20150713202611.GA16525@fifo99.com>
Hello Eric and Daniel,
(2015/07/14 5:26), dwalker@fifo99.com wrote:
> On Fri, Jul 10, 2015 at 08:41:28AM -0500, Eric W. Biederman wrote:
>> Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com> writes:
>>
>>> You can call panic notifiers and kmsg dumpers before kdump by
>>> specifying "crash_kexec_post_notifiers" as a boot parameter.
>>> However, it doesn't make sense if kdump is not available. In that
>>> case, disable "crash_kexec_post_notifiers" boot parameter so that
>>> you can't change the value of the parameter.
>>
>> Nacked-by: "Eric W. Biederman" <ebiederm@xmission.com>
>>
>> You are confusing kexec on panic and CONFIG_CRASH_DUMP
>> which is about the tools for reading the state of the previous kernel.
You are right. I mistook the meaning of CONFIG_CRASH_DUMP.
> I think it would make sense if he just replaced "kdump" with "kexec".
If a user specified crash_kexec_post_notifiers option with kexec
being totally disabled, it just disables notifier and kmsg dumper calls
(please see PATCH 3/3). So as Daniel said, I also think it makes sense
to hide crash_kexec_post_notifiers option if kexec is disabled.
Regards,
--
Hidehiro Kawai
Hitachi, Ltd. Research & Development Group
WARNING: multiple messages have this Message-ID (diff)
From: hidehiro.kawai.ez@hitachi.com (Hidehiro Kawai)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] panic: Disable crash_kexec_post_notifiers if kdump is not available
Date: Tue, 14 Jul 2015 10:56:13 +0900 [thread overview]
Message-ID: <55A46C3D.7000208@hitachi.com> (raw)
In-Reply-To: <20150713202611.GA16525@fifo99.com>
Hello Eric and Daniel,
(2015/07/14 5:26), dwalker at fifo99.com wrote:
> On Fri, Jul 10, 2015 at 08:41:28AM -0500, Eric W. Biederman wrote:
>> Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com> writes:
>>
>>> You can call panic notifiers and kmsg dumpers before kdump by
>>> specifying "crash_kexec_post_notifiers" as a boot parameter.
>>> However, it doesn't make sense if kdump is not available. In that
>>> case, disable "crash_kexec_post_notifiers" boot parameter so that
>>> you can't change the value of the parameter.
>>
>> Nacked-by: "Eric W. Biederman" <ebiederm@xmission.com>
>>
>> You are confusing kexec on panic and CONFIG_CRASH_DUMP
>> which is about the tools for reading the state of the previous kernel.
You are right. I mistook the meaning of CONFIG_CRASH_DUMP.
> I think it would make sense if he just replaced "kdump" with "kexec".
If a user specified crash_kexec_post_notifiers option with kexec
being totally disabled, it just disables notifier and kmsg dumper calls
(please see PATCH 3/3). So as Daniel said, I also think it makes sense
to hide crash_kexec_post_notifiers option if kexec is disabled.
Regards,
--
Hidehiro Kawai
Hitachi, Ltd. Research & Development Group
next prev parent reply other threads:[~2015-07-14 1:56 UTC|newest]
Thread overview: 105+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-10 11:33 [PATCH 0/3] kexec: crash_kexec_post_notifiers boot option related fixes Hidehiro Kawai
2015-07-10 11:33 ` Hidehiro Kawai
2015-07-10 11:33 ` Hidehiro Kawai
2015-07-10 11:33 ` Hidehiro Kawai
2015-07-10 11:33 ` [PATCH 1/3] panic: Disable crash_kexec_post_notifiers if kdump is not available Hidehiro Kawai
2015-07-10 11:33 ` Hidehiro Kawai
2015-07-10 11:33 ` Hidehiro Kawai
2015-07-10 11:33 ` Hidehiro Kawai
2015-07-10 13:41 ` Eric W. Biederman
2015-07-10 13:41 ` Eric W. Biederman
2015-07-10 13:41 ` Eric W. Biederman
2015-07-10 13:41 ` Eric W. Biederman
2015-07-10 13:41 ` Eric W. Biederman
2015-07-13 20:26 ` dwalker
2015-07-13 20:26 ` dwalker at fifo99.com
2015-07-13 20:26 ` dwalker
2015-07-13 20:26 ` dwalker
2015-07-14 1:19 ` Eric W. Biederman
2015-07-14 1:19 ` Eric W. Biederman
2015-07-14 1:19 ` Eric W. Biederman
2015-07-14 1:19 ` Eric W. Biederman
2015-07-14 13:59 ` dwalker
2015-07-14 13:59 ` dwalker at fifo99.com
2015-07-14 13:59 ` dwalker
2015-07-14 13:59 ` dwalker
2015-07-14 13:59 ` dwalker-zu3NM2574RrQT0dZR+AlfA
2015-07-14 14:20 ` Vivek Goyal
2015-07-14 14:20 ` Vivek Goyal
2015-07-14 14:20 ` Vivek Goyal
2015-07-14 14:20 ` Vivek Goyal
2015-07-14 14:20 ` Vivek Goyal
2015-07-14 15:02 ` Vivek Goyal
2015-07-14 15:02 ` Vivek Goyal
2015-07-14 15:02 ` Vivek Goyal
2015-07-14 15:02 ` Vivek Goyal
2015-07-14 15:34 ` dwalker
2015-07-14 15:34 ` dwalker at fifo99.com
2015-07-14 15:34 ` dwalker
2015-07-14 15:34 ` dwalker
2015-07-14 15:40 ` Vivek Goyal
2015-07-14 15:40 ` Vivek Goyal
2015-07-14 15:40 ` Vivek Goyal
2015-07-14 15:40 ` Vivek Goyal
2015-07-14 15:48 ` dwalker
2015-07-14 15:48 ` dwalker at fifo99.com
2015-07-14 15:48 ` dwalker
2015-07-14 15:48 ` dwalker
2015-07-14 16:16 ` Vivek Goyal
2015-07-14 16:16 ` Vivek Goyal
2015-07-14 16:16 ` Vivek Goyal
2015-07-14 16:16 ` Vivek Goyal
2015-07-14 16:16 ` Vivek Goyal
2015-07-14 17:06 ` Eric W. Biederman
2015-07-14 17:06 ` Eric W. Biederman
2015-07-14 17:06 ` Eric W. Biederman
2015-07-14 17:06 ` Eric W. Biederman
2015-07-14 17:06 ` Eric W. Biederman
2015-07-14 17:29 ` dwalker
2015-07-14 17:29 ` dwalker at fifo99.com
2015-07-14 17:29 ` dwalker
2015-07-14 17:29 ` dwalker
2015-07-14 17:55 ` Vivek Goyal
2015-07-14 17:55 ` Vivek Goyal
2015-07-14 17:55 ` Vivek Goyal
2015-07-14 17:55 ` Vivek Goyal
2015-07-14 17:55 ` Vivek Goyal
2015-07-14 18:01 ` Eric W. Biederman
2015-07-14 18:01 ` Eric W. Biederman
2015-07-14 18:01 ` Eric W. Biederman
2015-07-14 18:01 ` Eric W. Biederman
2015-07-14 18:23 ` Vivek Goyal
2015-07-14 18:23 ` Vivek Goyal
2015-07-14 18:23 ` Vivek Goyal
2015-07-14 18:23 ` Vivek Goyal
2015-07-14 18:23 ` Vivek Goyal
2015-07-15 5:16 ` Masami Hiramatsu
2015-07-15 5:16 ` Masami Hiramatsu
2015-07-15 5:16 ` Masami Hiramatsu
2015-07-15 5:16 ` Masami Hiramatsu
2015-07-15 10:49 ` Hidehiro Kawai
2015-07-15 10:49 ` Hidehiro Kawai
2015-07-15 10:49 ` Hidehiro Kawai
2015-07-15 10:49 ` Hidehiro Kawai
2015-07-15 10:49 ` Hidehiro Kawai
2015-07-14 1:56 ` Hidehiro Kawai [this message]
2015-07-14 1:56 ` Hidehiro Kawai
2015-07-14 1:56 ` Hidehiro Kawai
2015-07-14 1:56 ` Hidehiro Kawai
2015-07-14 1:56 ` Hidehiro Kawai
2015-07-10 11:33 ` [PATCH 3/3] kexec: Change the timing of callbacks related to "crash_kexec_post_notifiers" boot option Hidehiro Kawai
2015-07-10 11:33 ` Hidehiro Kawai
2015-07-10 11:33 ` [PATCH 3/3] kexec: Change the timing of callbacks related to "crash_kexec_post_notifiers" boot optio Hidehiro Kawai
2015-07-10 11:33 ` [PATCH 3/3] kexec: Change the timing of callbacks related to "crash_kexec_post_notifiers" boot option Hidehiro Kawai
2015-07-14 14:42 ` Vivek Goyal
2015-07-14 14:42 ` Vivek Goyal
2015-07-14 14:42 ` [PATCH 3/3] kexec: Change the timing of callbacks related to "crash_kexec_post_notifiers" boot o Vivek Goyal
2015-07-14 14:42 ` [PATCH 3/3] kexec: Change the timing of callbacks related to "crash_kexec_post_notifiers" boot option Vivek Goyal
2015-07-15 3:09 ` Masami Hiramatsu
2015-07-15 3:09 ` Masami Hiramatsu
2015-07-15 3:09 ` Re: [PATCH 3/3] kexec: Change the timing of callbacks related to "crash_kexec_post_notifiers" bo Masami Hiramatsu
2015-07-15 3:09 ` Re: [PATCH 3/3] kexec: Change the timing of callbacks related to "crash_kexec_post_notifiers" boot option Masami Hiramatsu
2015-07-10 11:33 ` [PATCH 2/3] kexec: Pass panic message to crash_kexec() Hidehiro Kawai
2015-07-10 11:33 ` Hidehiro Kawai
2015-07-10 11:33 ` Hidehiro Kawai
2015-07-10 11:33 ` Hidehiro Kawai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A46C3D.7000208@hitachi.com \
--to=hidehiro.kawai.ez@hitachi.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=d.hatayama@jp.fujitsu.com \
--cc=dwalker@fifo99.com \
--cc=ebiederm@xmission.com \
--cc=kexec@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-metag@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@kernel.org \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.