From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Javier Martinez Canillas <javier@osg.samsung.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-samsung-soc@vger.kernel.org, Jiri Slaby <jslaby@suse.cz>,
Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org, Kukjin Kim <kgene@kernel.org>,
linux-serial@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] serial: samsung: Remove redundant DEBUG_LL check
Date: Tue, 14 Jul 2015 10:56:31 +0900 [thread overview]
Message-ID: <55A46C4F.8050803@samsung.com> (raw)
In-Reply-To: <1436786331-5188-1-git-send-email-javier@osg.samsung.com>
On 13.07.2015 20:18, Javier Martinez Canillas wrote:
> Commit 84f57d9e3685 ("tty: serial/samsung: fix modular build") fixed
> build issues when the driver was built as a module. One of those was
> that printascii is only accessible when the driver is built-in.
>
> But there is no need to check for defined(CONFIG_DEBUG_LL) since the
> SERIAL_SAMSUNG_DEBUG Kconfig symbol already depends on DEBUG_LL.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
> ---
>
> drivers/tty/serial/samsung.c | 1 -
> 1 file changed, 1 deletion(-)
Although this redundancy is not harmful the patch seems fine, so:
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: k.kozlowski@samsung.com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] serial: samsung: Remove redundant DEBUG_LL check
Date: Tue, 14 Jul 2015 10:56:31 +0900 [thread overview]
Message-ID: <55A46C4F.8050803@samsung.com> (raw)
In-Reply-To: <1436786331-5188-1-git-send-email-javier@osg.samsung.com>
On 13.07.2015 20:18, Javier Martinez Canillas wrote:
> Commit 84f57d9e3685 ("tty: serial/samsung: fix modular build") fixed
> build issues when the driver was built as a module. One of those was
> that printascii is only accessible when the driver is built-in.
>
> But there is no need to check for defined(CONFIG_DEBUG_LL) since the
> SERIAL_SAMSUNG_DEBUG Kconfig symbol already depends on DEBUG_LL.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
> ---
>
> drivers/tty/serial/samsung.c | 1 -
> 1 file changed, 1 deletion(-)
Although this redundancy is not harmful the patch seems fine, so:
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Best regards,
Krzysztof
next prev parent reply other threads:[~2015-07-14 1:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-13 11:18 [PATCH] serial: samsung: Remove redundant DEBUG_LL check Javier Martinez Canillas
2015-07-13 11:18 ` Javier Martinez Canillas
2015-07-14 1:56 ` Krzysztof Kozlowski [this message]
2015-07-14 1:56 ` Krzysztof Kozlowski
2015-07-14 4:41 ` Kukjin Kim
2015-07-14 4:41 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A46C4F.8050803@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=javier@osg.samsung.com \
--cc=jslaby@suse.cz \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.