Re: [PATCH 1/3] ARM: multi_v7_defconfig: Enable max77802 regulator

[Krzysztof Kozlowski <k.kozlowski@samsung.com>]

On 16.07.2015 14:44, Javier Martinez Canillas wrote:
> Hello Krzysztof,
> 
> Thanks for the feedback.
> 
> On 07/16/2015 02:45 AM, Krzysztof Kozlowski wrote:
>> On 16.07.2015 01:32, Javier Martinez Canillas wrote:
>>> The Maxim max77802 Power Management IC has besides other devices, a set of
>>> regulators. Commit f3caa529c6f5 ("ARM: multi_v7_defconfig: Enable max77802
>>> regulator, rtc and clock drivers") was supposed to enable the config option
>>> for the regulator driver as a module but the final version that landed did
>>> not include this. So this patch enables the needed Kconfig option.
>>>
>>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>>
>> Please describe why do you want to enable it (IOW who will benefit from
>> enabling it?). This symbol was removed by Kukjin from your commit:
>> 	[kgene@kernel.org: removing useless REGULATOR_MAX77802 config]
>> so justification would be welcomed.
>>
> 
> You are right, sorry for not making the commit message clear. This PMIC
> is used by a couple of Exynos5 based boars such as the Peach Pit and Pi
> Chromebooks. I expect it to be found in other designs too just like the
> max77686 is found in many Exynos5 based boards.
> 
> I'll add this to the commit message on v2.
>  
>> Beside the commit description I agree with the patch.
>>
> 
> Does this mean I can add your Reviewed-by to this patch as well?

With extended description (something similar to explanation in your
other patches) yes, go ahead:

Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Best regards,
Krzysztof