From: Richard Henderson <rth@twiddle.net>
To: Aurelien Jarno <aurelien@aurel32.net>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH RFC 8/9] tcg/optimize: do not simplify size changing moves
Date: Fri, 17 Jul 2015 07:38:03 +0100 [thread overview]
Message-ID: <55A8A2CB.70001@twiddle.net> (raw)
In-Reply-To: <1436958199-5181-9-git-send-email-aurelien@aurel32.net>
On 07/15/2015 12:03 PM, Aurelien Jarno wrote:
> Now that we have real size changing ops, we don't need to marked high
> bits of the destination as garbage. The goal of the optimizer is to
> predict the value of the temps (and not of the registers) and do
> simplifications when possible. The problem there is therefore not the
> fact that those bits are not counted as garbage, but that a size
> changing op is replaced by a move.
>
> This patch is basically a revert of 24666baf, including the changes that
> have been made since then.
>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Richard Henderson <rth@twiddle.net>
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
What we're missing here is whether the omitted size changing op is extu or
exts. Mask should be extended to match. Which means keeping most of this code.
r~
next prev parent reply other threads:[~2015-07-17 6:38 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-15 11:03 [Qemu-devel] [PATCH RFC 0/9] tcg: improve size changing ops Aurelien Jarno
2015-07-15 11:03 ` [Qemu-devel] [PATCH RFC 1/9] tcg: rename trunc_shr_i32 into trunc_shr_i64_i32 Aurelien Jarno
2015-07-17 6:14 ` Richard Henderson
2015-07-15 11:03 ` [Qemu-devel] [PATCH RFC 2/9] tcg: don't abuse TCG type in tcg_gen_trunc_shr_i64_i32 Aurelien Jarno
2015-07-17 6:14 ` Richard Henderson
2015-07-15 11:03 ` [Qemu-devel] [PATCH RFC 3/9] tcg: implement real ext_i32_i64 and extu_i32_i64 ops Aurelien Jarno
2015-07-17 6:19 ` Richard Henderson
2015-07-15 11:03 ` [Qemu-devel] [PATCH RFC 4/9] tcg/optimize: add optimizations for " Aurelien Jarno
2015-07-17 6:23 ` Richard Henderson
2015-07-15 11:03 ` [Qemu-devel] [PATCH RFC 5/9] tcg/i386: implement " Aurelien Jarno
2015-07-15 11:03 ` [Qemu-devel] [PATCH RFC 6/9] tcg/i386: document the way 32/64-bit conversions are handled Aurelien Jarno
2015-07-15 11:03 ` [Qemu-devel] [PATCH RFC 7/9] tcg: replace ext/u_i32_i64 by a mov when not implemented Aurelien Jarno
2015-07-17 6:30 ` Richard Henderson
2015-07-15 11:03 ` [Qemu-devel] [PATCH RFC 8/9] tcg/optimize: do not simplify size changing moves Aurelien Jarno
2015-07-17 6:38 ` Richard Henderson [this message]
2015-07-17 10:33 ` Aurelien Jarno
2015-07-18 7:24 ` Richard Henderson
2015-07-18 21:19 ` Aurelien Jarno
2015-07-15 11:03 ` [Qemu-devel] [PATCH RFC 9/9] tcg: update README about size changing ops Aurelien Jarno
2015-07-17 6:42 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A8A2CB.70001@twiddle.net \
--to=rth@twiddle.net \
--cc=aurelien@aurel32.net \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.