Re: [meta-oe][PATCH] fio: Add PACKAGECONFIG for numa, re-enable ARM build

["Dominic Sacré" <dominic.sacre@gmx.de>]

Hi Andre,

On 2015-07-17 02:46, Andre McCurdy wrote:
>> +PACKAGECONFIG[numa] = ",--disable-numa,numactl"
> 
> I don't think this change will work.
> 
> The fio recipe doesn't use autotools, so the --disable-numa option set
> via PACKAGECONFIG isn't going to have any effect unless you also
> manually pass EXTRA_OECONF into the build somehow.

Ouch, you're right. The configure script is currently only called
indirectly (from the Makefile) and without arguments during do_compile.

How about adding this simple do_configure function?

do_configure() {
    ${B}/configure ${EXTRA_OECONF}
}

>>  # ARM does not currently support NUMA
>> -COMPATIBLE_HOST = "^((?!arm).*)$"
>> +PACKAGECONFIG_remove_arm = "numa"
> 
> In general, it would be better to use something like:
> 
>   PACKAGECONFIG_NUMA = "numa"
>   PACKAGECONFIG_NUMA_arm = ""
> 
>   PACKAGECONFIG ??= "${PACKAGECONFIG_NUMA}"
> 
> _remove can be a little difficult to 'over-ride', so makes things
> harder if someone did, one day, want to experiment with enabling that
> option from local.conf or a .bbappend.

Good point. I thought the _remove was ugly, but it didn't occur to me to
use an additional level of indirection like this.


Dominic