All of lore.kernel.org
 help / color / mirror / Atom feed
From: hdegoede@redhat.com (Hans de Goede)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 1/4] phy-sun4i-usb: Add missing EXPORT_SYMBOL for sun4i_usb_phy_set_squelch_detect
Date: Sun, 19 Jul 2015 12:58:52 +0200	[thread overview]
Message-ID: <55AB82EC.7050309@redhat.com> (raw)
In-Reply-To: <55A653AF.608@ti.com>

Hi,

On 15-07-15 14:35, Kishon Vijay Abraham I wrote:
> Hi,
>
> On Wednesday 08 July 2015 08:11 PM, Hans de Goede wrote:
>> sun4i_usb_phy_set_squelch_detect is used by other code, which may be built
>> as a module, so it should be exported.
>>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>> ---
>> Changes in v6:
>> -New patch in v6 of the sunxi musb support series
>> ---
>>   drivers/phy/phy-sun4i-usb.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/phy/phy-sun4i-usb.c b/drivers/phy/phy-sun4i-usb.c
>> index e17c539..b82aa26 100644
>> --- a/drivers/phy/phy-sun4i-usb.c
>> +++ b/drivers/phy/phy-sun4i-usb.c
>> @@ -212,6 +212,7 @@ void sun4i_usb_phy_set_squelch_detect(struct phy *_phy, bool enabled)
>>
>>   	sun4i_usb_phy_write(phy, PHY_SQUELCH_DETECT, enabled ? 0 : 2, 2);
>>   }
>> +EXPORT_SYMBOL(sun4i_usb_phy_set_squelch_detect);
>
> EXPORT_SYMBOL_GPL?

Both work for me, feel free to fix this up if you prefer _GPL.

Regards,

Hans

WARNING: multiple messages have this Message-ID (diff)
From: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Kishon Vijay Abraham I <kishon-l0cyMroinI0@public.gmane.org>,
	Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>
Cc: Chanwoo Choi <cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
	Maxime Ripard
	<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
	Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
	Roman Byshko <rbyshko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
Subject: Re: [PATCH v6 1/4] phy-sun4i-usb: Add missing EXPORT_SYMBOL for sun4i_usb_phy_set_squelch_detect
Date: Sun, 19 Jul 2015 12:58:52 +0200	[thread overview]
Message-ID: <55AB82EC.7050309@redhat.com> (raw)
In-Reply-To: <55A653AF.608-l0cyMroinI0@public.gmane.org>

Hi,

On 15-07-15 14:35, Kishon Vijay Abraham I wrote:
> Hi,
>
> On Wednesday 08 July 2015 08:11 PM, Hans de Goede wrote:
>> sun4i_usb_phy_set_squelch_detect is used by other code, which may be built
>> as a module, so it should be exported.
>>
>> Signed-off-by: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
>> ---
>> Changes in v6:
>> -New patch in v6 of the sunxi musb support series
>> ---
>>   drivers/phy/phy-sun4i-usb.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/phy/phy-sun4i-usb.c b/drivers/phy/phy-sun4i-usb.c
>> index e17c539..b82aa26 100644
>> --- a/drivers/phy/phy-sun4i-usb.c
>> +++ b/drivers/phy/phy-sun4i-usb.c
>> @@ -212,6 +212,7 @@ void sun4i_usb_phy_set_squelch_detect(struct phy *_phy, bool enabled)
>>
>>   	sun4i_usb_phy_write(phy, PHY_SQUELCH_DETECT, enabled ? 0 : 2, 2);
>>   }
>> +EXPORT_SYMBOL(sun4i_usb_phy_set_squelch_detect);
>
> EXPORT_SYMBOL_GPL?

Both work for me, feel free to fix this up if you prefer _GPL.

Regards,

Hans
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2015-07-19 10:58 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-08 14:41 [PATCH v6 0/4] musb: sunxi: Add support for the Allwinner sunxi musb Hans de Goede
2015-07-08 14:41 ` Hans de Goede
2015-07-08 14:41 ` [PATCH v6 1/4] phy-sun4i-usb: Add missing EXPORT_SYMBOL for sun4i_usb_phy_set_squelch_detect Hans de Goede
2015-07-08 14:41   ` Hans de Goede
2015-07-15 11:47   ` Kishon Vijay Abraham I
2015-07-15 11:47     ` Kishon Vijay Abraham I
2015-07-15 12:35   ` Kishon Vijay Abraham I
2015-07-15 12:35     ` Kishon Vijay Abraham I
2015-07-19 10:58     ` Hans de Goede [this message]
2015-07-19 10:58       ` Hans de Goede
2015-07-08 14:41 ` [PATCH v6 2/4] musb: sunxi: Add support for the Allwinner sunxi musb controller Hans de Goede
2015-07-08 14:41   ` Hans de Goede
2015-07-08 14:41 ` [PATCH v6 3/4] musb: sunxi: Add support for musb controller in A31 SoC Hans de Goede
2015-07-08 14:41   ` Hans de Goede
2015-07-08 14:41 ` [PATCH v6 4/4] musb: sunxi: Add support for musb controller in A33 SoC Hans de Goede
2015-07-08 14:41   ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55AB82EC.7050309@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.