All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Vrabel <david.vrabel@citrix.com>
To: Juergen Gross <jgross@suse.com>, <linux-kernel@vger.kernel.org>,
	<xen-devel@lists.xensource.com>, <konrad.wilk@oracle.com>,
	<david.vrabel@citrix.com>, <boris.ostrovsky@oracle.com>
Subject: Re: [Xen-devel] [PATCH] xen: release lock occasionally during ballooning
Date: Mon, 20 Jul 2015 11:15:58 +0100	[thread overview]
Message-ID: <55ACCA5E.9070100@citrix.com> (raw)
In-Reply-To: <1436539354-27850-1-git-send-email-jgross@suse.com>

On 10/07/15 15:42, Juergen Gross wrote:
> When dom0 is being ballooned balloon_process() will hold the balloon
> mutex until it is finished. This will block e.g. creation of new
> domains as the device backends for the new domain need some
> autoballooned pages for the ring buffers.
> 
> Avoid this by releasing the balloon mutex from time to time during
> ballooning. Add a state variable to indicate one balloon_process()
> is active to avoid multiple balloon processes fighting for the mutex.

Is this state variable necessary? balloon_process() is a work item so
there should only be one instance of it running anyway, yes?

David

WARNING: multiple messages have this Message-ID (diff)
From: David Vrabel <david.vrabel@citrix.com>
To: Juergen Gross <jgross@suse.com>,
	linux-kernel@vger.kernel.org, xen-devel@lists.xensource.com,
	konrad.wilk@oracle.com, david.vrabel@citrix.com,
	boris.ostrovsky@oracle.com
Subject: Re: [Xen-devel] [PATCH] xen: release lock occasionally during ballooning
Date: Mon, 20 Jul 2015 11:15:58 +0100	[thread overview]
Message-ID: <55ACCA5E.9070100@citrix.com> (raw)
In-Reply-To: <1436539354-27850-1-git-send-email-jgross@suse.com>

On 10/07/15 15:42, Juergen Gross wrote:
> When dom0 is being ballooned balloon_process() will hold the balloon
> mutex until it is finished. This will block e.g. creation of new
> domains as the device backends for the new domain need some
> autoballooned pages for the ring buffers.
> 
> Avoid this by releasing the balloon mutex from time to time during
> ballooning. Add a state variable to indicate one balloon_process()
> is active to avoid multiple balloon processes fighting for the mutex.

Is this state variable necessary? balloon_process() is a work item so
there should only be one instance of it running anyway, yes?

David

  parent reply	other threads:[~2015-07-20 10:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-10 14:42 [PATCH] xen: release lock occasionally during ballooning Juergen Gross
2015-07-10 15:58 ` Boris Ostrovsky
2015-07-20 10:15 ` David Vrabel [this message]
2015-07-20 10:15   ` [Xen-devel] " David Vrabel
2015-07-20 10:46   ` Juergen Gross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55ACCA5E.9070100@citrix.com \
    --to=david.vrabel@citrix.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=jgross@suse.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.