From: Eric Blake <eblake@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, patches@linaro.org
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] qemu-common.h: Document cutils.c string functions
Date: Mon, 20 Jul 2015 10:04:07 -0600 [thread overview]
Message-ID: <55AD1BF7.4020305@redhat.com> (raw)
In-Reply-To: <1437338062-26577-1-git-send-email-peter.maydell@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 863 bytes --]
On 07/19/2015 02:34 PM, Peter Maydell wrote:
> Add documentation comments for various utility string functions
> which we have implemented in util/cutils.c:
> pstrcpy()
> strpadcpy()
> pstrcat()
> strstart()
> stristart()
> qemu_strnlen()
> qemu_strsep()
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> We recommend pstrcpy() &c in HACKING but that's not very helpful
> if we don't actually document their behaviour...
Don't know if we care about US vs. UK spelling in doc comments, so I'll
ignore it, and give:
Reviewed-by: Eric Blake <eblake@redhat.com>
>
> include/qemu-common.h | 114 +++++++++++++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 113 insertions(+), 1 deletion(-)
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Eric Blake <eblake@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH] qemu-common.h: Document cutils.c string functions
Date: Mon, 20 Jul 2015 10:04:07 -0600 [thread overview]
Message-ID: <55AD1BF7.4020305@redhat.com> (raw)
In-Reply-To: <1437338062-26577-1-git-send-email-peter.maydell@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 863 bytes --]
On 07/19/2015 02:34 PM, Peter Maydell wrote:
> Add documentation comments for various utility string functions
> which we have implemented in util/cutils.c:
> pstrcpy()
> strpadcpy()
> pstrcat()
> strstart()
> stristart()
> qemu_strnlen()
> qemu_strsep()
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> We recommend pstrcpy() &c in HACKING but that's not very helpful
> if we don't actually document their behaviour...
Don't know if we care about US vs. UK spelling in doc comments, so I'll
ignore it, and give:
Reviewed-by: Eric Blake <eblake@redhat.com>
>
> include/qemu-common.h | 114 +++++++++++++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 113 insertions(+), 1 deletion(-)
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-07-20 16:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-19 20:34 [Qemu-trivial] [PATCH] qemu-common.h: Document cutils.c string functions Peter Maydell
2015-07-19 20:34 ` [Qemu-devel] " Peter Maydell
2015-07-20 16:04 ` Eric Blake [this message]
2015-07-20 16:04 ` Eric Blake
2015-07-27 19:23 ` [Qemu-trivial] " Michael Tokarev
2015-07-27 19:23 ` [Qemu-devel] " Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55AD1BF7.4020305@redhat.com \
--to=eblake@redhat.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.