From: John Snow <jsnow@redhat.com>
To: Stefan Weil <sw@weilnetz.de>,
QEMU Trivial <qemu-trivial@nongnu.org>,
Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developer <qemu-devel@nongnu.org>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH for-2.4] tests: Fix broken targets check-report-qtest-*
Date: Mon, 20 Jul 2015 12:25:21 -0400 [thread overview]
Message-ID: <55AD20F1.9070607@redhat.com> (raw)
In-Reply-To: <1437231284-17455-1-git-send-email-sw@weilnetz.de>
On 07/18/2015 10:54 AM, Stefan Weil wrote:
> They need QTEST_QEMU_IMG. Without it, the tests raise an assertion:
>
> $ make -C bin check-report-qtest-i386.xml
> make: Entering directory 'bin'
> GTESTER check-report-qtest-i386.xml
> blkdebug: Suspended request 'A'
> blkdebug: Resuming request 'A'
> ahci-test: tests/libqos/libqos.c:162:
> mkimg: Assertion `qemu_img_path' failed.
> main-loop: WARNING: I/O thread spun for 1000 iterations
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> tests/Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/Makefile b/tests/Makefile
> index 2c4b8dc..8d26736 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -478,6 +478,7 @@ $(patsubst %, check-%, $(check-unit-y)): check-%: %
>
> $(patsubst %, check-report-qtest-%.xml, $(QTEST_TARGETS)): check-report-qtest-%.xml: $(check-qtest-y)
> $(call quiet-command,QTEST_QEMU_BINARY=$*-softmmu/qemu-system-$* \
> + QTEST_QEMU_IMG=qemu-img$(EXESUF) \
> gtester -q $(GTESTER_OPTIONS) -o $@ -m=$(SPEED) $(check-qtest-$*-y),"GTESTER $@")
>
> check-report-unit.xml: $(check-unit-y)
>
Tentatively:
Thanks, applied to my IDE tree:
https://github.com/jnsnow/qemu/commits/ide
https://github.com/jnsnow/qemu.git
--js
WARNING: multiple messages have this Message-ID (diff)
From: John Snow <jsnow@redhat.com>
To: Stefan Weil <sw@weilnetz.de>,
QEMU Trivial <qemu-trivial@nongnu.org>,
Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developer <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH for-2.4] tests: Fix broken targets check-report-qtest-*
Date: Mon, 20 Jul 2015 12:25:21 -0400 [thread overview]
Message-ID: <55AD20F1.9070607@redhat.com> (raw)
In-Reply-To: <1437231284-17455-1-git-send-email-sw@weilnetz.de>
On 07/18/2015 10:54 AM, Stefan Weil wrote:
> They need QTEST_QEMU_IMG. Without it, the tests raise an assertion:
>
> $ make -C bin check-report-qtest-i386.xml
> make: Entering directory 'bin'
> GTESTER check-report-qtest-i386.xml
> blkdebug: Suspended request 'A'
> blkdebug: Resuming request 'A'
> ahci-test: tests/libqos/libqos.c:162:
> mkimg: Assertion `qemu_img_path' failed.
> main-loop: WARNING: I/O thread spun for 1000 iterations
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> tests/Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/Makefile b/tests/Makefile
> index 2c4b8dc..8d26736 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -478,6 +478,7 @@ $(patsubst %, check-%, $(check-unit-y)): check-%: %
>
> $(patsubst %, check-report-qtest-%.xml, $(QTEST_TARGETS)): check-report-qtest-%.xml: $(check-qtest-y)
> $(call quiet-command,QTEST_QEMU_BINARY=$*-softmmu/qemu-system-$* \
> + QTEST_QEMU_IMG=qemu-img$(EXESUF) \
> gtester -q $(GTESTER_OPTIONS) -o $@ -m=$(SPEED) $(check-qtest-$*-y),"GTESTER $@")
>
> check-report-unit.xml: $(check-unit-y)
>
Tentatively:
Thanks, applied to my IDE tree:
https://github.com/jnsnow/qemu/commits/ide
https://github.com/jnsnow/qemu.git
--js
next prev parent reply other threads:[~2015-07-20 16:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-18 14:54 [Qemu-trivial] [PATCH for-2.4] tests: Fix broken targets check-report-qtest-* Stefan Weil
2015-07-18 14:54 ` [Qemu-devel] " Stefan Weil
2015-07-20 16:24 ` [Qemu-trivial] " John Snow
2015-07-20 16:24 ` John Snow
2015-07-20 16:25 ` John Snow [this message]
2015-07-20 16:25 ` John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55AD20F1.9070607@redhat.com \
--to=jsnow@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.