From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Andrey Danin <danindrey-JGs/UdohzUI@public.gmane.org>
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devel-tBiZLqfeLfOHmIFyCCdPziST3g8Odh+X@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
ac100-oU9gvf+ajcQ97yFScArB1dHuzzzSOjJt@public.gmane.org,
Laxman Dewangan
<ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
Thierry Reding
<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Alexandre Courbot
<gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Greg Kroah-Hartman
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
Julian Andres Klode <jak-4HMq4SXA452hPH1hqNUYSQ@public.gmane.org>,
Marc Dietrich <marvin24-Mmb7MZpHnFY@public.gmane.org>
Subject: Re: [PATCH v3 2/4] staging/nvec: reimplement on top of tegra i2c driver
Date: Mon, 20 Jul 2015 16:18:11 -0600 [thread overview]
Message-ID: <55AD73A3.6000706@wwwdotorg.org> (raw)
In-Reply-To: <1437424546-30405-3-git-send-email-danindrey-JGs/UdohzUI@public.gmane.org>
On 07/20/2015 02:35 PM, Andrey Danin wrote:
> Remove i2c controller related code and use tegra i2c driver in slave mode.
> Update nvec documentation.
> diff --git a/Documentation/devicetree/bindings/nvec/nvidia,nvec.txt b/Documentation/devicetree/bindings/nvec/nvidia,nvec.txt
I would expect this patch to add a new binding file
nvidia,nvec-slave.txt so that the filename continues to match the
compatible value it documents. This patch introduces a new binding for
the NVEC slave as opposed to modifying the existing binding.
> +- compatible : should be "nvidia,nvec-slave".
> +- reg: the i2c address of the slave controller
I think "the I2C address to respond to" would be clearer? You might also
mention that this needs to include flags from <dt-bindings/i2c/ic2.h>.
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/4] staging/nvec: reimplement on top of tegra i2c driver
Date: Mon, 20 Jul 2015 16:18:11 -0600 [thread overview]
Message-ID: <55AD73A3.6000706@wwwdotorg.org> (raw)
In-Reply-To: <1437424546-30405-3-git-send-email-danindrey@mail.ru>
On 07/20/2015 02:35 PM, Andrey Danin wrote:
> Remove i2c controller related code and use tegra i2c driver in slave mode.
> Update nvec documentation.
> diff --git a/Documentation/devicetree/bindings/nvec/nvidia,nvec.txt b/Documentation/devicetree/bindings/nvec/nvidia,nvec.txt
I would expect this patch to add a new binding file
nvidia,nvec-slave.txt so that the filename continues to match the
compatible value it documents. This patch introduces a new binding for
the NVEC slave as opposed to modifying the existing binding.
> +- compatible : should be "nvidia,nvec-slave".
> +- reg: the i2c address of the slave controller
I think "the I2C address to respond to" would be clearer? You might also
mention that this needs to include flags from <dt-bindings/i2c/ic2.h>.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: Andrey Danin <danindrey@mail.ru>
Cc: devicetree@vger.kernel.org, devel@linuxdriverproject.org,
linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
ac100@lists.launchpad.net, Laxman Dewangan <ldewangan@nvidia.com>,
Wolfram Sang <wsa@the-dreams.de>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Russell King <linux@arm.linux.org.uk>,
Thierry Reding <thierry.reding@gmail.com>,
Alexandre Courbot <gnurou@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Julian Andres Klode <jak@jak-linux.org>,
Marc Dietrich <marvin24@gmx.de>
Subject: Re: [PATCH v3 2/4] staging/nvec: reimplement on top of tegra i2c driver
Date: Mon, 20 Jul 2015 16:18:11 -0600 [thread overview]
Message-ID: <55AD73A3.6000706@wwwdotorg.org> (raw)
In-Reply-To: <1437424546-30405-3-git-send-email-danindrey@mail.ru>
On 07/20/2015 02:35 PM, Andrey Danin wrote:
> Remove i2c controller related code and use tegra i2c driver in slave mode.
> Update nvec documentation.
> diff --git a/Documentation/devicetree/bindings/nvec/nvidia,nvec.txt b/Documentation/devicetree/bindings/nvec/nvidia,nvec.txt
I would expect this patch to add a new binding file
nvidia,nvec-slave.txt so that the filename continues to match the
compatible value it documents. This patch introduces a new binding for
the NVEC slave as opposed to modifying the existing binding.
> +- compatible : should be "nvidia,nvec-slave".
> +- reg: the i2c address of the slave controller
I think "the I2C address to respond to" would be clearer? You might also
mention that this needs to include flags from <dt-bindings/i2c/ic2.h>.
next prev parent reply other threads:[~2015-07-20 22:18 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-20 20:35 [PATCH v3 0/4] arm: tegra: implement NVEC driver using tegra i2c Andrey Danin
2015-07-20 20:35 ` Andrey Danin
2015-07-20 20:35 ` Andrey Danin
[not found] ` <1437424546-30405-1-git-send-email-danindrey-JGs/UdohzUI@public.gmane.org>
2015-07-20 20:35 ` [PATCH v3 1/4] i2c: tegra: implement slave mode Andrey Danin
2015-07-20 20:35 ` Andrey Danin
2015-07-20 20:35 ` Andrey Danin
2015-07-24 9:27 ` Wolfram Sang
2015-07-24 9:27 ` Wolfram Sang
2015-07-24 10:18 ` Andrey Danin
2015-07-24 10:18 ` Andrey Danin
[not found] ` <55B210F4.6030700-JGs/UdohzUI@public.gmane.org>
2015-07-24 10:52 ` Wolfram Sang
2015-07-24 10:52 ` Wolfram Sang
2015-07-24 10:52 ` Wolfram Sang
2015-08-20 12:14 ` Andrey Danin
2015-08-20 12:14 ` Andrey Danin
2015-08-20 12:14 ` Andrey Danin
2015-08-20 12:14 ` Andrey Danin
[not found] ` <55D5C4AA.2000307-JGs/UdohzUI@public.gmane.org>
2015-09-08 11:46 ` Wolfram Sang
2015-09-08 11:46 ` Wolfram Sang
2015-09-08 11:46 ` Wolfram Sang
2015-09-08 12:31 ` Andrey Danin
2015-09-08 12:31 ` Andrey Danin
2015-09-08 12:31 ` Andrey Danin
2015-07-20 20:35 ` [PATCH v3 2/4] staging/nvec: reimplement on top of tegra i2c driver Andrey Danin
2015-07-20 20:35 ` Andrey Danin
2015-07-20 20:35 ` Andrey Danin
[not found] ` <1437424546-30405-3-git-send-email-danindrey-JGs/UdohzUI@public.gmane.org>
2015-07-20 22:18 ` Stephen Warren [this message]
2015-07-20 22:18 ` Stephen Warren
2015-07-20 22:18 ` Stephen Warren
2015-07-20 20:35 ` [PATCH v3 3/4] staging/nvec: remove old code Andrey Danin
2015-07-20 20:35 ` Andrey Danin
2015-07-20 20:35 ` Andrey Danin
2015-07-20 20:35 ` [PATCH v3 4/4] dt: paz00: define nvec as child of i2c bus Andrey Danin
2015-07-20 20:35 ` Andrey Danin
2015-07-20 20:35 ` Andrey Danin
2015-07-20 22:19 ` Stephen Warren
2015-07-20 22:19 ` Stephen Warren
[not found] ` <55AD73F4.2050502-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2015-07-21 6:35 ` Andrey Danin
2015-07-21 6:35 ` Andrey Danin
2015-07-21 6:35 ` Andrey Danin
2015-07-21 8:25 ` Marc Dietrich
2015-07-21 8:25 ` Marc Dietrich
2015-07-21 8:25 ` Marc Dietrich
2015-07-21 8:51 ` Andrey Danin
2015-07-21 8:51 ` Andrey Danin
2015-07-21 8:51 ` Andrey Danin
[not found] ` <55AE0803.10603-JGs/UdohzUI@public.gmane.org>
2015-07-21 11:57 ` Marc Dietrich
2015-07-21 11:57 ` Marc Dietrich
2015-07-21 11:57 ` Marc Dietrich
2015-07-21 20:52 ` Wolfram Sang
2015-07-21 20:52 ` Wolfram Sang
2015-07-21 20:52 ` Wolfram Sang
2015-07-21 8:38 ` [PATCH v3 0/4] arm: tegra: implement NVEC driver using tegra i2c Andrey Danin
2015-07-21 8:38 ` Andrey Danin
2015-07-21 8:38 ` Andrey Danin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55AD73A3.6000706@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=ac100-oU9gvf+ajcQ97yFScArB1dHuzzzSOjJt@public.gmane.org \
--cc=danindrey-JGs/UdohzUI@public.gmane.org \
--cc=devel-tBiZLqfeLfOHmIFyCCdPziST3g8Odh+X@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
--cc=jak-4HMq4SXA452hPH1hqNUYSQ@public.gmane.org \
--cc=ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=marvin24-Mmb7MZpHnFY@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.