All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>,
	Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
	Linux-sh list <linux-sh@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: Traceback in -next due to commit 'clockevents/drivers/sh_tmu: Migrate to new 'set-state' interfa
Date: Tue, 21 Jul 2015 02:50:36 +0000	[thread overview]
Message-ID: <55ADB37C.5020306@roeck-us.net> (raw)
In-Reply-To: <20150721023114.GD4994@linux>

On 07/20/2015 07:31 PM, Viresh Kumar wrote:
> On 20-07-15, 14:07, Guenter Roeck wrote:
>> Hi,
>>
>> Commit 991a7f4970ed1 ("clockevents/drivers/sh_tmu: Migrate to new 'set-state' interface")
>> in -next causes the following traceback. This is seen with qemu runs for the sh target.
>>
>> ------------[ cut here ]------------
>> WARNING: at drivers/clocksource/sh_tmu.c:202
>> Modules linked in:
>
> Can you please try this:
>
> diff --git a/drivers/clocksource/sh_tmu.c b/drivers/clocksource/sh_tmu.c
> index 43c98143f79a..469e776ec17a 100644
> --- a/drivers/clocksource/sh_tmu.c
> +++ b/drivers/clocksource/sh_tmu.c
> @@ -362,7 +362,8 @@ static int sh_tmu_clock_event_shutdown(struct clock_event_device *ced)
>   {
>   	struct sh_tmu_channel *ch = ced_to_sh_tmu(ced);
>
> -	sh_tmu_disable(ch);
> +	if (clockevent_state_oneshot(ced) || clockevent_state_periodic(ced))
> +		sh_tmu_disable(ch);
>   	return 0;
>   }
>
>
This patch fixes the problem.

Thanks,
Guenter


WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>,
	Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
	Linux-sh list <linux-sh@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: Traceback in -next due to commit 'clockevents/drivers/sh_tmu: Migrate to new 'set-state' interface'
Date: Mon, 20 Jul 2015 19:50:36 -0700	[thread overview]
Message-ID: <55ADB37C.5020306@roeck-us.net> (raw)
In-Reply-To: <20150721023114.GD4994@linux>

On 07/20/2015 07:31 PM, Viresh Kumar wrote:
> On 20-07-15, 14:07, Guenter Roeck wrote:
>> Hi,
>>
>> Commit 991a7f4970ed1 ("clockevents/drivers/sh_tmu: Migrate to new 'set-state' interface")
>> in -next causes the following traceback. This is seen with qemu runs for the sh target.
>>
>> ------------[ cut here ]------------
>> WARNING: at drivers/clocksource/sh_tmu.c:202
>> Modules linked in:
>
> Can you please try this:
>
> diff --git a/drivers/clocksource/sh_tmu.c b/drivers/clocksource/sh_tmu.c
> index 43c98143f79a..469e776ec17a 100644
> --- a/drivers/clocksource/sh_tmu.c
> +++ b/drivers/clocksource/sh_tmu.c
> @@ -362,7 +362,8 @@ static int sh_tmu_clock_event_shutdown(struct clock_event_device *ced)
>   {
>   	struct sh_tmu_channel *ch = ced_to_sh_tmu(ced);
>
> -	sh_tmu_disable(ch);
> +	if (clockevent_state_oneshot(ced) || clockevent_state_periodic(ced))
> +		sh_tmu_disable(ch);
>   	return 0;
>   }
>
>
This patch fixes the problem.

Thanks,
Guenter


  reply	other threads:[~2015-07-21  2:50 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-20 21:07 Traceback in -next due to commit 'clockevents/drivers/sh_tmu: Migrate to new 'set-state' interface' Guenter Roeck
2015-07-20 21:07 ` Guenter Roeck
2015-07-21  2:31 ` Viresh Kumar
2015-07-21  2:43   ` Traceback in -next due to commit 'clockevents/drivers/sh_tmu: Migrate to new 'set-state' interfa Viresh Kumar
2015-07-21  2:50   ` Guenter Roeck [this message]
2015-07-21  2:50     ` Traceback in -next due to commit 'clockevents/drivers/sh_tmu: Migrate to new 'set-state' interface' Guenter Roeck
2015-07-21  3:15     ` Viresh Kumar
2015-07-21  3:27       ` Traceback in -next due to commit 'clockevents/drivers/sh_tmu: Migrate to new 'set-state' interfa Viresh Kumar
2015-08-03 15:03     ` Geert Uytterhoeven
2015-08-03 15:03       ` Traceback in -next due to commit 'clockevents/drivers/sh_tmu: Migrate to new 'set-state' interface' Geert Uytterhoeven
2015-08-03 15:51       ` Viresh Kumar
2015-08-03 15:52         ` Traceback in -next due to commit 'clockevents/drivers/sh_tmu: Migrate to new 'set-state' interfa Viresh Kumar
2015-08-05 12:38         ` Daniel Lezcano
2015-08-05 12:38           ` Traceback in -next due to commit 'clockevents/drivers/sh_tmu: Migrate to new 'set-state' interface' Daniel Lezcano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55ADB37C.5020306@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=daniel.lezcano@linaro.org \
    --cc=laurent.pinchart+renesas@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.